From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC][PATCH 3/9] ARM: OMAP3: cpuidle - set enable_off_mode as static
Date: Fri, 23 Mar 2012 13:38:10 +0100 [thread overview]
Message-ID: <4F6C6EB2.70101@linaro.org> (raw)
In-Reply-To: <CAORVsuVBC2TgVyt-PFWV878mXpM1GqETQnzdVi0ZYH-2x8D4nQ@mail.gmail.com>
On 03/23/2012 01:22 PM, Jean Pihet wrote:
> On Fri, Mar 23, 2012 at 10:26 AM, Daniel Lezcano
> <daniel.lezcano@linaro.org> wrote:
>> This variable is only used in the pm-debug.c file.
>>
>> Signed-off-by: Daniel Lezcano<daniel.lezcano@linaro.org>
>> ---
>> arch/arm/mach-omap2/pm-debug.c | 2 +-
>> arch/arm/mach-omap2/pm.h | 30 ++++++++++++------------------
>> 2 files changed, 13 insertions(+), 19 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/pm-debug.c b/arch/arm/mach-omap2/pm-debug.c
>> index 814bcd9..86aa398 100644
>> --- a/arch/arm/mach-omap2/pm-debug.c
>> +++ b/arch/arm/mach-omap2/pm-debug.c
>> @@ -38,7 +38,7 @@
>> #include "prm2xxx_3xxx.h"
>> #include "pm.h"
>>
>> -u32 enable_off_mode;
>> +static u32 enable_off_mode;
> It is stil needed in cpuidle34xx.c.
ok.
>> #ifdef CONFIG_DEBUG_FS
>> #include<linux/debugfs.h>
>> diff --git a/arch/arm/mach-omap2/pm.h b/arch/arm/mach-omap2/pm.h
>> index af73a86..f5c3072 100644
>> --- a/arch/arm/mach-omap2/pm.h
>> +++ b/arch/arm/mach-omap2/pm.h
>> @@ -25,6 +25,18 @@ extern int omap4_idle_init(void);
>> extern int omap_pm_clkdms_setup(struct clockdomain *clkdm, void *unused);
>> extern int (*omap_pm_suspend)(void);
>>
>> +/*
>> + * cpuidle mach specific parameters
>> + *
>> + * The board code can override the default C-states definition using
>> + * omap3_pm_init_cpuidle
>> + */
>> +struct cpuidle_params {
>> + u32 exit_latency; /* exit_latency = sleep + wake-up latencies */
>> + u32 target_residency;
>> + u8 valid; /* validates the C-state */
>> +};
>> +
> Is this move needed? This will be removed in a later patch.
No, I think I did a bad manipulation.
>> #if defined(CONFIG_PM_OPP)
>> extern int omap3_opp_init(void);
>> extern int omap4_opp_init(void);
>> @@ -39,27 +51,9 @@ static inline int omap4_opp_init(void)
>> }
>> #endif
>>
>> -/*
>> - * cpuidle mach specific parameters
>> - *
>> - * The board code can override the default C-states definition using
>> - * omap3_pm_init_cpuidle
>> - */
>> -struct cpuidle_params {
>> - u32 exit_latency; /* exit_latency = sleep + wake-up latencies */
>> - u32 target_residency;
>> - u8 valid; /* validates the C-state */
>> -};
>> -
>> extern int omap3_pm_get_suspend_state(struct powerdomain *pwrdm);
>> extern int omap3_pm_set_suspend_state(struct powerdomain *pwrdm, int state);
>>
>> -#ifdef CONFIG_PM_DEBUG
>> -extern u32 enable_off_mode;
>> -#else
>> -#define enable_off_mode 0
>> -#endif
>> -
>> #if defined(CONFIG_PM_DEBUG)&& defined(CONFIG_DEBUG_FS)
>> extern void pm_dbg_update_time(struct powerdomain *pwrdm, int prev);
>> #else
>> --
>> 1.7.5.4
>>
>
> Jean
--
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2012-03-23 12:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-23 9:26 [RFC][PATCH 1/9] ARM: OMAP3: cpuidle - remove rx51 cpuidle parameters table Daniel Lezcano
2012-03-23 9:26 ` [RFC][PATCH 2/9] ARM: OMAP3: cpuidle - remove next_valid_state function Daniel Lezcano
2012-03-23 12:21 ` Jean Pihet
2012-03-23 9:26 ` [RFC][PATCH 3/9] ARM: OMAP3: cpuidle - set enable_off_mode as static Daniel Lezcano
2012-03-23 12:22 ` Jean Pihet
2012-03-23 12:38 ` Daniel Lezcano [this message]
2012-03-23 9:26 ` [RFC][PATCH 4/9] ARM: OMAP3: define cpuidle statically Daniel Lezcano
2012-03-23 12:35 ` Jean Pihet
2012-03-23 12:41 ` Daniel Lezcano
2012-03-23 13:17 ` Jean Pihet
2012-03-23 9:26 ` [RFC][PATCH 5/9] ARM: OMAP3: cpuidle - remove the 'valid' field Daniel Lezcano
2012-03-23 9:26 ` [RFC][PATCH 6/9] ARM: OMAP3: cpuidle - remove cpuidle_params_table Daniel Lezcano
2012-03-23 9:26 ` [RFC][PATCH 7/9] ARM: OMAP3: define statically the omap3_idle_data Daniel Lezcano
2012-03-23 9:26 ` [RFC][PATCH 8/9] ARM: OMAP3: cpuidle - use omap3_idle_data directly Daniel Lezcano
2012-03-23 9:26 ` [RFC][PATCH 9/9] ARM: OMAP3/4: consolidate cpuidle Makefile Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6C6EB2.70101@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).