From: rmallon@gmail.com (Ryan Mallon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: ep93xx: Don't try to release not acquired GPIO lines
Date: Wed, 11 Apr 2012 12:09:14 +1000 [thread overview]
Message-ID: <4F84E7CA.8000508@gmail.com> (raw)
In-Reply-To: <ADE657CA350FB648AAC2C43247A983F002069840A362@AUSP01VMBX24.collaborationhost.net>
On 06/04/12 02:39, H Hartley Sweeten wrote:
> On Thursday, April 05, 2012 4:44 AM, Rafal Prylowski wrote:
>> Fail path of ep93xx_keypad_acquire_gpio() tries to release
>> GPIO lines not acquired successfully before. Fix this.
>>
>> Signed-off-by: Rafal Prylowski <prylowski@metasoft.pl>
>> Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
>> Cc: Ryan Mallon <rmallon@gmail.com>
>>
>> ---
>> Patch applies to v3.4rc1.
>>
>> arch/arm/mach-ep93xx/core.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Index: linux-2.6/arch/arm/mach-ep93xx/core.c
>> ===================================================================
>> --- linux-2.6.orig/arch/arm/mach-ep93xx/core.c
>> +++ linux-2.6/arch/arm/mach-ep93xx/core.c
>> @@ -734,7 +734,7 @@ int ep93xx_keypad_acquire_gpio(struct pl
>> fail_gpio_d:
>> gpio_free(EP93XX_GPIO_LINE_C(i));
>> fail_gpio_c:
>> - for ( ; i >= 0; --i) {
>> + for (--i; i >= 0; --i) {
>> gpio_free(EP93XX_GPIO_LINE_C(i));
>> gpio_free(EP93XX_GPIO_LINE_D(i));
>> }
>
> Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Applied to ep93xx-fixes on https://github.com/RyanMallon/linux-ep93xx
Thanks,
~Ryan
prev parent reply other threads:[~2012-04-11 2:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-05 11:44 [PATCH] arm: ep93xx: Don't try to release not acquired GPIO lines Rafal Prylowski
2012-04-05 16:39 ` H Hartley Sweeten
2012-04-11 2:09 ` Ryan Mallon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F84E7CA.8000508@gmail.com \
--to=rmallon@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).