From: viresh.kumar@st.com (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] dma/amba-pl08x: add support for the Nomadik variant
Date: Wed, 11 Apr 2012 13:29:56 +0530 [thread overview]
Message-ID: <4F8539FC.4030503@st.com> (raw)
In-Reply-To: <CACRpkdaz9g7cRc1rAMHUzRbLcrYtB-kPCB6bFEMYZxxmWfLNSg@mail.gmail.com>
On 4/11/2012 1:29 PM, Linus Walleij wrote:
>>> >> + ch->locked = true;
>>> >> + } else
>>> >> + ch->locked = false;
>>> >> + }
>>> >> +
>> >
>> > Memory for ch is allocated with kmalloc and so its default value is garbage.
>> > So we must set locked to false in else part here.
> Hm maybe better to kzalloc() the channel structs?
>
Then, you can remove code which makes its field zero explicitly, as it is already
zero.
--
viresh
prev parent reply other threads:[~2012-04-11 7:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-09 20:53 [PATCH 2/2] dma/amba-pl08x: add support for the Nomadik variant Linus Walleij
2012-04-10 3:43 ` Viresh Kumar
2012-04-11 7:59 ` Linus Walleij
2012-04-11 7:59 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8539FC.4030503@st.com \
--to=viresh.kumar@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).