From: viresh.kumar@st.com (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2 v2] dma/amba-pl08x: add support for the Nomadik variant
Date: Thu, 12 Apr 2012 09:12:22 +0530 [thread overview]
Message-ID: <4F864F1E.8030708@st.com> (raw)
In-Reply-To: <1334185214-27250-1-git-send-email-linus.walleij@linaro.org>
On 4/12/2012 4:30 AM, Linus Walleij wrote:
> The Nomadik PL080 variant has some extra protection bits that
> may be set, so we need to check these bits to see if the
> channels are actually available for the DMAengine to use.
>
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: Viresh Kumar <viresh.kumar@st.com>
> Cc: Alim Akhtar <alim.akhtar@gmail.com>
> Cc: Alessandro Rubini <rubini@gnudd.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
> @@ -1917,7 +1926,7 @@ static int pl08x_probe(struct amba_device *adev, const struct amba_id *id)
> }
>
> /* Initialize physical channels */
> - pl08x->phy_chans = kmalloc((vd->channels * sizeof(*pl08x->phy_chans)),
> + pl08x->phy_chans = kzalloc((vd->channels * sizeof(*pl08x->phy_chans)),
> GFP_KERNEL);
> if (!pl08x->phy_chans) {
> dev_err(&adev->dev, "%s failed to allocate "
> @@ -1934,6 +1943,22 @@ static int pl08x_probe(struct amba_device *adev, const struct amba_id *id)
> spin_lock_init(&ch->lock);
> ch->serving = NULL;
I meant removing this one too. :)
Reviewed-by: Viresh Kumar <viresh.kumar@st.com>
next prev parent reply other threads:[~2012-04-12 3:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-11 23:00 [PATCH 2/2 v2] dma/amba-pl08x: add support for the Nomadik variant Linus Walleij
2012-04-11 23:05 ` Russell King - ARM Linux
2012-04-12 3:42 ` Viresh Kumar [this message]
2012-04-12 6:56 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F864F1E.8030708@st.com \
--to=viresh.kumar@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox