From: viresh.kumar@st.com (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: Allocate and add clock lookups from clk_register()
Date: Fri, 13 Apr 2012 15:40:44 +0530 [thread overview]
Message-ID: <4F87FBA4.7000700@st.com> (raw)
In-Reply-To: <20120413100133.GI3852@pengutronix.de>
On 4/13/2012 3:31 PM, Sascha Hauer wrote:
>> > Pointer to original discussion:
>> > http://www.spinics.net/lists/arm-kernel/msg169133.html
> For reasons mentioned in this thread (long argument list, line wraps in
> clk_register calls, only leaf nodes need lookups) I don't think this is
> a good idea.
For that we can pass struct as argument.
>> > */
>> > struct clk *clk_register(struct device *dev, const char *name,
>> > const struct clk_ops *ops, struct clk_hw *hw,
>> > - const char **parent_names, u8 num_parents, unsigned long flags)
>> > + const char **parent_names, u8 num_parents, unsigned long flags,
>> > + struct clk_lookup **cl, const char *dev_id, const char *con_id)
>> > {
> Also this doesn't handle the case when multiple lookups are associated
> with a single clock (which is quite a common case on some SoCs). Yes,
> we could still use the returned clk to register the additional lookups,
> but that would make the advantage of this patch even smaller.
If there is a better way of managing this within the clock framework,
without platforms having to do clkdev management, we can choose that.
My main idea was to make platform code lighter.
We can do one more thing here to support multiple lookups for same clocks:
We can pass array of struct having these three args as its fields.
--
viresh
next prev parent reply other threads:[~2012-04-13 10:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-13 6:34 [PATCH] clk: Allocate and add clock lookups from clk_register() Viresh Kumar
2012-04-13 8:56 ` Richard Zhao
2012-04-13 9:25 ` Viresh Kumar
2012-04-13 10:01 ` Sascha Hauer
2012-04-13 10:10 ` Viresh Kumar [this message]
2012-04-13 10:30 ` Russell King - ARM Linux
2012-04-13 11:16 ` Domenico Andreoli
2012-04-16 3:48 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F87FBA4.7000700@st.com \
--to=viresh.kumar@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox