linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: viresh.kumar@st.com (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] CLKDEV: Add helper routines to allocate and add clkdevs for given struct clk *
Date: Tue, 17 Apr 2012 09:04:15 +0530	[thread overview]
Message-ID: <4F8CE4B7.8090003@st.com> (raw)
In-Reply-To: <20120416204609.GA8548@glitch>

On 4/17/2012 2:16 AM, Domenico Andreoli wrote:
>> > +struct clk_lookup * __init_refok
>> > +clkdev_alloc(struct clk *clk, const char *con_id, const char *dev_fmt, ...)
>> > +{
>> > +	struct clk_lookup * cl;
>> > +	va_list ap = NULL;

> so I finally tested it with this modification:
> 
> 	if (dev_fmt) {
> 		va_start(ap, dev_fmt);
> 		cl = clkdev_alloc_valist(clk, con_id, dev_fmt, ap);
> 		va_end(ap);
> 	} else
> 		cl = clkdev_alloc(clk, con_id, NULL);

Isn't this a infinite loop now, when dev_fmt is passed as NULL?


-- 
viresh

  parent reply	other threads:[~2012-04-17  3:34 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-16  5:19 [PATCH] CLKDEV: Add helper routines to allocate and add clkdevs for given struct clk * Viresh Kumar
2012-04-16 10:25 ` Domenico Andreoli
2012-04-16 10:30   ` Viresh Kumar
2012-04-16 10:38     ` Russell King - ARM Linux
2012-04-16 10:39       ` Viresh Kumar
2012-04-16 10:56       ` Domenico Andreoli
2012-04-16 10:58         ` Viresh Kumar
2012-04-16 11:02         ` Russell King - ARM Linux
2012-04-16 11:52           ` Domenico Andreoli
2012-04-16 13:39       ` viresh kumar
2012-04-16 20:46         ` Domenico Andreoli
2012-04-16 20:51           ` s.hauer at pengutronix.de
2012-04-17  3:39             ` Viresh Kumar
2012-04-17  3:48             ` [PATCH V3] " Viresh Kumar
2012-04-17  3:34           ` Viresh Kumar [this message]
2012-04-16 20:56         ` [PATCH] " s.hauer at pengutronix.de
2012-04-16 21:06           ` Domenico Andreoli
2012-04-16 21:12             ` s.hauer at pengutronix.de
2012-04-17  3:40               ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F8CE4B7.8090003@st.com \
    --to=viresh.kumar@st.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).