linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: tegra: Initialize pll_p_out1
@ 2012-04-23  8:31 Peter De Schrijver
  2012-04-23 16:31 ` Stephen Warren
  0 siblings, 1 reply; 3+ messages in thread
From: Peter De Schrijver @ 2012-04-23  8:31 UTC (permalink / raw)
  To: linux-arm-kernel

pll_a uses pll_p_out1 as its parent. Therefore this clock needs to be
initialized to make sure pll_a has a known input clock. Failure to do so
will cause the system to crash early in the bootup.

Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>

--

Changes in v2:

* moved pll_p_out1 initialization to early_init to make it similar to the
  tegra20 code.
---
 arch/arm/mach-tegra/common.c |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-tegra/common.c b/arch/arm/mach-tegra/common.c
index c50f2ee..654a457 100644
--- a/arch/arm/mach-tegra/common.c
+++ b/arch/arm/mach-tegra/common.c
@@ -95,6 +95,17 @@ static __initdata struct tegra_clk_init_table tegra20_clk_init_table[] = {
 };
 #endif
 
+#ifdef CONFIG_ARCH_TEGRA_3x_SOC
+static __initdata struct tegra_clk_init_table tegra30_clk_init_table[] = {
+	/* name		parent		rate		enabled */
+	{ "clk_m",	NULL,		0,		true },
+	{ "pll_p",	"clk_m",	408000000,	true },
+	{ "pll_p_out1",	"pll_p",	9600000,	true },
+	{ NULL,		NULL,		0,		0},
+};
+#endif
+
+
 static void __init tegra_init_cache(u32 tag_latency, u32 data_latency)
 {
 #ifdef CONFIG_CACHE_L2X0
@@ -129,6 +140,7 @@ void __init tegra30_init_early(void)
 {
 	tegra_init_fuse();
 	tegra30_init_clocks();
+	tegra_clk_init_from_table(tegra30_clk_init_table);
 	tegra_init_cache(0x441, 0x551);
 	tegra_pmc_init();
 	tegra_powergate_init();
-- 
1.7.7.rc0.72.g4b5ea.dirty

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] ARM: tegra: Initialize pll_p_out1
  2012-04-23  8:31 [PATCH] ARM: tegra: Initialize pll_p_out1 Peter De Schrijver
@ 2012-04-23 16:31 ` Stephen Warren
  2012-04-24  8:26   ` Peter De Schrijver
  0 siblings, 1 reply; 3+ messages in thread
From: Stephen Warren @ 2012-04-23 16:31 UTC (permalink / raw)
  To: linux-arm-kernel

On 04/23/2012 02:31 AM, Peter De Schrijver wrote:
> pll_a uses pll_p_out1 as its parent. Therefore this clock needs to be
> initialized to make sure pll_a has a known input clock. Failure to do so
> will cause the system to crash early in the bootup.
> 
> Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>

Thanks, applied.

> --
> 
> Changes in v2:


BTW, that "--" needs to be "---" if you don't intend the changelog to
end up in git when I apply the patch.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] ARM: tegra: Initialize pll_p_out1
  2012-04-23 16:31 ` Stephen Warren
@ 2012-04-24  8:26   ` Peter De Schrijver
  0 siblings, 0 replies; 3+ messages in thread
From: Peter De Schrijver @ 2012-04-24  8:26 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Apr 23, 2012 at 06:31:22PM +0200, Stephen Warren wrote:
> On 04/23/2012 02:31 AM, Peter De Schrijver wrote:
> > pll_a uses pll_p_out1 as its parent. Therefore this clock needs to be
> > initialized to make sure pll_a has a known input clock. Failure to do so
> > will cause the system to crash early in the bootup.
> > 
> > Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
> 
> Thanks, applied.
> 
> > --
> > 
> > Changes in v2:
> 
> 
> BTW, that "--" needs to be "---" if you don't intend the changelog to
> end up in git when I apply the patch.

Ok :) I should have just removed this as v1 has never been posted here...

Cheers,

Peter.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-04-24  8:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-23  8:31 [PATCH] ARM: tegra: Initialize pll_p_out1 Peter De Schrijver
2012-04-23 16:31 ` Stephen Warren
2012-04-24  8:26   ` Peter De Schrijver

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).