linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: viresh.kumar@st.com (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/9] SPEAr13xx: Add common clock framework support
Date: Tue, 24 Apr 2012 09:27:45 +0530	[thread overview]
Message-ID: <4F9624B9.4010009@st.com> (raw)
In-Reply-To: <CAJOA=zOiK30SHGxikLmGzdKN3uUBeB7h65C14PiTjvtJE6B=8Q@mail.gmail.com>

On 4/24/2012 3:13 AM, Turquette, Mike wrote:
>> > +void __init spear1310_clk_init(void)
>> > +{
>> > +       struct clk *clk, *clk1;
>> > +
>> > +       clk = clk_register_fixed_rate(NULL, "apb_pclk", NULL, CLK_IS_ROOT, 0);
>> > +       clk_register_clkdev(clk, "apb_pclk", NULL);
> There is no exception handling at all in this function.  Do you just
> expect to fail at some later point?

This is what Russell suggested in his clkdev patch. We don't have to check clk *
returned from clk_register_*(). This will be done in clk_register_clkdev(), clk
lookup wouldn't be registered for failing clocks.

-- 
viresh

  reply	other threads:[~2012-04-24  3:57 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-20 17:22 [PATCH 0/9] Add support for SPEAr13xx SoCs Viresh Kumar
2012-04-20 17:22 ` [PATCH 1/9] SPEAr13xx: Add header files Viresh Kumar
2012-04-20 17:52   ` Arnd Bergmann
2012-04-21 12:27     ` viresh kumar
2012-04-21 18:37       ` Arnd Bergmann
2012-04-23 11:47         ` viresh kumar
2012-04-23 12:25           ` viresh kumar
2012-04-20 17:22 ` [PATCH 2/9] SPEAr13xx: Add source files Viresh Kumar
2012-04-20 18:15   ` Arnd Bergmann
2012-04-21 12:23     ` viresh kumar
2012-04-21 18:31       ` Arnd Bergmann
2012-04-20 17:22 ` [PATCH 3/9] SPEAr13xx: Add common clock framework support Viresh Kumar
2012-04-23 21:43   ` Turquette, Mike
2012-04-24  3:57     ` Viresh Kumar [this message]
2012-04-20 17:22 ` [PATCH 4/9] pinctrl: SPEAr: Create macro for declaring GPIO PINS Viresh Kumar
2012-04-20 17:22 ` [PATCH 6/9] SPEAr13xx: Add dts and dtsi files Viresh Kumar
2012-04-20 17:22 ` [PATCH 7/9] SPEAr13xx: Add compilation support Viresh Kumar
2012-04-20 17:22 ` [PATCH 8/9] SPEAr13xx: Add defconfig Viresh Kumar
2012-04-20 17:22 ` [PATCH 9/9] SPEAr: Update MAINTAINERS and Documentation Viresh Kumar
2012-04-20 18:21 ` [PATCH 0/9] Add support for SPEAr13xx SoCs Arnd Bergmann
2012-04-21 12:17   ` viresh kumar
2012-04-21 12:24     ` Arnd Bergmann
2012-04-21 12:29       ` viresh kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F9624B9.4010009@st.com \
    --to=viresh.kumar@st.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).