[PATCH V3 2/2] watchdog: mpcore: Add DT probing support for ARM mpcore watchdog

[marc.zyngier@arm.com (Marc Zyngier)]

On 24/04/12 11:35, Viresh Kumar wrote:
> On 4/24/2012 2:56 PM, Marc Zyngier wrote:
>> I'm sorry, but I really have to ask: What is the point of adding DT
>> support to this driver when it is obvious that it is already broken?
> 
> Interrupt is only for testing. And that's why it worked for me earlier,
> as i didn't passed irq from DT.
> 
> So, i believe this patch still makes sense. Obviously we can have another
> patch to get interrupts fixed.

That's exactly what I object to. You're giving a false sense of
usability ("see, this driver is maintained, it even has DT support!"),
while the damn thing has not worked for quite a long time. And I don't
mean only the interrupt. The driver is not working properly on an SMP
system.

At that point, and unless someone is willing to step up and fix it, I'd
rather make it depend on CONFIG_BROKEN.

	M.
-- 
Jazz is not dead. It just smells funny...