* [RFC] ARM: SAMSUNG: devs: Use common macro to define resources
@ 2012-04-24 9:03 Tushar Behera
2012-04-25 0:01 ` Kukjin Kim
0 siblings, 1 reply; 3+ messages in thread
From: Tushar Behera @ 2012-04-24 9:03 UTC (permalink / raw)
To: linux-arm-kernel
CC: Kukjin Kim <kgene.kim@samsung.com>
Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
---
I am not sure whether changes like this are accepted as independent patches,
as they are not changing the behaviour of the code at all.
I have a patchset doing similar clean up in various Samsung related arch files.
If changes like this are acceptable, I will post the complete patchset.
arch/arm/plat-samsung/devs.c | 12 ++----------
1 files changed, 2 insertions(+), 10 deletions(-)
diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c
index db32ec5..1013a34 100644
--- a/arch/arm/plat-samsung/devs.c
+++ b/arch/arm/plat-samsung/devs.c
@@ -272,16 +272,8 @@ struct platform_device s5p_device_fimc3 = {
#ifdef CONFIG_S5P_DEV_G2D
static struct resource s5p_g2d_resource[] = {
- [0] = {
- .start = S5P_PA_G2D,
- .end = S5P_PA_G2D + SZ_4K - 1,
- .flags = IORESOURCE_MEM,
- },
- [1] = {
- .start = IRQ_2D,
- .end = IRQ_2D,
- .flags = IORESOURCE_IRQ,
- },
+ [0] = DEFINE_RES_MEM(S5P_PA_G2D, SZ_4K),
+ [1] = DEFINE_RES_IRQ(IRQ_2D),
};
struct platform_device s5p_device_g2d = {
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [RFC] ARM: SAMSUNG: devs: Use common macro to define resources
2012-04-24 9:03 [RFC] ARM: SAMSUNG: devs: Use common macro to define resources Tushar Behera
@ 2012-04-25 0:01 ` Kukjin Kim
2012-04-25 4:14 ` Tushar Behera
0 siblings, 1 reply; 3+ messages in thread
From: Kukjin Kim @ 2012-04-25 0:01 UTC (permalink / raw)
To: linux-arm-kernel
Tushar Behera wrote:
> CC: Kukjin Kim<kgene.kim@samsung.com>
> Signed-off-by: Tushar Behera<tushar.behera@linaro.org>
> ---
> I am not sure whether changes like this are accepted as independent patches,
> as they are not changing the behaviour of the code at all.
>
Yeah, makes sense. will apply in my cleanup branch.
> I have a patchset doing similar clean up in various Samsung related arch files.
> If changes like this are acceptable, I will post the complete patchset.
>
OK.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
> arch/arm/plat-samsung/devs.c | 12 ++----------
> 1 files changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c
> index db32ec5..1013a34 100644
> --- a/arch/arm/plat-samsung/devs.c
> +++ b/arch/arm/plat-samsung/devs.c
> @@ -272,16 +272,8 @@ struct platform_device s5p_device_fimc3 = {
>
> #ifdef CONFIG_S5P_DEV_G2D
> static struct resource s5p_g2d_resource[] = {
> - [0] = {
> - .start = S5P_PA_G2D,
> - .end = S5P_PA_G2D + SZ_4K - 1,
> - .flags = IORESOURCE_MEM,
> - },
> - [1] = {
> - .start = IRQ_2D,
> - .end = IRQ_2D,
> - .flags = IORESOURCE_IRQ,
> - },
> + [0] = DEFINE_RES_MEM(S5P_PA_G2D, SZ_4K),
> + [1] = DEFINE_RES_IRQ(IRQ_2D),
> };
>
> struct platform_device s5p_device_g2d = {
^ permalink raw reply [flat|nested] 3+ messages in thread* [RFC] ARM: SAMSUNG: devs: Use common macro to define resources
2012-04-25 0:01 ` Kukjin Kim
@ 2012-04-25 4:14 ` Tushar Behera
0 siblings, 0 replies; 3+ messages in thread
From: Tushar Behera @ 2012-04-25 4:14 UTC (permalink / raw)
To: linux-arm-kernel
On 04/25/2012 05:31 AM, Kukjin Kim wrote:
> Tushar Behera wrote:
>> CC: Kukjin Kim<kgene.kim@samsung.com>
>> Signed-off-by: Tushar Behera<tushar.behera@linaro.org>
>> ---
>> I am not sure whether changes like this are accepted as independent patches,
>> as they are not changing the behaviour of the code at all.
>>
> Yeah, makes sense. will apply in my cleanup branch.
>
Thanks. I will post the complete patchset shortly.
>> I have a patchset doing similar clean up in various Samsung related arch files.
>> If changes like this are acceptable, I will post the complete patchset.
>>
> OK.
>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>
>> arch/arm/plat-samsung/devs.c | 12 ++----------
>> 1 files changed, 2 insertions(+), 10 deletions(-)
>>
>> diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c
>> index db32ec5..1013a34 100644
>> --- a/arch/arm/plat-samsung/devs.c
>> +++ b/arch/arm/plat-samsung/devs.c
>> @@ -272,16 +272,8 @@ struct platform_device s5p_device_fimc3 = {
>>
>> #ifdef CONFIG_S5P_DEV_G2D
>> static struct resource s5p_g2d_resource[] = {
>> - [0] = {
>> - .start = S5P_PA_G2D,
>> - .end = S5P_PA_G2D + SZ_4K - 1,
>> - .flags = IORESOURCE_MEM,
>> - },
>> - [1] = {
>> - .start = IRQ_2D,
>> - .end = IRQ_2D,
>> - .flags = IORESOURCE_IRQ,
>> - },
>> + [0] = DEFINE_RES_MEM(S5P_PA_G2D, SZ_4K),
>> + [1] = DEFINE_RES_IRQ(IRQ_2D),
>> };
>>
>> struct platform_device s5p_device_g2d = {
--
Tushar Behera
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-04-25 4:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-24 9:03 [RFC] ARM: SAMSUNG: devs: Use common macro to define resources Tushar Behera
2012-04-25 0:01 ` Kukjin Kim
2012-04-25 4:14 ` Tushar Behera
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).