linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: viresh.kumar@st.com (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V4] clk: add a fixed factor clock
Date: Mon, 7 May 2012 09:11:53 +0530	[thread overview]
Message-ID: <4FA74481.7010401@st.com> (raw)
In-Reply-To: <20120507014241.GA15248@gmail.com>

On 5/7/2012 7:12 AM, Mike Turquette wrote:
> I've applied the below fix in my local branch.  Let me know if you have
> issue with it before I send out my pull request to Arnd.
> 
> Thanks,
> Mike
> 
> 
> diff --git a/drivers/clk/clk-fixed-factor.c b/drivers/clk/clk-fixed-factor.c
> index 0e8782b..1f2da01 100644
> --- a/drivers/clk/clk-fixed-factor.c
> +++ b/drivers/clk/clk-fixed-factor.c
> @@ -88,10 +88,8 @@ struct clk *clk_register_fixed_factor(struct device *dev, const char *name,
>  
>  	clk = clk_register(dev, &fix->hw);
>  
> -	if (clk)
> -		return clk;
> +	if (IS_ERR(clk))
> +		kfree(fix);
>  
> -	kfree(fix);
> -
> -	return NULL;
> +	return clk;
>  }

No problems. Please send it to Arnd ASAP.

--
viresh

      reply	other threads:[~2012-05-07  3:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-03 10:06 [PATCH V4] clk: add a fixed factor clock Viresh Kumar
2012-05-03 12:08 ` Sascha Hauer
     [not found]   ` <CAOh2x=mF5MjG_TM0S7W+r8=eVXf3v9SBsaxADZYFTjtPKoRm4w@mail.gmail.com>
2012-05-04 22:08     ` Turquette, Mike
2012-05-07  1:42     ` Mike Turquette
2012-05-07  3:41       ` Viresh Kumar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FA74481.7010401@st.com \
    --to=viresh.kumar@st.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).