From: paul.liu@linaro.org (Ying-Chun Liu (PaulLiu))
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mfd: da9052: fix of_match_node() arguments
Date: Wed, 09 May 2012 01:00:12 +0800 [thread overview]
Message-ID: <4FA9511C.5060007@linaro.org> (raw)
In-Reply-To: <1336258968-6423-1-git-send-email-olof@lixom.net>
(2012?05?06? 07:02), Olof Johansson wrote:
> The driver calls of_match_node() with the arguments swapped.
>
> Signed-off-by: Olof Johansson <olof@lixom.net>
> ---
> drivers/mfd/da9052-i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/da9052-i2c.c b/drivers/mfd/da9052-i2c.c
> index d8abdb3..8410065 100644
> --- a/drivers/mfd/da9052-i2c.c
> +++ b/drivers/mfd/da9052-i2c.c
> @@ -104,7 +104,7 @@ static int __devinit da9052_i2c_probe(struct i2c_client *client,
> struct device_node *np = client->dev.of_node;
> const struct of_device_id *deviceid;
>
> - deviceid = of_match_node(np, dialog_dt_ids);
> + deviceid = of_match_node(dialog_dt_ids, np);
> id = (const struct i2c_device_id *)deviceid->data;
> }
> #endif
Tested-by: Ying-Chun Liu <paul.liu@linaro.org>
Sorry. I don't know how my code works and tested previously.
But your patch is definited correct.
next prev parent reply other threads:[~2012-05-08 17:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-05 23:02 [PATCH] mfd: da9052: fix of_match_node() arguments Olof Johansson
2012-05-08 17:00 ` Ying-Chun Liu (PaulLiu) [this message]
2012-05-09 14:10 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA9511C.5060007@linaro.org \
--to=paul.liu@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).