[PATCH] ARM: EXYNOS: Add platform resource definitions for FIMC-LITE

[PATCH] ARM: EXYNOS: Add platform resource definitions for FIMC-LITE

[Sylwester Nawrocki]

Add the gate clocks and register region address definition for
FIMC-LITE devices available in Exynos4x12 and Exynos5 SoCs.

Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
 arch/arm/mach-exynos/clock-exynos4212.c |   10 ++++++++++
 arch/arm/mach-exynos/include/mach/map.h |    3 +++
 2 files changed, 13 insertions(+)

diff --git a/arch/arm/mach-exynos/clock-exynos4212.c b/arch/arm/mach-exynos/clock-exynos4212.c
index 9882312..da397d2 100644
--- a/arch/arm/mach-exynos/clock-exynos4212.c
+++ b/arch/arm/mach-exynos/clock-exynos4212.c
@@ -92,6 +92,16 @@ static struct clk init_clocks_off[] = {
 		.devname	= SYSMMU_CLOCK_DEVNAME(isp, 9),
 		.enable		= exynos4212_clk_ip_isp1_ctrl,
 		.ctrlbit	= (1 << 4),
+	}, {
+		.name		= "flite",
+		.devname	= "exynos-fimc-lite.0",
+		.enable		= exynos4212_clk_ip_isp0_ctrl,
+		.ctrlbit	= (1 << 4),
+	}, {
+		.name		= "flite",
+		.devname	= "exynos-fimc-lite.1",
+		.enable		= exynos4212_clk_ip_isp0_ctrl,
+		.ctrlbit	= (1 << 3),
 	}
 };
 
diff --git a/arch/arm/mach-exynos/include/mach/map.h b/arch/arm/mach-exynos/include/mach/map.h
index 0e2292d..d30643b 100644
--- a/arch/arm/mach-exynos/include/mach/map.h
+++ b/arch/arm/mach-exynos/include/mach/map.h
@@ -34,6 +34,9 @@
 
 #define EXYNOS4_PA_JPEG			0x11840000
 
+/* x = 0...1 */
+#define EXYNOS4_PA_FIMC_LITE(x)		(0x12390000 + ((x) * 0x10000))
+
 #define EXYNOS4_PA_G2D			0x12800000
 
 #define EXYNOS4_PA_I2S0			0x03830000
-- 
1.7.10

[PATCH] ARM: EXYNOS: Add platform resource definitions for FIMC-LITE

[Kukjin Kim]

Sylwester Nawrocki wrote:
> 
> Add the gate clocks and register region address definition for
> FIMC-LITE devices available in Exynos4x12 and Exynos5 SoCs.
> 
This is right description? I can't find your changes for EXYNOS4412 and
EXYNOS5 here. Only this is for EXYNOS4212 SoC.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
>  arch/arm/mach-exynos/clock-exynos4212.c |   10 ++++++++++
>  arch/arm/mach-exynos/include/mach/map.h |    3 +++
>  2 files changed, 13 insertions(+)
> 
> diff --git a/arch/arm/mach-exynos/clock-exynos4212.c b/arch/arm/mach-
> exynos/clock-exynos4212.c
> index 9882312..da397d2 100644
> --- a/arch/arm/mach-exynos/clock-exynos4212.c
> +++ b/arch/arm/mach-exynos/clock-exynos4212.c
> @@ -92,6 +92,16 @@ static struct clk init_clocks_off[] = {
>  		.devname	= SYSMMU_CLOCK_DEVNAME(isp, 9),
>  		.enable		= exynos4212_clk_ip_isp1_ctrl,
>  		.ctrlbit	= (1 << 4),
> +	}, {
> +		.name		= "flite",
> +		.devname	= "exynos-fimc-lite.0",
> +		.enable		= exynos4212_clk_ip_isp0_ctrl,
> +		.ctrlbit	= (1 << 4),
> +	}, {
> +		.name		= "flite",
> +		.devname	= "exynos-fimc-lite.1",
> +		.enable		= exynos4212_clk_ip_isp0_ctrl,
> +		.ctrlbit	= (1 << 3),
>  	}
>  };
> 
> diff --git a/arch/arm/mach-exynos/include/mach/map.h b/arch/arm/mach-
> exynos/include/mach/map.h
> index 0e2292d..d30643b 100644
> --- a/arch/arm/mach-exynos/include/mach/map.h
> +++ b/arch/arm/mach-exynos/include/mach/map.h
> @@ -34,6 +34,9 @@
> 
>  #define EXYNOS4_PA_JPEG			0x11840000
> 
> +/* x = 0...1 */
> +#define EXYNOS4_PA_FIMC_LITE(x)		(0x12390000 + ((x) *
0x10000))
> +
>  #define EXYNOS4_PA_G2D			0x12800000
> 
>  #define EXYNOS4_PA_I2S0			0x03830000
> --
> 1.7.10

[PATCH] ARM: EXYNOS: Add platform resource definitions for FIMC-LITE

[Sylwester Nawrocki]

On 05/08/2012 07:42 AM, Kukjin Kim wrote:
> Sylwester Nawrocki wrote:
>>
>> Add the gate clocks and register region address definition for
>> FIMC-LITE devices available in Exynos4x12 and Exynos5 SoCs.
>>
> This is right description? I can't find your changes for EXYNOS4412 and
> EXYNOS5 here. Only this is for EXYNOS4212 SoC.

Sorry, I wasn't precise enough. EXYNOS4_PA_FIMC_LITE is for EXYNOS4212
and EXYNOS4412 though. Please note it is initially needed for DT platforms,
until we get proper clock DT bindings for EXYNOS. Is there, BTW, anyone 
known to work on converting EXYNOS to the common clock framework ?

This patch was intended for EXYNOS4212/4412. AFAICS clock code in
mach-exynos/clock-exynos4412.c is a subset of the EXYNOS4412 platform:

static void __init exynos4_init_clocks(int xtal)
{
	...
	if (soc_is_exynos4210())
		exynos4210_register_clocks();
	else if (soc_is_exynos4212() || soc_is_exynos4412())
		exynos4212_register_clocks();
	
	exynos4_register_clocks();
	...
}

Should I resend the patch or could you remove " and Exynos5 SoCs"
from the description ?

--

Regards,
Sylwester Nawrocki

[PATCH] ARM: EXYNOS: Add platform resource definitions for FIMC-LITE

[Sylwester Nawrocki]

On 05/08/2012 09:35 AM, Sylwester Nawrocki wrote:
> On 05/08/2012 07:42 AM, Kukjin Kim wrote:
>> Sylwester Nawrocki wrote:
>>>
>>> Add the gate clocks and register region address definition for
>>> FIMC-LITE devices available in Exynos4x12 and Exynos5 SoCs.
>>>
>> This is right description? I can't find your changes for EXYNOS4412 and
>> EXYNOS5 here. Only this is for EXYNOS4212 SoC.
> 
> Sorry, I wasn't precise enough. EXYNOS4_PA_FIMC_LITE is for EXYNOS4212
> and EXYNOS4412 though. Please note it is initially needed for DT platforms,
> until we get proper clock DT bindings for EXYNOS. Is there, BTW, anyone 
> known to work on converting EXYNOS to the common clock framework ?
> 
> This patch was intended for EXYNOS4212/4412. AFAICS clock code in
> mach-exynos/clock-exynos4412.c is a subset of the EXYNOS4412 platform:
              ^^^^^^^^^^^^^^^^^^
Uh, should be clock-exynos4212.c.

> static void __init exynos4_init_clocks(int xtal)
> {
> 	...
> 	if (soc_is_exynos4210())
> 		exynos4210_register_clocks();
> 	else if (soc_is_exynos4212() || soc_is_exynos4412())
> 		exynos4212_register_clocks();
> 	
> 	exynos4_register_clocks();
> 	...
> }
> 
> Should I resend the patch or could you remove " and Exynos5 SoCs"
> from the description ?
> 
> --
> 
> Regards,
> Sylwester Nawrocki

[PATCH] ARM: EXYNOS: Add platform resource definitions for FIMC-LITE

[Kukjin Kim]

Sylwester Nawrocki wrote:

> 
> On 05/08/2012 07:42 AM, Kukjin Kim wrote:
> > Sylwester Nawrocki wrote:
> >>
> >> Add the gate clocks and register region address definition for
> >> FIMC-LITE devices available in Exynos4x12 and Exynos5 SoCs.
> >>
> > This is right description? I can't find your changes for EXYNOS4412 and
> > EXYNOS5 here. Only this is for EXYNOS4212 SoC.
> 
> Sorry, I wasn't precise enough. EXYNOS4_PA_FIMC_LITE is for EXYNOS4212
> and EXYNOS4412 though. Please note it is initially needed for DT
platforms,
> until we get proper clock DT bindings for EXYNOS. Is there, BTW, anyone
> known to work on converting EXYNOS to the common clock framework ?
> 
Yes, my colleague is working on common clock for all of exynos stuff.

> This patch was intended for EXYNOS4212/4412. AFAICS clock code in
> mach-exynos/clock-exynos4412.c is a subset of the EXYNOS4412 platform:
> 
OK.

> static void __init exynos4_init_clocks(int xtal)
> {
> 	...
> 	if (soc_is_exynos4210())
> 		exynos4210_register_clocks();
> 	else if (soc_is_exynos4212() || soc_is_exynos4412())
> 		exynos4212_register_clocks();
> 
> 	exynos4_register_clocks();
> 	...
> }
> 
> Should I resend the patch or could you remove " and Exynos5 SoCs"
> from the description ?
> 
I see, let me fix it when I apply this.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

[PATCH] ARM: EXYNOS: Add platform resource definitions for FIMC-LITE

[Sylwester Nawrocki]

On 05/10/2012 11:56 AM, Kukjin Kim wrote:
>> Should I resend the patch or could you remove " and Exynos5 SoCs"
>> from the description ?
>>
> I see, let me fix it when I apply this.
> 
> Thanks.
> 

Alright, thanks a lot.

-- 
Sylwester Nawrocki
Samsung Poland R&D Center

[PATCH] ARM: EXYNOS: Add platform resource definitions for FIMC-LITE

[nop]

q