[PATCHv2 0/3] Add support for DRM display subsystem

[PATCHv2 0/3] Add support for DRM display subsystem

[Marek Szyprowski]

Hello,

This patch set adds support for Exynos DRM display subsystem for
Universal C210 and NURI boards. Exynos DRM driver has been merged to 3.3
kernel tree and provides unified and more powerful alternative for
s3c-fb and s5p-tv drivers. V2 includes update for the latest changes in
platform data structure (added 'panel' entry).

Best regards

Marek Szyprowski
Samsung Poland R&D Center

Patch summary:

Marek Szyprowski (3):
  ARM: Exynos: add platform device for core DRM subsystem
  ARM: Exynos: Add DRM core device support for Universal C210 board
  ARM: Exynos: Add DRM core support for NURI board

 arch/arm/mach-exynos/Kconfig               |    7 ++++++
 arch/arm/mach-exynos/Makefile              |    1 +
 arch/arm/mach-exynos/dev-drm.c             |   29 ++++++++++++++++++++++++
 arch/arm/mach-exynos/mach-nuri.c           |   33 ++++++++++++++++++++++++++++
 arch/arm/mach-exynos/mach-universal_c210.c |   33 ++++++++++++++++++++++++++++
 arch/arm/plat-samsung/include/plat/devs.h  |    2 +
 6 files changed, 105 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-exynos/dev-drm.c

-- 
1.7.1.569.g6f426

[PATCHv2 1/3] ARM: Exynos: add platform device for core DRM subsystem

[Marek Szyprowski]

Add platform device for Exynos DRM core. This device is used for
creating DRM user-space device and allocating memory for display buffers.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
 arch/arm/mach-exynos/Kconfig              |    5 +++++
 arch/arm/mach-exynos/Makefile             |    1 +
 arch/arm/mach-exynos/dev-drm.c            |   29 +++++++++++++++++++++++++++++
 arch/arm/plat-samsung/include/plat/devs.h |    2 ++
 4 files changed, 37 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-exynos/dev-drm.c

diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
index 060414e..9124ce9 100644
--- a/arch/arm/mach-exynos/Kconfig
+++ b/arch/arm/mach-exynos/Kconfig
@@ -85,6 +85,11 @@ config EXYNOS4_DEV_AHCI
 	help
 	  Compile in platform device definitions for AHCI
 
+config EXYNOS_DEV_DRM
+	bool
+	help
+	  Compile in platform device definitions for core DRM device
+
 config EXYNOS4_SETUP_FIMD0
 	bool
 	help
diff --git a/arch/arm/mach-exynos/Makefile b/arch/arm/mach-exynos/Makefile
index 8631840..f67e882 100644
--- a/arch/arm/mach-exynos/Makefile
+++ b/arch/arm/mach-exynos/Makefile
@@ -50,6 +50,7 @@ obj-$(CONFIG_MACH_EXYNOS5_DT)		+= mach-exynos5-dt.o
 obj-y					+= dev-uart.o
 obj-$(CONFIG_ARCH_EXYNOS4)		+= dev-audio.o
 obj-$(CONFIG_EXYNOS4_DEV_AHCI)		+= dev-ahci.o
+obj-$(CONFIG_EXYNOS_DEV_DRM)		+= dev-drm.o
 obj-$(CONFIG_EXYNOS4_DEV_SYSMMU)	+= dev-sysmmu.o
 obj-$(CONFIG_EXYNOS4_DEV_DWMCI)		+= dev-dwmci.o
 obj-$(CONFIG_EXYNOS4_DEV_DMA)		+= dma.o
diff --git a/arch/arm/mach-exynos/dev-drm.c b/arch/arm/mach-exynos/dev-drm.c
new file mode 100644
index 0000000..17c9c6e
--- /dev/null
+++ b/arch/arm/mach-exynos/dev-drm.c
@@ -0,0 +1,29 @@
+/*
+ * linux/arch/arm/mach-exynos/dev-drm.c
+ *
+ * Copyright (c) 2012 Samsung Electronics Co., Ltd.
+ *		http://www.samsung.com
+ *
+ * EXYNOS - core DRM device
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ */
+
+#include <linux/kernel.h>
+#include <linux/dma-mapping.h>
+#include <linux/platform_device.h>
+
+#include <plat/devs.h>
+
+static u64 exynos_drm_dma_mask = DMA_BIT_MASK(32);
+
+struct platform_device exynos_device_drm = {
+	.name	= "exynos-drm",
+	.dev	= {
+		.dma_mask		= &exynos_drm_dma_mask,
+		.coherent_dma_mask	= DMA_BIT_MASK(32),
+	}
+};
diff --git a/arch/arm/plat-samsung/include/plat/devs.h b/arch/arm/plat-samsung/include/plat/devs.h
index 2155d4a..62e6251 100644
--- a/arch/arm/plat-samsung/include/plat/devs.h
+++ b/arch/arm/plat-samsung/include/plat/devs.h
@@ -135,6 +135,8 @@ extern struct platform_device exynos4_device_pd[];
 extern struct platform_device exynos4_device_spdif;
 extern struct platform_device exynos4_device_sysmmu;
 
+extern struct platform_device exynos_device_drm;
+
 extern struct platform_device samsung_asoc_dma;
 extern struct platform_device samsung_asoc_idma;
 extern struct platform_device samsung_device_keypad;
-- 
1.7.1.569.g6f426

[PATCHv2 2/3] ARM: Exynos: Add DRM core device support for Universal C210 board

[Marek Szyprowski]

Add core DRM device and alternative platform device data for FIMD DRM
subdriver. Based on the initial patch by Joonyoung Shim
<jy0922.shim@samsung.com>

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
 arch/arm/mach-exynos/Kconfig               |    1 +
 arch/arm/mach-exynos/mach-universal_c210.c |   33 ++++++++++++++++++++++++++++
 2 files changed, 34 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
index 9124ce9..52cb248 100644
--- a/arch/arm/mach-exynos/Kconfig
+++ b/arch/arm/mach-exynos/Kconfig
@@ -262,6 +262,7 @@ config MACH_UNIVERSAL_C210
 	select S5P_DEV_ONENAND
 	select S5P_DEV_TV
 	select EXYNOS4_DEV_DMA
+	select EXYNOS_DEV_DRM
 	select EXYNOS4_SETUP_FIMD0
 	select EXYNOS4_SETUP_I2C1
 	select EXYNOS4_SETUP_I2C3
diff --git a/arch/arm/mach-exynos/mach-universal_c210.c b/arch/arm/mach-exynos/mach-universal_c210.c
index 57e4418..b8bd8ab 100644
--- a/arch/arm/mach-exynos/mach-universal_c210.c
+++ b/arch/arm/mach-exynos/mach-universal_c210.c
@@ -23,6 +23,7 @@
 #include <linux/i2c-gpio.h>
 #include <linux/i2c/mcs.h>
 #include <linux/i2c/atmel_mxt_ts.h>
+#include <drm/exynos_drm.h>
 
 #include <asm/mach/arch.h>
 #include <asm/hardware/gic.h>
@@ -811,6 +812,29 @@ static struct i2c_board_info i2c1_devs[] __initdata = {
 	/* Gyro, To be updated */
 };
 
+#ifdef CONFIG_DRM_EXYNOS
+static struct exynos_drm_fimd_pdata drm_fimd_pdata = {
+	.panel = {
+		.timing	= {
+			.left_margin	= 16,
+			.right_margin	= 16,
+			.upper_margin	= 2,
+			.lower_margin	= 28,
+			.hsync_len	= 2,
+			.vsync_len	= 1,
+			.xres		= 480,
+			.yres		= 800,
+			.refresh	= 55,
+		},
+	},
+	.vidcon0	= VIDCON0_VIDOUT_RGB | VIDCON0_PNRMODE_RGB |
+			  VIDCON0_CLKSEL_LCD,
+	.vidcon1	= VIDCON1_INV_VCLK | VIDCON1_INV_VDEN
+			  | VIDCON1_INV_HSYNC | VIDCON1_INV_VSYNC,
+	.default_win	= 3,
+	.bpp		= 32,
+};
+#else
 /* Frame Buffer */
 static struct s3c_fb_pd_win universal_fb_win0 = {
 	.win_mode = {
@@ -838,6 +862,7 @@ static struct s3c_fb_platdata universal_lcd_pdata __initdata = {
 			  | VIDCON1_INV_HSYNC | VIDCON1_INV_VSYNC,
 	.setup_gpio	= exynos4_fimd0_gpio_setup_24bpp,
 };
+#endif
 
 static struct regulator_consumer_supply cam_vt_dio_supply =
 	REGULATOR_SUPPLY("vdd_core", "0-003c");
@@ -1047,6 +1072,9 @@ static struct platform_device *universal_devices[] __initdata = {
 	&s5p_device_onenand,
 	&s5p_device_fimd0,
 	&s5p_device_jpeg,
+#ifdef CONFIG_DRM_EXYNOS
+	&exynos_device_drm,
+#endif
 	&s5p_device_mfc,
 	&s5p_device_mfc_l,
 	&s5p_device_mfc_r,
@@ -1092,7 +1120,12 @@ static void __init universal_machine_init(void)
 	s5p_i2c_hdmiphy_set_platdata(NULL);
 	i2c_register_board_info(5, i2c5_devs, ARRAY_SIZE(i2c5_devs));
 
+#ifdef CONFIG_DRM_EXYNOS
+	s5p_device_fimd0.dev.platform_data = &drm_fimd_pdata;
+	exynos4_fimd0_gpio_setup_24bpp();
+#else
 	s5p_fimd0_set_platdata(&universal_lcd_pdata);
+#endif
 
 	universal_touchkey_init();
 	i2c_register_board_info(I2C_GPIO_BUS_12, i2c_gpio12_devs,
-- 
1.7.1.569.g6f426

[PATCHv2 3/3] ARM: Exynos: Add DRM core support for NURI board

[Marek Szyprowski]

Add core DRM device and alternative platform device data for FIMD DRM
subdriver. Based on the initial patch by Joonyoung Shim
<jy0922.shim@samsung.com>

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
 arch/arm/mach-exynos/Kconfig     |    1 +
 arch/arm/mach-exynos/mach-nuri.c |   33 +++++++++++++++++++++++++++++++++
 2 files changed, 34 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
index 52cb248..db4b897 100644
--- a/arch/arm/mach-exynos/Kconfig
+++ b/arch/arm/mach-exynos/Kconfig
@@ -299,6 +299,7 @@ config MACH_NURI
 	select S5P_DEV_USB_EHCI
 	select S5P_SETUP_MIPIPHY
 	select EXYNOS4_DEV_DMA
+	select EXYNOS_DEV_DRM
 	select EXYNOS4_SETUP_FIMC
 	select EXYNOS4_SETUP_FIMD0
 	select EXYNOS4_SETUP_I2C1
diff --git a/arch/arm/mach-exynos/mach-nuri.c b/arch/arm/mach-exynos/mach-nuri.c
index 7ac81ce..8049f93 100644
--- a/arch/arm/mach-exynos/mach-nuri.c
+++ b/arch/arm/mach-exynos/mach-nuri.c
@@ -25,6 +25,7 @@
 #include <linux/mmc/host.h>
 #include <linux/fb.h>
 #include <linux/pwm_backlight.h>
+#include <drm/exynos_drm.h>
 
 #include <video/platform_lcd.h>
 #include <media/m5mols.h>
@@ -210,6 +211,29 @@ static struct platform_device nuri_gpio_keys = {
 	},
 };
 
+#ifdef CONFIG_DRM_EXYNOS
+static struct exynos_drm_fimd_pdata drm_fimd_pdata = {
+	.panel = {
+		.timing	= {
+			.xres		= 1024,
+			.yres		= 600,
+			.hsync_len	= 40,
+			.left_margin	= 79,
+			.right_margin	= 200,
+			.vsync_len	= 10,
+			.upper_margin	= 10,
+			.lower_margin	= 11,
+			.refresh	= 60,
+		},
+	},
+	.vidcon0	= VIDCON0_VIDOUT_RGB | VIDCON0_PNRMODE_RGB |
+			  VIDCON0_CLKSEL_LCD,
+	.vidcon1	= VIDCON1_INV_HSYNC | VIDCON1_INV_VSYNC,
+	.default_win	= 3,
+	.bpp		= 32,
+};
+
+#else
 /* Frame Buffer */
 static struct s3c_fb_pd_win nuri_fb_win0 = {
 	.win_mode = {
@@ -236,6 +260,7 @@ static struct s3c_fb_platdata nuri_fb_pdata __initdata = {
 	.vidcon1	= VIDCON1_INV_HSYNC | VIDCON1_INV_VSYNC,
 	.setup_gpio	= exynos4_fimd0_gpio_setup_24bpp,
 };
+#endif
 
 static void nuri_lcd_power_on(struct plat_lcd_data *pd, unsigned int power)
 {
@@ -1341,6 +1366,9 @@ static struct platform_device *nuri_devices[] __initdata = {
 	&cam_vdda_fixed_rdev,
 	&cam_8m_12v_fixed_rdev,
 	&exynos4_bus_devfreq,
+#ifdef CONFIG_DRM_EXYNOS
+	&exynos_device_drm,
+#endif
 };
 
 static void __init nuri_map_io(void)
@@ -1372,7 +1400,12 @@ static void __init nuri_machine_init(void)
 	i2c_register_board_info(9, i2c9_devs, ARRAY_SIZE(i2c9_devs));
 	s3c_i2c6_set_platdata(&nuri_i2c6_platdata);
 
+#ifdef CONFIG_DRM_EXYNOS
+	s5p_device_fimd0.dev.platform_data = &drm_fimd_pdata;
+	exynos4_fimd0_gpio_setup_24bpp();
+#else
 	s5p_fimd0_set_platdata(&nuri_fb_pdata);
+#endif
 
 	nuri_camera_init();
 
-- 
1.7.1.569.g6f426

[PATCHv2 0/3] Add support for DRM display subsystem

[Kukjin Kim]

Marek Szyprowski wrote:
> 
> Hello,
> 
> This patch set adds support for Exynos DRM display subsystem for
> Universal C210 and NURI boards. Exynos DRM driver has been merged to 3.3
> kernel tree and provides unified and more powerful alternative for
> s3c-fb and s5p-tv drivers. V2 includes update for the latest changes in
> platform data structure (added 'panel' entry).
> 
> Best regards
> 
> Marek Szyprowski
> Samsung Poland R&D Center
> 
> Patch summary:
> 
> Marek Szyprowski (3):
>   ARM: Exynos: add platform device for core DRM subsystem
>   ARM: Exynos: Add DRM core device support for Universal C210 board
>   ARM: Exynos: Add DRM core support for NURI board
> 
>  arch/arm/mach-exynos/Kconfig               |    7 ++++++
>  arch/arm/mach-exynos/Makefile              |    1 +
>  arch/arm/mach-exynos/dev-drm.c             |   29
++++++++++++++++++++++++
>  arch/arm/mach-exynos/mach-nuri.c           |   33
> ++++++++++++++++++++++++++++
>  arch/arm/mach-exynos/mach-universal_c210.c |   33
> ++++++++++++++++++++++++++++
>  arch/arm/plat-samsung/include/plat/devs.h  |    2 +
>  6 files changed, 105 insertions(+), 0 deletions(-)
>  create mode 100644 arch/arm/mach-exynos/dev-drm.c
> 
> --
> 1.7.1.569.g6f426

Well, 2nd and 3rd patches can break multi-platform for EXYNOS SoCs with one
kernel image.

And I won't apply new feature for non-dt board file from now on. I think, we
need to support DT in mach-exynos/ instead of non-DT and DT together, so
please consider to move on dt supporting for Samsung mobile boards.

Note that I have a plan to replace board files with DT supporting in
mach-exynos/ next time.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

[PATCHv2 0/3] Add support for DRM display subsystem

[Kyungmin Park]

On 5/10/12, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Marek Szyprowski wrote:
>>
>> Hello,
>>
>> This patch set adds support for Exynos DRM display subsystem for
>> Universal C210 and NURI boards. Exynos DRM driver has been merged to 3.3
>> kernel tree and provides unified and more powerful alternative for
>> s3c-fb and s5p-tv drivers. V2 includes update for the latest changes in
>> platform data structure (added 'panel' entry).
>>
>> Best regards
>>
>> Marek Szyprowski
>> Samsung Poland R&D Center
>>
>> Patch summary:
>>
>> Marek Szyprowski (3):
>>   ARM: Exynos: add platform device for core DRM subsystem
>>   ARM: Exynos: Add DRM core device support for Universal C210 board
>>   ARM: Exynos: Add DRM core support for NURI board
>>
>>  arch/arm/mach-exynos/Kconfig               |    7 ++++++
>>  arch/arm/mach-exynos/Makefile              |    1 +
>>  arch/arm/mach-exynos/dev-drm.c             |   29
> ++++++++++++++++++++++++
>>  arch/arm/mach-exynos/mach-nuri.c           |   33
>> ++++++++++++++++++++++++++++
>>  arch/arm/mach-exynos/mach-universal_c210.c |   33
>> ++++++++++++++++++++++++++++
>>  arch/arm/plat-samsung/include/plat/devs.h  |    2 +
>>  6 files changed, 105 insertions(+), 0 deletions(-)
>>  create mode 100644 arch/arm/mach-exynos/dev-drm.c
>>
>> --
>> 1.7.1.569.g6f426
>
> Well, 2nd and 3rd patches can break multi-platform for EXYNOS SoCs with one
> kernel image.
>
> And I won't apply new feature for non-dt board file from now on. I think,
> we
> need to support DT in mach-exynos/ instead of non-DT and DT together, so
> please consider to move on dt supporting for Samsung mobile boards.
>

Probably you misunderstand Arnd word.

"From the statements made so far, I can see no clear policy that we can
apply to everyone. My take on this is that for any work I spend on
multiplatform kernel, I concentrate on the DT-based board files and
get them to work together first, but leave it up to the individual
subarch maintainers whether they want to add other board files into
the mix."

It doesn't mean add new feature to non-DT board. don't add new board file.

In this case, DRM is not yet ready to support DT.

Okay, you can just drop this patches. but please note that this
patches are posted at Mar 13 before you decide.

BR,
Kyungmin Park

> Note that I have a plan to replace board files with DT supporting in
> mach-exynos/ next time.
>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc"
> in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

[PATCHv2 0/3] Add support for DRM display subsystem

[Arnd Bergmann]

On Thursday 10 May 2012, Kyungmin Park wrote:
> > And I won't apply new feature for non-dt board file from now on. I think,
> > we
> > need to support DT in mach-exynos/ instead of non-DT and DT together, so
> > please consider to move on dt supporting for Samsung mobile boards.
> >
> 
> Probably you misunderstand Arnd word.
> 
> "From the statements made so far, I can see no clear policy that we can
> apply to everyone. My take on this is that for any work I spend on
> multiplatform kernel, I concentrate on the DT-based board files and
> get them to work together first, but leave it up to the individual
> subarch maintainers whether they want to add other board files into
> the mix."
> 
> It doesn't mean add new feature to non-DT board. don't add new board file.

This is a completely separate discussion, the problem at hand doesn't
have anything to do with building a kernel for multiple mach-*
directories combined that I was referring to in the text you quote.

> In this case, DRM is not yet ready to support DT.
> 
> Okay, you can just drop this patches. but please note that this
> patches are posted at Mar 13 before you decide.

I think it's a good idea to make new features DT-only because this
way we don't get any regressions and everyone who want to use
the new feature will be able to test the DT support on his board.

This of course requires that basic DT support is available for the
systems in question so we don't regress when moving away from the
old board files. My impression is that we're getting close to that
point on exynos thanks to Thomas' work on this. AFAICT we don't
have a DT binding for screen timings yet, so you will still have
to use auxdata for that or put the timings into the driver.

	Arnd

[PATCHv2 0/3] Add support for DRM display subsystem

[Kyungmin Park]

On Thu, May 10, 2012 at 10:48 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Thursday 10 May 2012, Kyungmin Park wrote:
>> > And I won't apply new feature for non-dt board file from now on. I think,
>> > we
>> > need to support DT in mach-exynos/ instead of non-DT and DT together, so
>> > please consider to move on dt supporting for Samsung mobile boards.
>> >
>>
>> Probably you misunderstand Arnd word.
>>
>> "From the statements made so far, I can see no clear policy that we can
>> apply to everyone. My take on this is that for any work I spend on
>> multiplatform kernel, I concentrate on the DT-based board files and
>> get them to work together first, but leave it up to the individual
>> subarch maintainers whether they want to add other board files into
>> the mix."
>>
>> It doesn't mean add new feature to non-DT board. don't add new board file.
>
> This is a completely separate discussion, the problem at hand doesn't
> have anything to do with building a kernel for multiple mach-*
> directories combined that I was referring to in the text you quote.
>
>> In this case, DRM is not yet ready to support DT.
>>
>> Okay, you can just drop this patches. but please note that this
>> patches are posted at Mar 13 before you decide.
>
> I think it's a good idea to make new features DT-only because this
> way we don't get any regressions and everyone who want to use
> the new feature will be able to test the DT support on his board.
The 'new feature' is some misleading word. In this case DRM drivers
are used from v3.2 at drivers. but not registered it at board file.
Basically agree to move DT and used it finally. Before that bring up
the board using DRM based graphics.
>
> This of course requires that basic DT support is available for the
> systems in question so we don't regress when moving away from the
> old board files. My impression is that we're getting close to that
> point on exynos thanks to Thomas' work on this. AFAICT we don't
> have a DT binding for screen timings yet, so you will still have
> to use auxdata for that or put the timings into the driver.
I'm also thanks to Thomas, he did a lot of works for eyxnos. but most
parts are missing at least exynos platform.
e.g., Please see the origen.dts. I wonder it's booted with any
graphical user interface platform, android or ubuntu.
Maybe not.

Anyway, as discussed in multi-platform support mail threads, we're
also moving to DT in the big picture. but still want to use existing
boards as is.

Thank you,
Kyungmin Park

[PATCHv2 0/3] Add support for DRM display subsystem

[Sachin Kamat]

On 10 May 2012 20:16, Kyungmin Park <kmpark@infradead.org> wrote:
> On Thu, May 10, 2012 at 10:48 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>> On Thursday 10 May 2012, Kyungmin Park wrote:
>>> > And I won't apply new feature for non-dt board file from now on. I think,
>>> > we
>>> > need to support DT in mach-exynos/ instead of non-DT and DT together, so
>>> > please consider to move on dt supporting for Samsung mobile boards.
>>> >
>>>
>>> Probably you misunderstand Arnd word.
>>>
>>> "From the statements made so far, I can see no clear policy that we can
>>> apply to everyone. My take on this is that for any work I spend on
>>> multiplatform kernel, I concentrate on the DT-based board files and
>>> get them to work together first, but leave it up to the individual
>>> subarch maintainers whether they want to add other board files into
>>> the mix."
>>>
>>> It doesn't mean add new feature to non-DT board. don't add new board file.
>>
>> This is a completely separate discussion, the problem at hand doesn't
>> have anything to do with building a kernel for multiple mach-*
>> directories combined that I was referring to in the text you quote.
>>
>>> In this case, DRM is not yet ready to support DT.
>>>
>>> Okay, you can just drop this patches. but please note that this
>>> patches are posted at Mar 13 before you decide.
>>
>> I think it's a good idea to make new features DT-only because this
>> way we don't get any regressions and everyone who want to use
>> the new feature will be able to test the DT support on his board.
> The 'new feature' is some misleading word. In this case DRM drivers
> are used from v3.2 at drivers. but not registered it at board file.
> Basically agree to move DT and used it finally. Before that bring up
> the board using DRM based graphics.
>>
>> This of course requires that basic DT support is available for the
>> systems in question so we don't regress when moving away from the
>> old board files. My impression is that we're getting close to that
>> point on exynos thanks to Thomas' work on this. AFAICT we don't
>> have a DT binding for screen timings yet, so you will still have
>> to use auxdata for that or put the timings into the driver.
> I'm also thanks to Thomas, he did a lot of works for eyxnos. but most
> parts are missing at least exynos platform.
> e.g., Please see the origen.dts. I wonder it's booted with any
> graphical user interface platform, android or ubuntu.
> Maybe not.

We (Samsung Landing team) did manage to boot Origen with Ubuntu using
DT support. But that is only upto home screen with minimal support.

>
> Anyway, as discussed in multi-platform support mail threads, we're
> also moving to DT in the big picture. but still want to use existing
> boards as is.

For Exynos multimedia IPs, for instance, which already have drivers as
well as platform support in mainline, do we still defer device
registration in machine file until DT support for these IPs is added?

>
> Thank you,
> Kyungmin Park
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at ?http://vger.kernel.org/majordomo-info.html



-- 
With warm regards,
Sachin

[PATCHv2 0/3] Add support for DRM display subsystem

[Kukjin Kim]

OK, I thought again and talked to some guys. It's okay to add updated to the
non-dt board files on exynos4 for now. I know, until there is dt coverage
for more drivers, actually it will be difficult to build/support a complete
system with only dt support.

Note, we need to keep adding more and more support for dt for exynos4 and
exynos5. Then only we can stop the development of non-dt board files.

Thanks for many opinions about this and if any objections, feel free to
contact me.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

[PATCHv2 0/3] Add support for DRM display subsystem

[Marek Szyprowski]

Hello,

On Thursday, May 10, 2012 11:36 AM Kukjin Kim wrote:

> Marek Szyprowski wrote:
> >
> > Hello,
> >
> > This patch set adds support for Exynos DRM display subsystem for
> > Universal C210 and NURI boards. Exynos DRM driver has been merged to 3.3
> > kernel tree and provides unified and more powerful alternative for
> > s3c-fb and s5p-tv drivers. V2 includes update for the latest changes in
> > platform data structure (added 'panel' entry).
> >
> > Best regards
> >
> > Marek Szyprowski
> > Samsung Poland R&D Center
> >
> > Patch summary:
> >
> > Marek Szyprowski (3):
> >   ARM: Exynos: add platform device for core DRM subsystem
> >   ARM: Exynos: Add DRM core device support for Universal C210 board
> >   ARM: Exynos: Add DRM core support for NURI board
> >
> >  arch/arm/mach-exynos/Kconfig               |    7 ++++++
> >  arch/arm/mach-exynos/Makefile              |    1 +
> >  arch/arm/mach-exynos/dev-drm.c             |   29
> ++++++++++++++++++++++++
> >  arch/arm/mach-exynos/mach-nuri.c           |   33
> > ++++++++++++++++++++++++++++
> >  arch/arm/mach-exynos/mach-universal_c210.c |   33
> > ++++++++++++++++++++++++++++
> >  arch/arm/plat-samsung/include/plat/devs.h  |    2 +
> >  6 files changed, 105 insertions(+), 0 deletions(-)
> >  create mode 100644 arch/arm/mach-exynos/dev-drm.c
> >
> > --
> > 1.7.1.569.g6f426
> 
> Well, 2nd and 3rd patches can break multi-platform for EXYNOS SoCs with one
> kernel image.

We can switch completely to DRM driver for both boards and remove entries for 
s3c-fb/tv if this is really needed. IMHO it is a bit lame that the DRM driver
is already in the mainline, but none of the boards use it. Even if one wants
to add support for it to his own board, he cannot find any reference code for
it...

> And I won't apply new feature for non-dt board file from now on. I think, we
> need to support DT in mach-exynos/ instead of non-DT and DT together, so
> please consider to move on dt supporting for Samsung mobile boards.
> 
> Note that I have a plan to replace board files with DT supporting in
> mach-exynos/ next time.

Right now the DT support is so incomplete that even basic things like gpio 
interrupts are not yet supported. This will be a huge regression if you remove
the existing board files and replace them with DT stubs.
 
Best regards
-- 
Marek Szyprowski
Samsung Poland R&D Center

[PATCHv2 0/3] Add support for DRM display subsystem

[Sylwester Nawrocki]

On 05/10/2012 11:36 AM, Kukjin Kim wrote:
> Note that I have a plan to replace board files with DT supporting in
> mach-exynos/ next time.

What is the purpose of one side decisions like this ? I find it really
annoying. We have been building those board files through multiple kernel 
releases, it took much effort and time to create proper drivers and 
extending frameworks, like video or media.

It is going to take some more effort to make those subsystems DT aware and
add proper support at the drivers. This is being worked on and touching 
existing boards doesn't sound like an incentive to me. We have to deal 
with multiple boards and breaking existing ones which are almost completed
just adds an effort for us of maintaining them internally. The mainline 
kernel is going to always be a half-product, not properly tested and 
validated.

We get new boards that need to be supported in the kernel quite frequently,
those boards share device IPs, so adapting the drivers to the DT is
already our goal, for getting new boards supported in the mainline.

I have no idea what that "replacing" is going to be about, but if you add
support for all devices present in those boards and they will all work
as before - I'll happily accept that. Although I'm afraid it is just going
to be one big breakage and regression, in the name of "everything must
migrate to the device tree".

I would really appreciate more common agreement, rather than putting 
a spoke in somebody else's wheel.

Once all devices in current mach-exynos board files get proper DT support
we are going to remove the boards ourselves. I'm sure there is lots of 
other things that need more attention than that.

--
Regards,
Sylwester

[PATCHv2 0/3] Add support for DRM display subsystem

[Kukjin Kim]

On 03/13/12 19:39, Marek Szyprowski wrote:
> Hello,
>
> This patch set adds support for Exynos DRM display subsystem for
> Universal C210 and NURI boards. Exynos DRM driver has been merged to 3.3
> kernel tree and provides unified and more powerful alternative for
> s3c-fb and s5p-tv drivers. V2 includes update for the latest changes in
> platform data structure (added 'panel' entry).
>
> Best regards
>
> Marek Szyprowski
> Samsung Poland R&D Center
>
> Patch summary:
>
> Marek Szyprowski (3):
>    ARM: Exynos: add platform device for core DRM subsystem
>    ARM: Exynos: Add DRM core device support for Universal C210 board
>    ARM: Exynos: Add DRM core support for NURI board
>
>   arch/arm/mach-exynos/Kconfig               |    7 ++++++
>   arch/arm/mach-exynos/Makefile              |    1 +
>   arch/arm/mach-exynos/dev-drm.c             |   29 ++++++++++++++++++++++++
>   arch/arm/mach-exynos/mach-nuri.c           |   33 ++++++++++++++++++++++++++++
>   arch/arm/mach-exynos/mach-universal_c210.c |   33 ++++++++++++++++++++++++++++
>   arch/arm/plat-samsung/include/plat/devs.h  |    2 +
>   6 files changed, 105 insertions(+), 0 deletions(-)
>   create mode 100644 arch/arm/mach-exynos/dev-drm.c
>
Applied.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.