linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: tegra: Fix flow controller accesses
@ 2012-05-14 10:27 Peter De Schrijver
  2012-05-14 16:26 ` Stephen Warren
  0 siblings, 1 reply; 2+ messages in thread
From: Peter De Schrijver @ 2012-05-14 10:27 UTC (permalink / raw)
  To: linux-arm-kernel

flowctrl_write_cpu_csr uses the cpu halt offsets and vice versa. This patch
fixes this bug.

Reported-by: Dan Willemsen <dwillemsen@nvidia.com>
Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
---
 arch/arm/mach-tegra/flowctrl.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-tegra/flowctrl.c b/arch/arm/mach-tegra/flowctrl.c
index fef66a7..f07488e 100644
--- a/arch/arm/mach-tegra/flowctrl.c
+++ b/arch/arm/mach-tegra/flowctrl.c
@@ -53,10 +53,10 @@ static void flowctrl_update(u8 offset, u32 value)
 
 void flowctrl_write_cpu_csr(unsigned int cpuid, u32 value)
 {
-	return flowctrl_update(flowctrl_offset_halt_cpu[cpuid], value);
+	return flowctrl_update(flowctrl_offset_cpu_csr[cpuid], value);
 }
 
 void flowctrl_write_cpu_halt(unsigned int cpuid, u32 value)
 {
-	return flowctrl_update(flowctrl_offset_cpu_csr[cpuid], value);
+	return flowctrl_update(flowctrl_offset_halt_cpu[cpuid], value);
 }
-- 
1.7.7.rc0.72.g4b5ea.dirty

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] ARM: tegra: Fix flow controller accesses
  2012-05-14 10:27 [PATCH] ARM: tegra: Fix flow controller accesses Peter De Schrijver
@ 2012-05-14 16:26 ` Stephen Warren
  0 siblings, 0 replies; 2+ messages in thread
From: Stephen Warren @ 2012-05-14 16:26 UTC (permalink / raw)
  To: linux-arm-kernel

On 05/14/2012 04:27 AM, Peter De Schrijver wrote:
> flowctrl_write_cpu_csr uses the cpu halt offsets and vice versa. This patch
> fixes this bug.
> 
> Reported-by: Dan Willemsen <dwillemsen@nvidia.com>
> Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>

Applied, thanks.

I fixed the patch description to mention when this problem was introduced.

I'll send a pull request to include this in 3.4-final in a second.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-05-14 16:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-14 10:27 [PATCH] ARM: tegra: Fix flow controller accesses Peter De Schrijver
2012-05-14 16:26 ` Stephen Warren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).