From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Mon, 21 May 2012 08:52:26 +0100 Subject: [PATCH 06/18] mfd: ab8500: Remove confusing ab8500-i2c file and merge into ab8500-core In-Reply-To: References: <1337262323-27692-1-git-send-email-lee.jones@linaro.org> <1337262323-27692-7-git-send-email-lee.jones@linaro.org> Message-ID: <4FB9F43A.1040300@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 20/05/12 21:58, Linus Walleij wrote: > On Thu, May 17, 2012 at 3:45 PM, Lee Jones wrote: > >> ab8500-i2c is used as core code to register the ab8500 device. >> After allocating ab8500 memory, it immediately calls into >> ab8500-core where the real initialisation takes place. This >> patch moves all core registration and memory allocation into >> the true ab8500-core file and removes ab8500-i2c completely. >> >> Signed-off-by: Lee Jones >> --- > (...) >> +static int ab8500_i2c_write(struct ab8500 *ab8500, u16 addr, u8 data) > > So what happened to the promised (optional as add-on) patch also > renaming these functions to ab8500_prcmu_write() etc? > > The reason I insist on not ACK:in on a "promise to fix later, really > sure"-basis is exactly that these things tends to be forgotten ;-) I have not forgotten. It's the 2nd and 3rd entry on my TODO list: - TODO - Clean-up (simplify) ab8500-core - Change i2c_[read|write] to prcmu_[read|write] - COMMENTS in [PATCH 06/15] Everything on my TODO gets done. :) -- Lee Jones Linaro ST-Ericsson Landing Team Lead M: +44 77 88 633 515 Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog