linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] RFC: ARM: cache-l2x0: update workaround for PL310 errata 727915
Date: Tue, 22 May 2012 14:52:48 +0530	[thread overview]
Message-ID: <4FBB5AE8.4000801@ti.com> (raw)
In-Reply-To: <20120522085256.GA7286@mudshark.cambridge.arm.com>

On Tuesday 22 May 2012 02:22 PM, Will Deacon wrote:
> Hi Santosh,
> 
> On Mon, May 21, 2012 at 07:04:21AM +0100, Shilimkar, Santosh wrote:
>> On Mon, May 21, 2012 at 2:11 AM, Linus Walleij
>> <linus.walleij@stericsson.com> wrote:
>>> From: Colin Cross <ccross@android.com>
>>>
>>> ARM errata 727915 for PL310 has been updated to include a new
>>> workaround required for PL310 r2p0 for l2x0_flush_all, which also
>>> affects l2x0_clean_all in my testing. For r2p0, clean or flush
>>> each set/way individually. For r3p0 or greater, use the debug
>>> register for cleaning and flushing.
>>>
>>> Requires exporting the cache_id, sets and ways detected in the
>>> init function for later use.
>>>
>>> Cc: Will Deacon <will.deacon@arm.com>
>>> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
>>> Cc: Per Fransson <per.fransson.ml@gmail.com>
>>> Signed-off-by: Colin Cross <ccross@android.com>
>>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>>> ---
>>> I found this thing in the Android tree, it looks like it could
>>> be pretty serious so I'm mailing it out. If it is correct I
>>> guess it should even be tagged for -stable?
>>>
>>> v2: what about actually git commit --amend in the rebase changes
>>> for -rc7? Sorry for the screwup...
>>> ---
>> This was observed on OMAP4460 devices. Though the errata
>> document doesn't support it, the issue seen with l2 clean was
>> indeed fixed $subject fix.
> 
> I'm not sure I follow. Which version of the PL310 is in OMAP4460? Are you
> saying that the current workaround didn't work but the one in this patch
> did? Do you have a testcase?
> 
It's r3p1.
IIRC, the errata fix I did(debug register) was only for flush
(clean & inv) but Colin found in his testing that it's needed
for clean_all as well.

I don't have testcase. Colin might be able to suggest one.

Regards
santosh

  reply	other threads:[~2012-05-22  9:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-20 20:41 [PATCH v2] RFC: ARM: cache-l2x0: update workaround for PL310 errata 727915 Linus Walleij
2012-05-21  6:04 ` Shilimkar, Santosh
2012-05-21  9:20   ` Linus Walleij
2012-05-21  9:23     ` Santosh Shilimkar
2012-05-22  8:52   ` Will Deacon
2012-05-22  9:22     ` Santosh Shilimkar [this message]
2012-05-22  9:34       ` Will Deacon
2012-05-22 18:36         ` Colin Cross
2012-05-25 14:56           ` Will Deacon
2012-05-25 20:04             ` Colin Cross
2012-05-28 10:11               ` Will Deacon
2012-05-28 10:17                 ` Shilimkar, Santosh
2012-05-28 16:37                 ` Colin Cross
2012-05-22  9:21 ` Will Deacon
2012-05-22  9:25   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FBB5AE8.4000801@ti.com \
    --to=santosh.shilimkar@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).