public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: perf_event_v7.c compilation failure in next-20120523
Date: Wed, 23 May 2012 11:00:06 -0600	[thread overview]
Message-ID: <4FBD1796.4030309@wwwdotorg.org> (raw)

Will,

In next-20120523, the following two commits of yours collided:

d33c88c ARM: 7315/1: perf: add support for the Cortex-A7 PMU
(adds new entry to perf_event_v7.c)

b3426c5 ARM: perf: remove arm_perf_pmu_ids global enumeration
(removes a field from entries in perf_event_v7.c)

This causes:

> In file included from arch/arm/kernel/perf_event.c:610:0:
> arch/arm/kernel/perf_event_v7.c: In function 'armv7_a7_pmu_init':
> arch/arm/kernel/perf_event_v7.c:1294:10: error: 'struct arm_pmu' has no member named 'id'
> arch/arm/kernel/perf_event_v7.c:1294:17: error: 'ARM_PERF_PMU_ID_CA7' undeclared (first use in this function)

The following fixes the compilation error, although I put no thought
into whether it actually works at run-time:

> diff --git a/arch/arm/kernel/perf_event_v7.c b/arch/arm/kernel/perf_event_v7.c
> index 46228f0..f04070b 100644
> --- a/arch/arm/kernel/perf_event_v7.c
> +++ b/arch/arm/kernel/perf_event_v7.c
> @@ -1291,7 +1291,6 @@ static struct arm_pmu *__init armv7_a15_pmu_init(void)
>  
>  static struct arm_pmu *__init armv7_a7_pmu_init(void)
>  {
> -	armv7pmu.id		= ARM_PERF_PMU_ID_CA7;
>  	armv7pmu.name		= "ARMv7 Cortex-A7";
>  	armv7pmu.map_event	= armv7_a7_map_event;
>  	armv7pmu.num_events	= armv7_read_num_pmnc_events();

             reply	other threads:[~2012-05-23 17:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-23 17:00 Stephen Warren [this message]
2012-05-23 17:05 ` perf_event_v7.c compilation failure in next-20120523 Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FBD1796.4030309@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox