From: jon-hunter@ti.com (Jon Hunter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] arm/dts: add wdt node for omap3 and omap4
Date: Tue, 29 May 2012 12:52:13 -0500 [thread overview]
Message-ID: <4FC50CCD.7090404@ti.com> (raw)
In-Reply-To: <1337942552-28218-2-git-send-email-jgq516@gmail.com>
On 05/25/2012 05:42 AM, jgq516 at gmail.com wrote:
> From: Xiao Jiang <jgq516@gmail.com>
>
> Add wdt node to support dt.
>
> Signed-off-by: Xiao Jiang <jgq516@gmail.com>
> ---
> arch/arm/boot/dts/omap3.dtsi | 5 +++++
> arch/arm/boot/dts/omap4.dtsi | 5 +++++
> 2 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi
> index 99474fa..039df5c 100644
> --- a/arch/arm/boot/dts/omap3.dtsi
> +++ b/arch/arm/boot/dts/omap3.dtsi
> @@ -215,5 +215,10 @@
> compatible = "ti,omap3-hsmmc";
> ti,hwmods = "mmc3";
> };
> +
> + wdt: wdt at 48314000{
Minor comment, may be call this wdt2 as this is watchdog timer 2. Also
ass a space between the address and the "{".
> + compatible = "ti,omap3-wdt";
> + ti,hwmods = "wd_timer2";
> + };
> };
> };
> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
> index 359c497..d01403d 100644
> --- a/arch/arm/boot/dts/omap4.dtsi
> +++ b/arch/arm/boot/dts/omap4.dtsi
> @@ -272,5 +272,10 @@
> ti,hwmods = "mmc5";
> ti,needs-special-reset;
> };
> +
> + wdt: wdt at 4a314000{
Same as above.
> + compatible = "ti,omap4-wdt";
> + ti,hwmods = "wd_timer2";
> + };
> };
> };
Also we should add some documentation to describe the binding. Here it
is very simple, but nonetheless we should have something as we have for
gpio [1].
Cheers
Jon
[1]
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/devicetree/bindings/gpio/gpio-omap.txt;h=bff51a2fee1eae7d387b40ea913e04782554bf68;hb=HEAD
next prev parent reply other threads:[~2012-05-29 17:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-25 10:42 [PATCH 0/3] omap3/omap4: add device tree support for wdt jgq516 at gmail.com
2012-05-25 10:42 ` [PATCH 1/3] arm/dts: add wdt node for omap3 and omap4 jgq516 at gmail.com
2012-05-29 17:52 ` Jon Hunter [this message]
2012-05-30 3:19 ` Xiao Jiang
2012-05-30 14:42 ` Jon Hunter
2012-05-31 5:51 ` Xiao Jiang
2012-05-31 14:55 ` Jon Hunter
2012-05-31 20:59 ` Cousson, Benoit
2012-05-25 10:42 ` [PATCH 2/3] OMAP: avoid build wdt platform device if with dt support jgq516 at gmail.com
2012-05-29 17:53 ` Jon Hunter
2012-05-25 10:42 ` [PATCH 3/3] watchdog: omap_wdt: add device tree support jgq516 at gmail.com
2012-05-29 18:06 ` Jon Hunter
2012-05-30 3:18 ` Xiao Jiang
2012-05-30 7:54 ` Cousson, Benoit
2012-05-30 10:14 ` Xiao Jiang
2012-05-30 10:31 ` Xiao Jiang
2012-05-30 15:03 ` Jon Hunter
2012-05-30 15:30 ` Cousson, Benoit
2012-05-30 16:12 ` Jon Hunter
2012-05-29 17:47 ` [PATCH 0/3] omap3/omap4: add device tree support for wdt Jon Hunter
2012-05-30 10:14 ` Xiao Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC50CCD.7090404@ti.com \
--to=jon-hunter@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).