From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 08/22] regulator: Change ab8500 match names to reflect Device Tree
Date: Wed, 30 May 2012 23:01:06 +0800 [thread overview]
Message-ID: <4FC63632.4030504@linaro.org> (raw)
In-Reply-To: <20120530121547.GJ9947@opensource.wolfsonmicro.com>
On 30/05/12 20:15, Mark Brown wrote:
> On Wed, May 30, 2012 at 07:40:49PM +0800, Lee Jones wrote:
>> On May 30, 2012 6:03 PM, "Mark Brown"<broonie@opensource.wolfsonmicro.com>
>
>>> If we are changing the names then not including the ab8500 bit would
>>> seem more idiomatic - we've already worked out which chip this is by the
>>> time we're looking here.
>
>> No, Linus had the wrong end of the stick. I've just spoken to him in person.
>
>> Those are not the names of the regulators. They're the names of the Device
>> Tree nodes. The regulator names shall remain the same.
>
> Fair enough. My point about the ab8500_ bit still stands though.
It's a Device Tree thing. I do it so we can easily see which regulator
is driving which device(s).
I personally think:
vin-supply = <&db8500_vape_reg>;
vmmc-supply = <&ab8500_ldo_aux2_reg>;
Tells us so much more and is simpler to decrypt at a glance than
something like:
vin-supply = <&vape_reg>;
vmmc-supply = <&ldo_aux2_reg>;
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
M: +44 77 88 633 515
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2012-05-30 15:01 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-30 4:47 [PATCH 01/22] Fixes and clean-ups for Device Tree on Snowball Lee Jones
2012-05-30 4:47 ` [PATCH 01/22] ARM: ux500: New DT:ed snowball_platform_devs for one-by-one device enablement Lee Jones
2012-05-30 4:47 ` [PATCH 02/22] ARM: ux500: New DT:ed u8500_init_devices " Lee Jones
2012-05-30 4:47 ` [PATCH 03/22] ARM: ux500: Disable SMSC911x platform code registration when DT is enabled Lee Jones
2012-05-30 4:47 ` [PATCH 04/22] ARM: ux500: Remove DB8500 PRCMU platform " Lee Jones
2012-05-30 6:48 ` Linus Walleij
2012-05-30 4:47 ` [PATCH 05/22] ARM: ux500: PRCMU related configuration and layout corrections for Device Tree Lee Jones
2012-05-30 4:47 ` [PATCH 06/22] ARM: ux500: Re-enable SMSC911x platform code registration during non-DT boots Lee Jones
2012-05-30 4:47 ` [PATCH 07/22] ARM: ux500: Use correct format for dynamic IRQ assignment Lee Jones
2012-05-30 4:47 ` [PATCH 08/22] regulator: Change ab8500 match names to reflect Device Tree Lee Jones
2012-05-30 6:58 ` Linus Walleij
2012-05-30 10:03 ` Mark Brown
2012-05-30 11:40 ` Lee Jones
2012-05-30 12:15 ` Mark Brown
2012-05-30 15:01 ` Lee Jones [this message]
2012-05-30 15:11 ` Mark Brown
2012-05-30 15:22 ` Lee Jones
2012-05-30 16:41 ` Mark Brown
2012-05-31 0:42 ` Lee Jones
2012-06-01 4:36 ` Lee Jones
2012-06-01 8:48 ` Mark Brown
2012-06-05 10:31 ` Lee Jones
2012-06-05 10:38 ` Mark Brown
2012-06-11 10:27 ` Lee Jones
2012-06-11 10:36 ` Mark Brown
2012-06-11 11:28 ` Lee Jones
2012-06-11 11:42 ` Mark Brown
2012-05-31 1:40 ` Linus Walleij
2012-06-01 14:32 ` Mark Brown
2012-05-30 4:47 ` [PATCH 09/22] regulator: Change db8500-prcmu " Lee Jones
2012-05-30 7:00 ` Linus Walleij
2012-06-05 10:24 ` Lee Jones
2012-06-05 10:29 ` Mark Brown
2012-06-05 10:34 ` Lee Jones
2012-06-05 10:42 ` Mark Brown
2012-06-06 8:17 ` Lee Jones
2012-06-11 11:21 ` Lee Jones
2012-06-11 12:08 ` Mark Brown
2012-06-11 13:34 ` Lee Jones
2012-06-11 14:07 ` Lee Jones
2012-06-11 14:27 ` Mark Brown
2012-06-11 14:50 ` Lee Jones
2012-06-11 15:15 ` Mark Brown
2012-06-11 15:18 ` Lee Jones
2012-06-11 15:39 ` Mark Brown
2012-06-11 15:59 ` Lee Jones
2012-06-11 16:09 ` Mark Brown
2012-05-30 4:47 ` [PATCH 10/22] ARM: ux500: Disable platform setup of the ab8500 when DT is enabled Lee Jones
2012-05-30 4:47 ` [PATCH 11/22] ARM: ux500: Only initialise STE's UIBs on boards which support them Lee Jones
2012-05-30 4:47 ` [PATCH 12/22] ARM: ux500: Apply db8500-prcmu regulator information to db8500 Device Tree Lee Jones
2012-05-30 4:47 ` [PATCH 13/22] ARM: ux500: Allow PRCMU regulator to be probed during a DT enabled boot Lee Jones
2012-05-30 4:47 ` [PATCH 14/22] ARM: ux500: Provide regulator support for SMSC911x via Device Tree Lee Jones
2012-05-30 7:05 ` Linus Walleij
2012-05-30 4:47 ` [PATCH 15/22] ARM: ux500: Add support for ab8500 regulators into the " Lee Jones
2012-05-30 4:47 ` [PATCH 16/22] mfd: ab8500-gpadc: Enable IRQF_ONESHOT when requesting a threaded IRQ Lee Jones
2012-05-30 7:10 ` Linus Walleij
2012-06-29 13:21 ` Samuel Ortiz
2012-05-30 4:47 ` [PATCH 17/22] rtc: ab8500-rtc: " Lee Jones
2012-05-30 7:11 ` [rtc-linux] " Linus Walleij
2012-05-30 4:47 ` [PATCH 18/22] mfd: Remove redundant Kconfig entry Lee Jones
2012-05-30 7:15 ` Linus Walleij
2012-05-30 7:37 ` Lee Jones
2012-05-30 7:43 ` Linus Walleij
2012-06-29 13:24 ` Samuel Ortiz
2012-05-30 4:47 ` [PATCH 19/22] net/smsc911x: Repair broken failure paths Lee Jones
2012-05-30 7:16 ` Linus Walleij
2012-05-30 21:52 ` David Miller
2012-05-30 4:47 ` [PATCH 20/22] pinctrl-nomadik: Allow Device Tree driver probing Lee Jones
2012-05-30 7:18 ` Linus Walleij
2012-05-30 4:47 ` [PATCH 21/22] ARM: ux500: Enable probing of pinctrl through Device Tree Lee Jones
2012-05-30 7:18 ` Linus Walleij
2012-05-30 4:47 ` [PATCH 22/22] mfd: Enable DT probing of the DB8500 PRCMU Lee Jones
2012-05-30 7:19 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC63632.4030504@linaro.org \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).