From: stigge@antcom.de (Roland Stigge)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ohci-nxp: Use ohci_finish_controller_resume()
Date: Mon, 04 Jun 2012 17:02:28 +0200 [thread overview]
Message-ID: <4FCCCE04.3000904@antcom.de> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1206041027420.1555-100000@iolanthe.rowland.org>
Hi!
On 06/04/2012 04:29 PM, Alan Stern wrote:
>> OHCI drivers are supposed to use ohci_finish_controller_resume(). This patch
>> adds respective suspend and resume code to ohci-nxp. The following compiler
>> warning is fixed this way:
>>
>> drivers/usb/host/ohci-hub.c:321: warning: 'ohci_finish_controller_resume'
>> defined but not used
>
> This is not a correct description of the patch. A correct description
> would be something like:
>
> Add suspend/resume support to the ohci-nxp driver.
>
> The compiler warning needs a completely different fix;
> ohci_finish_controller_resume should be given a __maybe_unused
> annotation.
Thanks for the suggestion! I'll rather do the latter.
Roland
next prev parent reply other threads:[~2012-06-04 15:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-03 18:24 [PATCH] ohci-nxp: Use ohci_finish_controller_resume() Roland Stigge
2012-06-04 14:29 ` Alan Stern
2012-06-04 15:02 ` Roland Stigge [this message]
2012-06-04 14:54 ` ABRAHAM, KISHON VIJAY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCCCE04.3000904@antcom.de \
--to=stigge@antcom.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox