linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: simon2012@baatz.info (Simon Baatz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Kirkwood: Fix crash when neither NAND nor SPI
Date: Sun, 10 Jun 2012 20:09:34 +0200	[thread overview]
Message-ID: <4FD4E2DE.20006@baatz.info> (raw)
In-Reply-To: <1339164583-11596-1-git-send-email-andrew@lunn.ch>

Hi Andrew,

Am 08.06.2012 16:09, schrieb Andrew Lunn:
> Both NAND and SPI make use of the RUNIT clk. However, if neither NAND
> nor SPI is used in the system, RUNIT clock gets turned off, and the
> SoC hard locks. It appears something else in the SoC, which is not
> documented, is also using RUNIT. So prepare and enable RUNIT clock in
> kirkwood_clk_init().
>
> +
> +	/* Something other than SPI and NAND needs runit, so make sure
> +	   it never gets turned off. */
> +	clk_prepare_enable(runit);
>

I am experiencing another type of crash caused by the GE0 clock (on a
IB-NAS 6210). I am compiling mv643xx_eth as a module. Thus, GE0 and GE1
get turned off first since they are unused.

When the module loads and it should enable GE0, the box hangs. I haven't
had time to find out why; my guess would be that the clock might already
be needed somewhere in mv643xx_eth_shared_probe(). The box boots again
after I add

clk_prepare_enable(ge0);

to the code above as a quick hack.

- Simon

  parent reply	other threads:[~2012-06-10 18:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-08 14:09 [PATCH] ARM: Kirkwood: Fix crash when neither NAND nor SPI Andrew Lunn
2012-06-08 15:34 ` Arnd Bergmann
2012-06-08 16:42   ` Andrew Lunn
2012-06-08 17:42     ` Jon Medhurst (Tixy)
2012-06-08 18:43       ` Andrew Lunn
2012-06-10 18:09 ` Simon Baatz [this message]
2012-06-10 20:13   ` Andrew Lunn
2012-06-10 20:33     ` Simon Baatz
2012-06-11 12:17   ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FD4E2DE.20006@baatz.info \
    --to=simon2012@baatz.info \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).