From: jon-hunter@ti.com (Jon Hunter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] MFD: OMAP3EVM: USB: cosmetic fix to failed parent clk set
Date: Mon, 11 Jun 2012 10:03:33 -0500 [thread overview]
Message-ID: <4FD608C5.9000900@ti.com> (raw)
In-Reply-To: <1339423216-1323-5-git-send-email-zumeng.chen@gmail.com>
On 06/11/2012 09:00 AM, Zumeng Chen wrote:
> A typo fix for this cosmetic change and mute a failed message from
> a unnecessary setting of some parent clk for usbhs_omap on OMAP3EVM.
>
> Signed-off-by: Zumeng Chen <zumeng.chen@gmail.com>
> ---
> drivers/mfd/omap-usb-host.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
> index 7e96bb2..9aaaf3c 100644
> --- a/drivers/mfd/omap-usb-host.c
> +++ b/drivers/mfd/omap-usb-host.c
> @@ -698,8 +698,9 @@ static int __devinit usbhs_omap_probe(struct platform_device *pdev)
> goto err_usbtll_p2_fck;
> }
>
> +#ifndef CONFIG_MACH_OMAP3EVM
> + /* for OMAP3 , the clk set parent fails */
> if (is_ehci_phy_mode(pdata->port_mode[0])) {
> - /* for OMAP3 , the clk set paretn fails */
> ret = clk_set_parent(omap->utmi_p1_fck,
> omap->xclk60mhsp1_ck);
> if (ret != 0)
This begs the question, why is port_mode[0] set to ehci phy mode if this
is failing? Something does not seem right here but this does not look
like the right fix.
Cheers
Jon
next prev parent reply other threads:[~2012-06-11 15:03 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <zumeng.chen@gmail.com>
2012-06-11 14:00 ` [PATCH 0/5] OMAP3530evm misc fixes for linux-omap Zumeng Chen
2012-06-11 14:00 ` [PATCH 1/5] ARM: OMAP3EVM: Add NAND flash definition Zumeng Chen
2012-06-11 14:57 ` Jon Hunter
2012-06-12 2:22 ` Zumeng Chen
2012-06-11 14:00 ` [PATCH 2/5] ARM: OMAP3EVM: Adding USB internal LDOs board file Zumeng Chen
2012-06-11 14:00 ` [PATCH 3/5] ARM: omap3evm: enable VBUS switch for EHCI tranceiver Zumeng Chen
2012-06-11 14:00 ` [PATCH 4/5] MFD: OMAP3EVM: USB: cosmetic fix to failed parent clk set Zumeng Chen
2012-06-11 15:03 ` Jon Hunter [this message]
2012-06-12 2:30 ` Zumeng Chen
2012-06-12 16:27 ` Jon Hunter
2012-06-12 16:54 ` Zumeng Chen
2012-06-12 7:56 ` Igor Grinberg
2012-06-11 14:00 ` [PATCH 5/5] Input: ads7846: set proper debounce time in driver level Zumeng Chen
2012-06-11 14:37 ` Igor Grinberg
2012-06-12 2:49 ` Zumeng Chen
2012-06-12 7:53 ` Igor Grinberg
2012-06-12 6:47 ` Tony Lindgren
2012-06-12 16:37 ` Zumeng Chen
2012-06-13 12:55 ` Tony Lindgren
2012-06-14 3:29 ` Zumeng Chen
2012-06-14 4:57 ` Zumeng Chen
2012-06-11 14:51 ` [PATCH 0/5] OMAP3530evm misc fixes for linux-omap Jon Hunter
2012-06-12 2:31 ` Zumeng Chen
2012-06-13 1:44 ` [PATCH v2 0/5] ARM " Zumeng Chen
2012-06-13 1:44 ` [PATCH V2 1/5] ARM: OMAP3EVM: Add NAND flash definition Zumeng Chen
2012-06-13 7:57 ` Igor Grinberg
2012-06-13 8:16 ` Zumeng Chen
2012-06-13 1:44 ` [PATCH V2 2/5] ARM: OMAP3EVM: Adding USB internal LDOs board file Zumeng Chen
2012-06-13 8:16 ` Igor Grinberg
2012-06-13 8:23 ` Zumeng Chen
2012-06-13 1:44 ` [PATCH V2 3/5] ARM: omap3evm: enable VBUS switch for EHCI tranceiver Zumeng Chen
2012-06-13 1:44 ` [PATCH V2 4/5] ARM: OMAP3EVM: cosmetic fixes for parent clk set Zumeng Chen
2012-06-13 1:44 ` [PATCH V2 5/5] Input: ads7846: set proper debounce time in driver level Zumeng Chen
2012-06-13 7:51 ` Igor Grinberg
2012-06-13 9:03 ` Zumeng Chen
2012-06-13 10:13 ` Igor Grinberg
2012-06-16 13:27 ` Marek Vasut
2012-06-13 12:18 ` Hiremath, Vaibhav
2012-06-14 3:29 ` Zumeng Chen
2012-06-14 4:46 ` Zumeng Chen
2012-06-14 6:31 ` Hiremath, Vaibhav
2012-06-14 6:59 ` Zumeng Chen
2012-06-16 0:15 ` zumeng.chen
2012-06-20 5:28 ` Zumeng Chen
2012-06-14 6:44 ` Igor Grinberg
2012-06-14 7:08 ` Zumeng Chen
2012-06-14 8:06 ` Igor Grinberg
2012-06-14 8:18 ` Zumeng Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD608C5.9000900@ti.com \
--to=jon-hunter@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).