* [PATCH] arm: ep93xx: Enable i2c support for ep9302
@ 2012-06-10 12:44 Todor Colov
2012-06-10 23:58 ` Ryan Mallon
0 siblings, 1 reply; 6+ messages in thread
From: Todor Colov @ 2012-06-10 12:44 UTC (permalink / raw)
To: linux-arm-kernel
Enable i2c support for ep9302. i2c support is needed when external RTC is
used.
Signed-off-by: Todor Colov <todorcolov@gmail.com>
---
--- linux-3.4/arch/arm/mach-ep93xx/edb93xx.c 2012-05-21 01:29:13.000000000 +0300
+++ linux-3.4/arch/arm/mach-ep93xx/edb93xx-i2c-ep9302-enabled.c 2012-06-10 14:18:06.977893546 +0300
@@ -91,8 +91,8 @@
ep93xx_register_i2c(&edb93xx_i2c_gpio_data,
edb93xxa_i2c_board_info,
ARRAY_SIZE(edb93xxa_i2c_board_info));
- } else if (machine_is_edb9307() || machine_is_edb9312() ||
- machine_is_edb9315()) {
+ } else if (machine_is_edb9302() || machine_is_edb9307()
+ || machine_is_edb9312() || machine_is_edb9315()) {
ep93xx_register_i2c(&edb93xx_i2c_gpio_data,
edb93xx_i2c_board_info,
ARRAY_SIZE(edb93xx_i2c_board_info));
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] arm: ep93xx: Enable i2c support for ep9302 2012-06-10 12:44 [PATCH] arm: ep93xx: Enable i2c support for ep9302 Todor Colov @ 2012-06-10 23:58 ` Ryan Mallon 2012-06-11 15:45 ` H Hartley Sweeten 0 siblings, 1 reply; 6+ messages in thread From: Ryan Mallon @ 2012-06-10 23:58 UTC (permalink / raw) To: linux-arm-kernel On 10/06/12 22:44, Todor Colov wrote: > > Enable i2c support for ep9302. i2c support is needed when external RTC is > used. > > Signed-off-by: Todor Colov <todorcolov@gmail.com> Thanks. Applied to ep93xx-fixes. > --- linux-3.4/arch/arm/mach-ep93xx/edb93xx.c 2012-05-21 01:29:13.000000000 +0300 > +++ linux-3.4/arch/arm/mach-ep93xx/edb93xx-i2c-ep9302-enabled.c 2012-06-10 14:18:06.977893546 +0300 Please use git diff in future. This wouldn't directly apply with git am. ~Ryan ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] arm: ep93xx: Enable i2c support for ep9302 2012-06-10 23:58 ` Ryan Mallon @ 2012-06-11 15:45 ` H Hartley Sweeten 2012-06-11 21:50 ` Ryan Mallon 0 siblings, 1 reply; 6+ messages in thread From: H Hartley Sweeten @ 2012-06-11 15:45 UTC (permalink / raw) To: linux-arm-kernel On Sunday, June 10, 2012 4:58 PM, Ryan Mallon wrote: > On 10/06/12 22:44, Todor Colov wrote: >> >> Enable i2c support for ep9302. i2c support is needed when external RTC is >> used. >> >> Signed-off-by: Todor Colov <todorcolov@gmail.com> > > Thanks. Applied to ep93xx-fixes. Ryan, I'm not sure about this patch... The EDB9302 does not have a built-on external RTC connected to the I2C bus. The EECLK and EEDAT pins are simply routed to two headers. They are not connected to any I2C devices built onto the board. This patch will cause _all_ edb9302 boards to bind the ds1337 driver to the I2C bus but that device will only exist if a user has connected the part externally to the board. Just my 2 cents... Regards, Hartley ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] arm: ep93xx: Enable i2c support for ep9302 2012-06-11 15:45 ` H Hartley Sweeten @ 2012-06-11 21:50 ` Ryan Mallon 2012-06-21 19:33 ` Martin Guy 0 siblings, 1 reply; 6+ messages in thread From: Ryan Mallon @ 2012-06-11 21:50 UTC (permalink / raw) To: linux-arm-kernel On 12/06/12 01:45, H Hartley Sweeten wrote: > On Sunday, June 10, 2012 4:58 PM, Ryan Mallon wrote: >> On 10/06/12 22:44, Todor Colov wrote: >>> >>> Enable i2c support for ep9302. i2c support is needed when external RTC is >>> used. >>> >>> Signed-off-by: Todor Colov <todorcolov@gmail.com> >> >> Thanks. Applied to ep93xx-fixes. > > Ryan, > > I'm not sure about this patch... > > The EDB9302 does not have a built-on external RTC connected to the I2C > bus. The EECLK and EEDAT pins are simply routed to two headers. They are > not connected to any I2C devices built onto the board. > > This patch will cause _all_ edb9302 boards to bind the ds1337 driver to the > I2C bus but that device will only exist if a user has connected the part > externally to the board. > > Just my 2 cents... Hmm, the binding is not really a problem, since it will just fail if the ds1337 device is not present at that i2c address. I guess the main problem is if there are users of the edb9302 who want i2c on the headers and others who want to use the pins as gpio. Without being able to auto-detect such boards at runtime (which seems very unlikely) I can't think of a good solution to this, other than it being time for me to do more DT reading :-). I'm inclined to leave the patch in. The ep93xx doesn't have a lot of users, so I think it is okay to tailor it a bit to the users we do have. I'm happy to revert it, and find a better solution if this breaks someone else's setup. ~Ryan ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] arm: ep93xx: Enable i2c support for ep9302 2012-06-11 21:50 ` Ryan Mallon @ 2012-06-21 19:33 ` Martin Guy 2012-07-01 22:57 ` Ryan Mallon 0 siblings, 1 reply; 6+ messages in thread From: Martin Guy @ 2012-06-21 19:33 UTC (permalink / raw) To: linux-arm-kernel On 11 June 2012 23:50, Ryan Mallon <rmallon@gmail.com> wrote: > On 12/06/12 01:45, H Hartley Sweeten wrote: > >> On Sunday, June 10, 2012 4:58 PM, Ryan Mallon wrote: >>> On 10/06/12 22:44, Todor Colov wrote: >>>> >>>> Enable i2c support for ep9302. i2c support is needed when external RTC is >>>> used. >>>> >>>> Signed-off-by: Todor Colov <todorcolov@gmail.com> >>> >>> Thanks. Applied to ep93xx-fixes. >> >> Ryan, >> >> I'm not sure about this patch... >> >> The EDB9302 does not have a built-on external RTC connected to the I2C >> bus. The EECLK and EEDAT pins are simply routed to two headers. They are >> not connected to any I2C devices built onto the board. >> >> This patch will cause _all_ edb9302 boards to bind the ds1337 driver to the >> I2C bus but that device will only exist if a user has connected the part >> externally to the board. >> >> Just my 2 cents... > > > Hmm, the binding is not really a problem, since it will just fail if the > ds1337 device is not present at that i2c address. I guess the main problem > is if there are users of the edb9302 who want i2c on the headers and others > who want to use the pins as gpio. Without being able to auto-detect such > boards at runtime (which seems very unlikely) I can't think of a good > solution to this, other than it being time for me to do more DT reading :-). > > I'm inclined to leave the patch in. The ep93xx doesn't have a lot of users, > so I think it is okay to tailor it a bit to the users we do have. I'm happy > to revert it, and find a better solution if this breaks someone else's > setup. Hi folks Can I add that the SimpleMachines.it Sim.One board, based on the EP9307, has a DS1337 on the I2C bus, for which the define is machine_is_sim_one() However, the existing Linux kernel already read/writes this chip successfully, so I'm not sure what advantage this change would bring for that board. If you would like to test your patch on that board too, we may be able to ship you an enginering sample; if that would be useful please reply by private email. Cheers M ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] arm: ep93xx: Enable i2c support for ep9302 2012-06-21 19:33 ` Martin Guy @ 2012-07-01 22:57 ` Ryan Mallon 0 siblings, 0 replies; 6+ messages in thread From: Ryan Mallon @ 2012-07-01 22:57 UTC (permalink / raw) To: linux-arm-kernel On 22/06/12 05:33, Martin Guy wrote: > On 11 June 2012 23:50, Ryan Mallon <rmallon@gmail.com> wrote: >> On 12/06/12 01:45, H Hartley Sweeten wrote: >> >>> On Sunday, June 10, 2012 4:58 PM, Ryan Mallon wrote: >>>> On 10/06/12 22:44, Todor Colov wrote: >>>>> >>>>> Enable i2c support for ep9302. i2c support is needed when external RTC is >>>>> used. >>>>> >>>>> Signed-off-by: Todor Colov <todorcolov@gmail.com> >>>> >>>> Thanks. Applied to ep93xx-fixes. >>> >>> Ryan, >>> >>> I'm not sure about this patch... >>> >>> The EDB9302 does not have a built-on external RTC connected to the I2C >>> bus. The EECLK and EEDAT pins are simply routed to two headers. They are >>> not connected to any I2C devices built onto the board. >>> >>> This patch will cause _all_ edb9302 boards to bind the ds1337 driver to the >>> I2C bus but that device will only exist if a user has connected the part >>> externally to the board. >>> >>> Just my 2 cents... >> >> >> Hmm, the binding is not really a problem, since it will just fail if the >> ds1337 device is not present at that i2c address. I guess the main problem >> is if there are users of the edb9302 who want i2c on the headers and others >> who want to use the pins as gpio. Without being able to auto-detect such >> boards at runtime (which seems very unlikely) I can't think of a good >> solution to this, other than it being time for me to do more DT reading :-). >> >> I'm inclined to leave the patch in. The ep93xx doesn't have a lot of users, >> so I think it is okay to tailor it a bit to the users we do have. I'm happy >> to revert it, and find a better solution if this breaks someone else's >> setup. > > Hi folks > Can I add that the SimpleMachines.it Sim.One board, based on the > EP9307, has a DS1337 on the I2C bus, for which the define is > machine_is_sim_one() However, the existing Linux kernel already > read/writes this chip successfully, so I'm not sure what advantage > this change would bring for that board. Hi Martin, Sorry for the late reply, I've been on holiday. The change only affects the Cirrus EDB-9302 board. The Sim.one is managed by a separate board file. > If you would like to test > your patch on that board too, we may be able to ship you an enginering > sample; if that would be useful please reply by private email. I already have one of the Sim.one boards. Thanks. ~Ryan ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-07-01 22:57 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-06-10 12:44 [PATCH] arm: ep93xx: Enable i2c support for ep9302 Todor Colov 2012-06-10 23:58 ` Ryan Mallon 2012-06-11 15:45 ` H Hartley Sweeten 2012-06-11 21:50 ` Ryan Mallon 2012-06-21 19:33 ` Martin Guy 2012-07-01 22:57 ` Ryan Mallon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).