From: jon-hunter@ti.com (Jon Hunter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 12/14] ARM: OMAP2+: gpmc: cs reconfigure helper
Date: Mon, 11 Jun 2012 18:04:33 -0500 [thread overview]
Message-ID: <4FD67981.7070508@ti.com> (raw)
In-Reply-To: <8882ae964a4034d58953e743cf35664d3a107823.1339419492.git.afzal@ti.com>
On 06/11/2012 09:27 AM, Afzal Mohammed wrote:
> Helper for reconfiguring CS, peripheral that necessitated
> it was OneNAND.
Why? I think you need to add more about why this was needed.
Jon
> Signed-off-by: Afzal Mohammed <afzal@ti.com>
> ---
> arch/arm/mach-omap2/gpmc.c | 32 ++++++++++++++++++++++++++++++++
> arch/arm/plat-omap/include/plat/gpmc.h | 2 ++
> 2 files changed, 34 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
> index 281bd23..d493a4c 100644
> --- a/arch/arm/mach-omap2/gpmc.c
> +++ b/arch/arm/mach-omap2/gpmc.c
> @@ -1429,6 +1429,38 @@ struct platform_device *gpmc_create_device(struct gpmc_peripheral *p)
> return pdev;
> }
>
> +static int gpmc_match_device(char *name, int id)
> +{
> + int i;
> + struct gpmc_peripheral *g_per = gpmc_peripheral;
> +
> + for (i = 0; i < gpmc_num_peripheral; i++, g_per++)
> + if (!strcmp(g_per->name, name) && g_per->id == id)
> + return i;
> +
> + return -ENOENT;
> +}
> +
> +int gpmc_cs_reconfigure(char *name, int id, struct gpmc_cs_data *c)
> +{
> + int i;
> +
> + i = gpmc_match_device(name, id);
> + if (IS_ERR_VALUE(i)) {
> + dev_err(gpmc_dev, "no device %s.%d to configure\n", name, id);
> + return i;
> + }
> +
> + if (IS_ERR_VALUE(gpmc_setup_cs_config_timing(gpmc_peripheral + i, c))) {
> + dev_err(gpmc_dev, "error: configure device %s.%d\n", name, id);
> + return i;
> + }
> +
> + return gpmc_setup_waitpin(gpmc_peripheral + i);
> +
> +}
> +EXPORT_SYMBOL_GPL(gpmc_cs_reconfigure);
> +
> static __devinit int gpmc_probe(struct platform_device *pdev)
> {
> u32 l;
> diff --git a/arch/arm/plat-omap/include/plat/gpmc.h b/arch/arm/plat-omap/include/plat/gpmc.h
> index e1b130c..32017a1 100644
> --- a/arch/arm/plat-omap/include/plat/gpmc.h
> +++ b/arch/arm/plat-omap/include/plat/gpmc.h
> @@ -247,6 +247,8 @@ extern int gpmc_cs_configure(int cs, int cmd, int wval);
> extern int gpmc_nand_read(int cs, int cmd);
> extern int gpmc_nand_write(int cs, int cmd, int wval);
>
> +extern int gpmc_cs_reconfigure(char *name, int id, struct gpmc_cs_data *c);
> +
> int gpmc_enable_hwecc(int cs, int mode, int dev_width, int ecc_size);
> int gpmc_calculate_ecc(int cs, const u_char *dat, u_char *ecc_code);
>
next prev parent reply other threads:[~2012-06-11 23:04 UTC|newest]
Thread overview: 116+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 14:25 [PATCH v5 00/14] GPMC driver conversion Afzal Mohammed
2012-06-11 14:26 ` [PATCH v5 01/14] ARM: OMAP2+: gpmc: platform definitions Afzal Mohammed
2012-06-12 18:58 ` Jon Hunter
2012-06-13 6:25 ` Mohammed, Afzal
2012-06-11 14:26 ` [PATCH v5 02/14] ARM: OMAP2+: gpmc: Adapt to HWMOD Afzal Mohammed
2012-06-11 19:56 ` Jon Hunter
2012-06-12 6:53 ` Mohammed, Afzal
2012-06-12 17:40 ` Jon Hunter
2012-06-13 5:20 ` Mohammed, Afzal
2012-06-13 12:02 ` Tony Lindgren
2012-06-13 13:05 ` Mohammed, Afzal
2012-06-13 13:39 ` Tony Lindgren
2012-06-13 13:59 ` Mohammed, Afzal
2012-06-13 15:08 ` Jon Hunter
2012-06-14 7:07 ` Mohammed, Afzal
2012-06-13 14:51 ` Jon Hunter
2012-06-14 6:17 ` Mohammed, Afzal
2012-06-14 6:20 ` Mohammed, Afzal
2012-06-14 20:51 ` Jon Hunter
2012-06-15 0:20 ` Paul Walmsley
2012-06-15 15:33 ` Jon Hunter
2012-06-15 10:40 ` Mohammed, Afzal
2012-06-14 7:03 ` Mohammed, Afzal
2012-06-14 13:22 ` Jon Hunter
2012-06-14 13:32 ` Mohammed, Afzal
2012-06-14 18:58 ` Jon Hunter
2012-06-15 10:22 ` Mohammed, Afzal
2012-06-15 12:45 ` Tony Lindgren
2012-06-16 9:15 ` Mohammed, Afzal
2012-06-20 13:28 ` Tony Lindgren
2012-06-20 14:52 ` Mohammed, Afzal
2012-06-20 15:12 ` Tony Lindgren
2012-06-20 23:35 ` Jon Hunter
2012-06-22 13:29 ` Mohammed, Afzal
2012-06-11 14:26 ` [PATCH v5 03/14] ARM: OMAP2+: gpmc: driver migration helper Afzal Mohammed
2012-06-11 20:30 ` Jon Hunter
2012-06-12 7:09 ` Mohammed, Afzal
2012-06-12 17:46 ` Jon Hunter
2012-06-13 5:25 ` Mohammed, Afzal
2012-06-13 12:04 ` Tony Lindgren
2012-06-13 12:18 ` Mohammed, Afzal
2012-06-13 13:46 ` Mohammed, Afzal
2012-06-14 6:34 ` Tony Lindgren
2012-06-11 14:26 ` [PATCH v5 04/14] ARM: OMAP2+: gpmc: minimal driver support Afzal Mohammed
2012-06-11 20:43 ` Jon Hunter
2012-06-12 7:16 ` Mohammed, Afzal
2012-06-12 17:57 ` Jon Hunter
2012-06-13 12:07 ` Tony Lindgren
2012-06-13 13:12 ` Mohammed, Afzal
2012-06-13 13:40 ` Tony Lindgren
2012-06-13 13:44 ` Tony Lindgren
2012-06-13 13:50 ` Mohammed, Afzal
2012-06-13 13:52 ` Mohammed, Afzal
2012-06-14 6:35 ` Tony Lindgren
2012-06-14 6:40 ` Mohammed, Afzal
2012-06-14 8:39 ` Tony Lindgren
2012-06-14 8:42 ` Mohammed, Afzal
2012-06-13 17:05 ` Jon Hunter
2012-06-12 19:19 ` Jon Hunter
2012-06-13 6:29 ` Mohammed, Afzal
2012-06-11 14:26 ` [PATCH v5 05/14] ARM: OMAP2+: gpmc: resource creation helpers Afzal Mohammed
2012-06-11 20:57 ` Jon Hunter
2012-06-12 8:30 ` Mohammed, Afzal
2012-06-12 18:02 ` Jon Hunter
2012-06-13 5:29 ` Mohammed, Afzal
2012-06-13 15:33 ` Jon Hunter
2012-06-14 8:44 ` Mohammed, Afzal
2012-06-11 14:26 ` [PATCH v5 06/14] ARM: OMAP2+: gpmc: CS configuration helper Afzal Mohammed
2012-06-11 21:43 ` Jon Hunter
2012-06-12 8:40 ` Mohammed, Afzal
2012-06-12 12:58 ` Mohammed, Afzal
2012-06-12 18:09 ` Jon Hunter
2012-06-13 5:50 ` Mohammed, Afzal
2012-06-13 15:39 ` Jon Hunter
2012-06-14 8:45 ` Mohammed, Afzal
2012-06-12 18:06 ` Jon Hunter
2012-06-13 5:35 ` Mohammed, Afzal
2012-06-11 14:27 ` [PATCH v5 07/14] ARM: OMAP2+: gpmc: time setting (register#) helper Afzal Mohammed
2012-06-12 18:55 ` Jon Hunter
2012-06-13 6:15 ` Mohammed, Afzal
2012-06-11 14:27 ` [PATCH v5 08/14] ARM: OMAP2+: gpmc: bool type timing helper Afzal Mohammed
2012-06-11 22:27 ` Jon Hunter
2012-06-12 8:41 ` Mohammed, Afzal
2012-06-11 14:27 ` [PATCH v5 09/14] ARM: OMAP2+: gpmc: holler if no configuration Afzal Mohammed
2012-06-11 22:30 ` Jon Hunter
2012-06-12 8:44 ` Mohammed, Afzal
2012-06-12 18:11 ` Jon Hunter
2012-06-11 14:27 ` [PATCH v5 10/14] ARM: OMAP2+: gpmc: waitpin helper Afzal Mohammed
2012-06-11 22:59 ` Jon Hunter
2012-06-12 9:00 ` Mohammed, Afzal
2012-06-12 18:15 ` Jon Hunter
2012-06-13 7:37 ` Mohammed, Afzal
2012-06-13 15:44 ` Jon Hunter
2012-06-14 8:48 ` Mohammed, Afzal
2012-06-14 21:06 ` Jon Hunter
2012-06-15 10:50 ` Mohammed, Afzal
2012-06-12 18:37 ` Jon Hunter
2012-06-13 7:47 ` Mohammed, Afzal
2012-06-11 14:27 ` [PATCH v5 11/14] ARM: OMAP2+: gpmc: handle connected peripherals Afzal Mohammed
2012-06-13 15:31 ` Jon Hunter
2012-06-14 8:40 ` Mohammed, Afzal
2012-06-11 14:27 ` [PATCH v5 12/14] ARM: OMAP2+: gpmc: cs reconfigure helper Afzal Mohammed
2012-06-11 23:04 ` Jon Hunter [this message]
2012-06-12 9:01 ` Mohammed, Afzal
2012-06-11 14:27 ` [PATCH v5 13/14] ARM: OMAP2+: gpmc: update nand register info Afzal Mohammed
2012-06-11 14:27 ` [PATCH v5 14/14] ARM: OMAP2+: gpmc: writeprotect helper Afzal Mohammed
2012-06-12 18:42 ` Jon Hunter
2012-06-13 6:10 ` Mohammed, Afzal
2012-06-13 16:28 ` Jon Hunter
2012-06-14 8:54 ` Mohammed, Afzal
2012-06-14 9:36 ` Tony Lindgren
2012-06-14 10:21 ` Mohammed, Afzal
2012-06-12 10:39 ` [PATCH v5 00/14] GPMC driver conversion Mohammed, Afzal
2012-06-13 12:33 ` Tony Lindgren
2012-06-15 10:56 ` Mohammed, Afzal
2012-06-15 12:51 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD67981.7070508@ti.com \
--to=jon-hunter@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).