[PATCH] pinctrl: nomadik: fix up typo

[PATCH] pinctrl: nomadik: fix up typo

[Linus Walleij]

Commit a60b57eddaa8af6c02cf7bbeb58ebf82881f08ac
"drivers/gpio: gpio-nomadik: Add support for irqdomains"
changed GPIO offset calculations to have this form:
(gpio % NMK_GPIO_PER_CHIP) except in this one place for
setting sleep mode, where the conversion was all wrong, and
instead mod:ing the GPIO with the IRQ base which does not
make any sense.

So fix this up so we can use sleepmode.

Cc: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>
---
 drivers/pinctrl/pinctrl-nomadik.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-nomadik.c b/drivers/pinctrl/pinctrl-nomadik.c
index ba7122f..e8937e7 100644
--- a/drivers/pinctrl/pinctrl-nomadik.c
+++ b/drivers/pinctrl/pinctrl-nomadik.c
@@ -673,7 +673,7 @@ static void __nmk_gpio_set_wake(struct nmk_gpio_chip *nmk_chip,
 	 * wakeup is anyhow controlled by the RIMSC and FIMSC registers.
 	 */
 	if (nmk_chip->sleepmode && on) {
-		__nmk_gpio_set_slpm(nmk_chip, gpio % nmk_chip->chip.base,
+		__nmk_gpio_set_slpm(nmk_chip, gpio % NMK_GPIO_PER_CHIP,
 				    NMK_GPIO_SLPM_WAKEUP_ENABLE);
 	}
 
-- 
1.7.9.2

[PATCH] pinctrl: nomadik: fix up typo

[Lee Jones]

On 12/06/12 11:56, Linus Walleij wrote:
> Commit a60b57eddaa8af6c02cf7bbeb58ebf82881f08ac
> "drivers/gpio: gpio-nomadik: Add support for irqdomains"
> changed GPIO offset calculations to have this form:
> (gpio % NMK_GPIO_PER_CHIP) except in this one place for
> setting sleep mode, where the conversion was all wrong, and
> instead mod:ing the GPIO with the IRQ base which does not
> make any sense.
>
> So fix this up so we can use sleepmode.
>
> Cc: Lee Jones<lee.jones@linaro.org>
> Signed-off-by: Linus Walleij<linus.walleij@stericsson.com>

Makes sense.

Reviewed-by: Lee Jones <lee.jones@linaro.org>

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
M: +44 77 88 633 515
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog