From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: irq: add a mach/fiq.h inclusion for SPARSE_IRQ build
Date: Wed, 13 Jun 2012 09:36:45 -0500 [thread overview]
Message-ID: <4FD8A57D.9050700@gmail.com> (raw)
In-Reply-To: <1339592253-25142-1-git-send-email-shawn.guo@linaro.org>
On 06/13/2012 07:57 AM, Shawn Guo wrote:
> The commit a2be01b (ARM: only include mach/irqs.h for !SPARSE_IRQ)
> makes mach/irqs.h only be included for !SPARSE_IRQ build. There are
> a nubmer of platforms have FIQ_START defined in mach/irqs.h.
>
> arch/arm/mach-at91/include/mach/irqs.h:#define FIQ_START AT91_ID_FIQ
This one doesn't appear to actually be used anywhere.
> arch/arm/mach-rpc/include/mach/irqs.h:#define FIQ_START 64
> arch/arm/mach-s3c24xx/include/mach/irqs.h:#define FIQ_START IRQ_EINT0
> arch/arm/plat-mxc/include/mach/irqs.h:#define FIQ_START 0
> arch/arm/plat-omap/include/plat/irqs.h:#define FIQ_START 1024
>
> If SPARSE_IRQ is enabled for any of these platforms, the following
> compile error will be seen.
>
> arch/arm/kernel/fiq.c: In function ?enable_fiq?:
> arch/arm/kernel/fiq.c:127:19: error: ?FIQ_START? undeclared (first use in this function)
> arch/arm/kernel/fiq.c:127:19: note: each undeclared identifier is reported only once for each function it appears in
> arch/arm/kernel/fiq.c: In function ?disable_fiq?:
> arch/arm/kernel/fiq.c:132:20: error: ?FIQ_START? undeclared (first use in this function)
>
> So before we can remove the reference to FIQ_START in fiq.c, we need
> a way out. The patch adds a mach/fiq.h inclusion for SPARSE_IRQ build
> in asm/irq.h, so that platform can have a chance to provide FIQ_START.
The whole point of enabling SPARSE_IRQ was to eliminate a mach include
and now this adds a new one. This is not the right solution.
I think we need to remove FIQ_START from enable_fiq/disable_fiq and make
the platforms add any private offset they need. Only rpc and imx call
enable_fiq/disable_fiq. imx offset is 0, so that leaves only rpc.
The other simple solution is make fiq_start a variable.
Rob
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> ---
> arch/arm/include/asm/irq.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/include/asm/irq.h b/arch/arm/include/asm/irq.h
> index 35c21c3..3fa390d 100644
> --- a/arch/arm/include/asm/irq.h
> +++ b/arch/arm/include/asm/irq.h
> @@ -7,6 +7,7 @@
> #include <mach/irqs.h>
> #else
> #define NR_IRQS NR_IRQS_LEGACY
> +#include <mach/fiq.h>
> #endif
>
> #ifndef irq_canonicalize
prev parent reply other threads:[~2012-06-13 14:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-13 12:57 [PATCH] ARM: irq: add a mach/fiq.h inclusion for SPARSE_IRQ build Shawn Guo
2012-06-13 13:07 ` Shawn Guo
2012-06-13 13:38 ` Shawn Guo
2012-06-13 14:34 ` Nicolas Pitre
2012-06-13 14:36 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD8A57D.9050700@gmail.com \
--to=robherring2@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).