linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: sebastian.hesselbarth@googlemail.com (Sebastian Hesselbarh)
To: linux-arm-kernel@lists.infradead.org
Subject: Dove clock support
Date: Mon, 18 Jun 2012 12:01:14 +0200	[thread overview]
Message-ID: <4FDEFC6A.7030300@googlemail.com> (raw)
In-Reply-To: <4FDEFAE2.7000303@blackshift.org>

On 06/18/2012 11:54 AM, Marc Kleine-Budde wrote:
>> Also ge-phy has to be connected with ge-clk, too. But for dove this is
>> a clk gate while kirkwood can shut it down somewhere else. I guess it
>> can be handled like sata/pcie on kirkwood.
>
> The PHY is a clock gate so I'm handling it via:
>> ge = dove_register_gate("ge0", CLOCK_GATING_GBE_BIT | CLOCK_GATING_GIGA_PHY_BIT);
> So no gate_fn needed.

There is no fn needed for dove, but kirkwood will need one IIRC.
Moreover, you could hook-up PHY-gate as a parent of corresponding
clk-gate and they will be enabled/disabled simultaneously.

But I'd prefer the driver to take care of clks _and_ PHYs.

One more: I suggest to clean the clk names of orion platforms,
they are a mess ;) And IMHO clks should always have both strings
set, e.g. kirkwood-i2s has an extclk input besides it on-chip clk.

Sebastian

  reply	other threads:[~2012-06-18 10:01 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-18  0:07 RFC: [PATCH] ARM: Kirkwood: clk_register_gate_fn: add fn assignment Marc Kleine-Budde
2012-06-18  7:42 ` Andrew Lunn
2012-06-18  7:54   ` Marc Kleine-Budde
2012-06-18  8:04     ` Andrew Lunn
2012-06-18  8:28       ` Dove clock support (was: Re: RFC: [PATCH] ARM: Kirkwood: clk_register_gate_fn: add fn assignment) Marc Kleine-Budde
2012-06-18  8:43         ` Andrew Lunn
2012-06-18  9:42           ` Dove clock support Sebastian Hesselbarh
2012-06-18  9:54             ` Marc Kleine-Budde
2012-06-18 10:01               ` Sebastian Hesselbarh [this message]
2012-06-18 10:11                 ` Andrew Lunn
2012-06-18 20:38                   ` Sebastian Hesselbarh
2012-06-19 19:25                     ` Andrew Lunn
2012-06-19 19:31                       ` Sebastian Hesselbarh
2012-06-19 19:35                         ` Andrew Lunn
2012-06-18 11:50                 ` Marc Kleine-Budde
2012-06-18 21:41           ` Dove clock support (was: Re: RFC: [PATCH] ARM: Kirkwood: clk_register_gate_fn: add fn assignment) Simon Baatz
2012-06-18 22:10             ` Dove clock support Sebastian Hesselbarh
2012-06-19 19:32               ` Andrew Lunn
2012-06-19 20:42                 ` Simon Baatz
2012-06-19 20:43                   ` Marc Kleine-Budde
2012-06-19 20:55                   ` Sebastian Hesselbarh
2012-06-19 23:06                     ` Simon Baatz
2012-06-20  5:43                       ` Andrew Lunn
2012-06-20  5:51                   ` Andrew Lunn
2012-06-24 15:17                     ` Simon Baatz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FDEFC6A.7030300@googlemail.com \
    --to=sebastian.hesselbarth@googlemail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).