From mboxrd@z Thu Jan  1 00:00:00 1970
From: stigge@antcom.de (Roland Stigge)
Date: Sun, 24 Jun 2012 16:42:28 +0200
Subject: [PATCH RESEND v4] input: keyboard: Add keys driver for the LPC32xx
 SoC
In-Reply-To: <20120621085623.GF2193@core.coreip.homeip.net>
References: <1339443891-15197-1-git-send-email-stigge@antcom.de>
 <20120621085623.GF2193@core.coreip.homeip.net>
Message-ID: <4FE72754.2000706@antcom.de>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On 21/06/12 10:56, Dmitry Torokhov wrote:
> On Mon, Jun 11, 2012 at 09:44:51PM +0200, Roland Stigge wrote:
>> This patch adds a driver for the key scan interface of the LPC32xx SoC
>>
>> Signed-off-by: Roland Stigge <stigge@antcom.de>
>> For the DT binding: Acked-by: Rob Herring <rob.herring@calxeda.con>
> 
> Not a real review, just a quick question - if th driver is DT-only now
> do we need to have the platform data or it would make more sense to read
> DT-bindings and fill the main device structure directly?

And:

>> +
>> +	matrix_keypad_build_keymap(NULL, NULL, kscandat->kscancfg->matrix_sz,
>> +				   kscandat->kscancfg->matrix_sz,
>> +				   kscandat->kscancfg->keymap, kscandat->input);
> 
> This function may fail now.

I'm addressing both issues in a updated patch.

Thanks for the feedback,

Roland