linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: mkl@pengutronix.de (Marc Kleine-Budde)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] MXS: Enable FLEXCAN for MXS/DT
Date: Tue, 26 Jun 2012 13:43:11 +0200	[thread overview]
Message-ID: <4FE9A04F.8030109@pengutronix.de> (raw)
In-Reply-To: <20120626112804.GC8858@S2101-09.ap.freescale.net>

On 06/26/2012 01:28 PM, Shawn Guo wrote:
> On Tue, Jun 26, 2012 at 11:07:24AM +0200, Marc Kleine-Budde wrote:
>>> +       select HAVE_CAN_FLEXCAN if NET && CAN
>>
>> ...and put this select to MACH_MXS_DT, instead of SOC_IMX28
>>
> Hmm, why?  Flexcan is a feature/block of SoC rather than a machine,
> isn't it?

Yes, but the HAVE_CAN_FLEXCAN is used to make the driver available in
Kconfig. What about removing the "depends on HAVE_CAN_FLEXCAN" from the
driver symbol in Kconfig? I can push it via net-next and it will be
mainline in 3.6. You can remove the HAVE_CAN_FLEXCAN from the ARM (and
powerpc) trees.

To avoid Kconfig hickups I'll keep the HAVE_CAN_FLEXCAN symbol in the
net-tree as long as the select HAVE_CAN_FLEXCAN is still present.

Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120626/e1a388a0/attachment.sig>

  reply	other threads:[~2012-06-26 11:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-27  2:11 [PATCH] MXS: Enable FLEXCAN for MXS/DT Marek Vasut
2012-06-06  5:39 ` Shawn Guo
2012-06-26  9:04 ` Marc Kleine-Budde
2012-06-26  9:07   ` Marc Kleine-Budde
2012-06-26 11:28     ` Shawn Guo
2012-06-26 11:43       ` Marc Kleine-Budde [this message]
2012-06-26 14:07         ` Shawn Guo
2012-06-26 15:43           ` Marek Vasut
  -- strict thread matches above, loose matches on Subject: below --
2012-06-08 18:57 Marek Vasut
2012-06-11  7:13 ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FE9A04F.8030109@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).