From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: arch timer: implement read_current_timer and get_cycles
Date: Tue, 26 Jun 2012 10:44:16 -0700 [thread overview]
Message-ID: <4FE9F4F0.9000201@codeaurora.org> (raw)
In-Reply-To: <20120626103718.GD27996@mudshark.cambridge.arm.com>
On 06/26/12 03:37, Will Deacon wrote:
> On Mon, Jun 25, 2012 at 10:39:04PM +0100, Stephen Boyd wrote:
>>> +int read_current_timer(unsigned long *timer_val)
>>> +{
>>> + if (!arch_timer_rate)
>>> + return -ENXIO;
>> Shouldn't this be returning 0? Otherwise get_cycles() up there will
>> evaluate to -ENXIO?
> I don't think so. The cycle count is returned via the timer_val parameter
> and the get_cycles code checks the return value, so will give 0 if
> read_current_timer returns anything other than 0. The core calibration code
> (not that we call it) also expects a return value < 0 to indicate failure.
Ah you're right. More coffee in the morning would do me some good.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2012-06-26 17:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-22 15:09 [PATCH 0/2] Use architected timers for delay loop Will Deacon
2012-06-22 15:09 ` [PATCH 1/2] ARM: arch timer: implement read_current_timer and get_cycles Will Deacon
2012-06-25 21:39 ` Stephen Boyd
2012-06-26 10:37 ` Will Deacon
2012-06-26 17:44 ` Stephen Boyd [this message]
2012-06-22 15:09 ` [PATCH 2/2] ARM: delay: allow timer-based delay implementation to be selected Will Deacon
2012-06-25 21:39 ` Stephen Boyd
2012-06-26 10:49 ` Will Deacon
2012-06-26 15:54 ` Will Deacon
2012-06-26 16:00 ` Rob Herring
2012-06-26 16:28 ` Will Deacon
2012-06-27 2:07 ` Stephen Boyd
2012-06-27 9:41 ` Will Deacon
2012-06-22 22:26 ` [PATCH 0/2] Use architected timers for delay loop Russell King - ARM Linux
2012-06-25 10:03 ` Will Deacon
2012-06-25 21:38 ` Stephen Boyd
2012-06-26 10:35 ` Will Deacon
2012-06-26 17:42 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE9F4F0.9000201@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).