From: hpa@zytor.com (H. Peter Anvin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 5/6] x86: add CONFIG_ARM_AMBA, selected by STA2X11
Date: Thu, 28 Jun 2012 13:06:53 -0700 [thread overview]
Message-ID: <4FECB95D.7010200@zytor.com> (raw)
In-Reply-To: <f85fefb10b7a7407b77180be65b18bf0426145b9.1338222461.git.rubini@gnudd.com>
On 05/28/2012 09:37 AM, Alessandro Rubini wrote:
> The sta2x11 I/O Hub is a bridge from PCIe to AMBA. It reuses a number
> of amba drivers and needs to activate core bus support.
>
> Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
> Acked-by: Giancarlo Asnaghi <giancarlo.asnaghi@st.com>
> ---
> arch/x86/Kconfig | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 91dea918..112718f 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -500,6 +500,7 @@ config STA2X11
> select SWIOTLB
> select MFD_STA2X11
> select ARCH_REQUIRE_GPIOLIB
> + select ARM_AMBA
> default n
> ---help---
> This adds support for boards based on the STA2X11 IO-Hub,
> @@ -2173,6 +2174,9 @@ config GEOS
>
> endif # X86_32
>
> +config ARM_AMBA
> + bool
> +
> config AMD_NB
> def_bool y
> depends on CPU_SUP_AMD && PCI
Nacked-by: H. Peter Anvin <hpa@zytor.com>
This brings in tons of code into the x86 all{yes,mod}config builds, and
as perhaps one could expect some of it doesn't compile. For example:
/home/hpa/kernel/tip.x86-platform/drivers/dma/pl330.c: In function
?dmac_alloc_resources?:
/home/hpa/kernel/tip.x86-platform/drivers/dma/pl330.c:2056:2: warning:
passing argument 3 of ?dma_alloc_attrs? from incompatible
pointer type [enabled by default]
In file included from
/home/hpa/kernel/tip.x86-platform/include/linux/dma-mapping.h:73:0,
from
/home/hpa/kernel/tip.x86-platform/drivers/dma/pl330.c:22:
/home/hpa/kernel/tip.x86-platform/arch/x86/include/asm/dma-mapping.h:130:1:
note: expected ?dma_addr_t *? but argument is of typ
e ?u32 *?
CC sound/pci/au88x0/au8830.o
/home/hpa/kernel/tip.x86-platform/drivers/dma/pl330.c:73:0: warning:
"DS" redefined [enabled by default]
In file included from
/home/hpa/kernel/tip.x86-platform/arch/x86/include/asm/ptrace.h:5:0,
from
/home/hpa/kernel/tip.x86-platform/arch/x86/include/asm/vm86.h:130,
from
/home/hpa/kernel/tip.x86-platform/arch/x86/include/asm/processor.h:10,
from
/home/hpa/kernel/tip.x86-platform/arch/x86/include/asm/thread_info.h:22,
from
/home/hpa/kernel/tip.x86-platform/include/linux/thread_info.h:54,
from
/home/hpa/kernel/tip.x86-platform/include/linux/preempt.h:9,
from
/home/hpa/kernel/tip.x86-platform/include/linux/spinlock.h:50,
from
/home/hpa/kernel/tip.x86-platform/include/linux/vmalloc.h:4,
from
/home/hpa/kernel/tip.x86-platform/arch/x86/include/asm/io.h:195,
from
/home/hpa/kernel/tip.x86-platform/include/linux/io.h:22,
from
/home/hpa/kernel/tip.x86-platform/drivers/dma/pl330.c:15:
/home/hpa/kernel/tip.x86-platform/arch/x86/include/asm/ptrace-abi.h:13:0: note:
this is the location of the previous definition
/home/hpa/kernel/tip.x86-platform/drivers/dma/pl330.c:89:0: warning:
"ES" redefined [enabled by default]
In file included from
/home/hpa/kernel/tip.x86-platform/arch/x86/include/asm/ptrace.h:5:0,
from
/home/hpa/kernel/tip.x86-platform/arch/x86/include/asm/vm86.h:130,
from
/home/hpa/kernel/tip.x86-platform/arch/x86/include/asm/processor.h:10,
from
/home/hpa/kernel/tip.x86-platform/arch/x86/include/asm/thread_info.h:22,
from
/home/hpa/kernel/tip.x86-platform/include/linux/thread_info.h:54,
from
/home/hpa/kernel/tip.x86-platform/include/linux/preempt.h:9,
from
/home/hpa/kernel/tip.x86-platform/include/linux/spinlock.h:50,
from
/home/hpa/kernel/tip.x86-platform/include/linux/vmalloc.h:4,
from
/home/hpa/kernel/tip.x86-platform/arch/x86/include/asm/io.h:195,
from
/home/hpa/kernel/tip.x86-platform/include/linux/io.h:22,
from
/home/hpa/kernel/tip.x86-platform/drivers/dma/pl330.c:15:
/home/hpa/kernel/tip.x86-platform/arch/x86/include/asm/ptrace-abi.h:14:0: note:
this is the location of the previous definition
/home/hpa/kernel/tip.x86-platform/drivers/dma/pl330.c:100:0: warning:
"CS" redefined [enabled by default]
In file included from
/home/hpa/kernel/tip.x86-platform/arch/x86/include/asm/ptrace.h:5:0,
from
/home/hpa/kernel/tip.x86-platform/arch/x86/include/asm/vm86.h:130,
from
/home/hpa/kernel/tip.x86-platform/arch/x86/include/asm/processor.h:10,
from
/home/hpa/kernel/tip.x86-platform/arch/x86/include/asm/thread_info.h:22,
from
/home/hpa/kernel/tip.x86-platform/include/linux/thread_info.h:54,
from
/home/hpa/kernel/tip.x86-platform/include/linux/preempt.h:9,
from
/home/hpa/kernel/tip.x86-platform/include/linux/spinlock.h:50,
from
/home/hpa/kernel/tip.x86-platform/include/linux/vmalloc.h:4,
from
/home/hpa/kernel/tip.x86-platform/arch/x86/include/asm/io.h:195,
from
/home/hpa/kernel/tip.x86-platform/include/linux/io.h:22,
from
/home/hpa/kernel/tip.x86-platform/drivers/dma/pl330.c:15:
/home/hpa/kernel/tip.x86-platform/arch/x86/include/asm/ptrace-abi.h:19:0: note:
this is the location of the previous definition
CC drivers/dma/pch_dma.o
CC drivers/dma/amba-pl08x.o
/home/hpa/kernel/tip.x86-platform/drivers/dma/amba-pl08x.c:86:32: fatal
error: asm/hardware/pl080.h: No such file or directory
compilation terminated.
make[4]: *** [drivers/dma/amba-pl08x.o] Error 1
make[3]: *** [drivers/dma] Error 2
make[2]: *** [drivers] Error 2
make[2]: *** Waiting for unfinished jobs....
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2012-06-28 20:06 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1338222460.git.rubini@gnudd.com>
2012-05-28 16:37 ` [PATCH V2 1/6] sizes.h: move from asm-generic to <linux/sizes.h> Alessandro Rubini
2012-05-28 16:37 ` [PATCH V2 2/6] amba: use the new linux/sizes.h Alessandro Rubini
2012-05-28 16:37 ` [PATCH V2 3/6] ARM: " Alessandro Rubini
2012-05-28 16:37 ` [PATCH V2 4/6] serial: " Alessandro Rubini
2012-05-28 16:37 ` [PATCH V2 5/6] x86: add CONFIG_ARM_AMBA, selected by STA2X11 Alessandro Rubini
2012-06-28 20:06 ` H. Peter Anvin [this message]
2012-07-01 10:44 ` Alessandro Rubini
2012-07-01 10:59 ` Russell King - ARM Linux
2012-07-01 11:58 ` Jassi Brar
2012-07-01 12:10 ` Russell King - ARM Linux
2012-07-01 13:11 ` Jassi Brar
2012-07-01 11:04 ` Alessandro Rubini
2012-07-01 11:11 ` Russell King - ARM Linux
2012-07-01 14:13 ` H. Peter Anvin
2012-07-02 16:58 ` Arnd Bergmann
2012-07-02 18:05 ` Mark Brown
2012-07-02 18:07 ` H. Peter Anvin
2012-07-02 18:33 ` Mark Brown
2012-07-02 19:41 ` H. Peter Anvin
2012-07-03 11:05 ` Mark Brown
2012-07-03 13:00 ` Alessandro Rubini
2012-07-03 13:19 ` Arnd Bergmann
2012-07-03 19:34 ` Russell King - ARM Linux
2012-08-05 20:28 ` Linus Walleij
2012-08-07 10:06 ` Kukjin Kim
2012-07-03 13:26 ` Alessandro Rubini
2012-07-03 19:46 ` Russell King - ARM Linux
2012-05-28 16:38 ` [PATCH V2 6/6] drivers/amba: add support for a PCI bridge Alessandro Rubini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FECB95D.7010200@zytor.com \
--to=hpa@zytor.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).