From: clemens@ladisch.de (Clemens Ladisch)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] common: dma-mapping: add support for generic dma_mmap_* calls
Date: Fri, 29 Jun 2012 15:16:54 +0200 [thread overview]
Message-ID: <4FEDAAC6.2050202@ladisch.de> (raw)
In-Reply-To: <00a501cd55f7$323946f0$96abd4d0$%szyprowski@samsung.com>
Marek Szyprowski wrote:
> On Friday, June 29, 2012 1:10 PM Clemens Ladisch wrote:
>> Marek Szyprowski wrote:
>>> +++ b/drivers/base/dma-mapping.c
>>> ...
>>> +int dma_common_mmap(struct device *dev, struct vm_area_struct *vma,
>>> + void *cpu_addr, dma_addr_t dma_addr, size_t size)
>>> +{
>>> + int ret = -ENXIO;
>>> + ...
>>> + if (dma_mmap_from_coherent(dev, vma, cpu_addr, size, &ret))
>>> + return ret;
>>
>> This will return -ENXIO if dma_mmap_from_coherent() succeeds.
>
> Thanks for spotting this!
Sorry, I was wrong; ret is actually set by dma_mmap_from_coherent's
output parameter. (That function's documentation appears to be
incomplete.)
Regards,
Clemens
prev parent reply other threads:[~2012-06-29 13:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-15 6:18 [PATCH] common: dma-mapping: add support for generic dma_mmap_* calls Marek Szyprowski
2012-06-29 11:09 ` Clemens Ladisch
2012-06-29 13:00 ` Marek Szyprowski
2012-06-29 13:16 ` Clemens Ladisch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FEDAAC6.2050202@ladisch.de \
--to=clemens@ladisch.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).