linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: rnayak@ti.com (Rajendra Nayak)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] ARM: omap: clk: add clk_prepare and clk_unprepare
Date: Mon, 02 Jul 2012 15:17:45 +0530	[thread overview]
Message-ID: <4FF16E41.8020906@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1206291416180.2338@utopia.booyaka.com>

On Saturday 30 June 2012 01:49 AM, Paul Walmsley wrote:
> Hi
>
> On Wed, 27 Jun 2012, Rajendra Nayak wrote:
>
>> As part of Common Clk Framework (CCF) the clk_enable() operation
>> was split into a clk_prepare() which could sleep, and a clk_enable()
>> which should never sleep. Similarly the clk_disable() was
>> split into clk_disable() and clk_unprepare(). This was
>> needed to handle complex cases where in a clk gate/ungate
>> would require a slow and a fast part to be implemented.
>> None of the clocks below seem to be in the 'complex' clocks
>> category and are just simple clocks which are enabled/disabled
>> through simple register writes.
>> Most of the instances also seem to be called in non-atomic
>> context which means its safe to move all of those from
>> using a clk_enable() to clk_prepare_enable() and clk_disable() to
>> clk_disable_unprepare().
>> For a few others where there is a possibility they get called from
>> an interrupt or atomic context, there is an additonal clk_prepare()
>> done before a clk_enable() and a clk_unprepare()
>> after a clk_disable().
>> This is in preparation of OMAP moving to CCF.
>>
>> Based on initial changes from Mike turquette.
>>
>> Signed-off-by: Rajendra Nayak<rnayak@ti.com>
>
> This patch generates quite a few checkpatch warnings:
>
> WARNING: please, no space before tabs
> #294: FILE: arch/arm/mach-omap2/clock3xxx_data.c:3479:
> +^ICLK(NULL, ^I"mcbsp4_ick",^I&mcbsp2_ick,^ICK_3XXX),$
>
> etc.
>
> Please fix these.
>
> The 80 column warnings from checkpatch on the CLK(... lines can be
> ignored.

Sorry, I seemed to have overlooked these thinking all to be 80 column
warnings. Will fix all the non 80 column warnings and repost.

regards,
Rajendra

>
>
> - Paul

  parent reply	other threads:[~2012-07-02  9:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-27  8:48 [PATCH v2 0/3] Prepare for OMAP2+ movement to Common Clk Rajendra Nayak
2012-06-27  8:48 ` [PATCH v2 1/3] ARM: omap: clk: add clk_prepare and clk_unprepare Rajendra Nayak
2012-06-29 20:19   ` Paul Walmsley
2012-06-29 20:20     ` Paul Walmsley
2012-07-02  9:47     ` Rajendra Nayak [this message]
2012-06-27  8:48 ` [PATCH v2 2/3] ARM: omap: hwmod: get rid of all omap_clk_get_by_name usage Rajendra Nayak
2012-06-29 20:22   ` Paul Walmsley
2012-06-27  8:48 ` [PATCH v2 3/3] ARM: omap: clk: Remove all direct dereferencing of struct clk Rajendra Nayak
2012-06-29 20:23   ` Paul Walmsley
2012-07-02  9:56     ` Rajendra Nayak
2012-07-02 10:22       ` Rajendra Nayak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FF16E41.8020906@ti.com \
    --to=rnayak@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).