public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: architected timers: Mark the clockevent with the C3_STOP feature
Date: Wed, 04 Jul 2012 10:56:54 +0100	[thread overview]
Message-ID: <4FF41366.4060504@arm.com> (raw)
In-Reply-To: <1341395673-29660-1-git-send-email-santosh.shilimkar@ti.com>

On 04/07/12 10:54, Santosh Shilimkar wrote:
> ARM arch timers stop in low power state and hence can not wakeup CPUs in
> deeper idle states when used as cloc event devices. Marking these clock event
> devices with C3_STOP so that during lowpower states, the tick is managed by
> wakeup capable broadcast timer.
> 
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>

Hi Santosh,

I already have queued an identical patch from Lorenzo.
Thanks for reminder anyway!

	M.

> ---
>  arch/arm/kernel/arch_timer.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/kernel/arch_timer.c b/arch/arm/kernel/arch_timer.c
> index dd58035..df44c8c 100644
> --- a/arch/arm/kernel/arch_timer.c
> +++ b/arch/arm/kernel/arch_timer.c
> @@ -137,7 +137,7 @@ static int __cpuinit arch_timer_setup(struct clock_event_device *clk)
>  	/* Be safe... */
>  	arch_timer_disable();
>  
> -	clk->features = CLOCK_EVT_FEAT_ONESHOT;
> +	clk->features = CLOCK_EVT_FEAT_ONESHOT | CLOCK_EVT_FEAT_C3STOP;
>  	clk->name = "arch_sys_timer";
>  	clk->rating = 450;
>  	clk->set_mode = arch_timer_set_mode;


-- 
Jazz is not dead. It just smells funny...

  reply	other threads:[~2012-07-04  9:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-04  9:54 [PATCH] ARM: architected timers: Mark the clockevent with the C3_STOP feature Santosh Shilimkar
2012-07-04  9:56 ` Marc Zyngier [this message]
2012-07-04 10:00   ` Shilimkar, Santosh
2012-07-04 10:26 ` Russell King - ARM Linux
2012-07-04 10:41   ` Shilimkar, Santosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FF41366.4060504@arm.com \
    --to=marc.zyngier@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox