From: hvaibhav@ti.com (Vaibhav Hiremath)
To: linux-arm-kernel@lists.infradead.org
Subject: How to handle parameter variation across different boards but same platform
Date: Thu, 5 Jul 2012 11:12:32 +0530 [thread overview]
Message-ID: <4FF52948.6090904@ti.com> (raw)
In-Reply-To: <20120704142745.GC4111@opensource.wolfsonmicro.com>
On 7/4/2012 7:57 PM, Mark Brown wrote:
> On Wed, Jul 04, 2012 at 02:17:48PM +0000, Hebbar, Gururaja wrote:
>> On Wed, Jul 04, 2012 at 19:31:18, Mark Brown wrote:
>
>>> If these are totally different boards they should have different machine
>>> IDs set so machine_is_() should identify. If that isn't there then you
>>> need to do something custom to your products to identify the boards
>>> further.
>
>> They are different boards with same SoC (AM33xx). So they both are true for
>> machine_is_am33xx().
>
What if the device only supports Linux boot from DT, where we set
machine_desc.nr = ~0 ??
Does machine ID still gets set? May be I am missing something...
As part of my debugging, on AM335xEVM platform machine_is_am33xx()
returns false, since the value of machine_desc.nr is set to ~0.
Thanks,
Vaibhav
> That's not how this stuff is supposed to work - machine is the board,
> you should have cpu_is_() for identifying the SoC.
>
>> We have a means to detect the type of board but in arch/arm/mach-omap2/
>> board file. However, I believe it is not recommended to call boards api
>> inside drivers.
>
> Only for generic drivers, board specific drivers are obviously board
> specific. The point is that you shouldn't make something that could run
> on many boards depend on an API specific to a particular board.
>
>
>
> _______________________________________________
> Davinci-linux-open-source mailing list
> Davinci-linux-open-source at linux.davincidsp.com
> http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
>
next prev parent reply other threads:[~2012-07-05 5:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-04 12:45 How to handle parameter variation across different boards but same platform Hebbar, Gururaja
2012-07-04 13:17 ` Mark Brown
2012-07-04 13:43 ` Hebbar, Gururaja
2012-07-04 14:01 ` Mark Brown
2012-07-04 14:17 ` Hebbar, Gururaja
2012-07-04 14:27 ` Mark Brown
2012-07-05 5:42 ` Vaibhav Hiremath [this message]
2012-07-05 8:32 ` Arnd Bergmann
2012-07-05 9:38 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF52948.6090904@ti.com \
--to=hvaibhav@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).