From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] mfd: Fix runtime warning caused by duplicate device registration
Date: Thu, 05 Jul 2012 08:36:38 +0100 [thread overview]
Message-ID: <4FF54406.3000307@linaro.org> (raw)
In-Reply-To: <20120703142123.GQ29030@opensource.wolfsonmicro.com>
On 03/07/12 15:21, Mark Brown wrote:
> On Tue, Jul 03, 2012 at 02:48:29PM +0100, Lee Jones wrote:
>> On 03/07/12 14:24, Mark Brown wrote:
>
>>> I'm really unconvinced that instnatiating the MFD cells from device tree
>>> is in general a good idea.
>
>> Well it just doesn't work the other way.
>
> In what way does it not work?
>
>>>> See c5395e7ed8f16cc7bb72a783de68659db5aed515 for a short description
>>>> of the troubles we faced.
>
>>> $ git show c5395e7ed8f16cc7bb72a783de68659db5aed515
>>> fatal: bad object c5395e7ed8f16cc7bb72a783de68659db5aed515
>
>> Sorry, looks live I've rebased since.
>
>> 5f3fc8adeec9bb12742fbfa777fa1947deda21a2
>
> This doesn't explain any of the issues, it just says that they exist.
> My best guess would be that at least some of the issue is due to
> instantiating the MFD cells from the device tree but it's hard to say
> clearly.
I'm guessing Arnd's email answered some of the questions you had. Let me
know of you would like me to explain it in any greater detail.
By the way, this patch has nothing to do with registering these devices
when DT is enabled. The code already does that. This is a bug fix, to
stop multiple registration of the ab8500 when DT is _not_ enabled.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
M: +44 77 88 633 515
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2012-07-05 7:36 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 11:59 [PATCH 1/1] mfd: Fix runtime warning caused by duplicate device registration Lee Jones
2012-07-03 12:35 ` Mark Brown
2012-07-03 13:07 ` Lee Jones
2012-07-03 13:24 ` Mark Brown
2012-07-03 13:48 ` Lee Jones
2012-07-03 14:21 ` Mark Brown
2012-07-05 7:36 ` Lee Jones [this message]
2012-07-05 9:45 ` Mark Brown
2012-07-05 11:46 ` Lee Jones
2012-07-05 12:06 ` Mark Brown
2012-07-05 12:15 ` Lee Jones
2012-07-05 12:29 ` Mark Brown
2012-07-05 12:41 ` Lee Jones
2012-07-05 12:45 ` Mark Brown
2012-07-05 12:55 ` Lee Jones
2012-07-05 13:03 ` Mark Brown
2012-07-05 13:12 ` Lee Jones
2012-07-05 13:20 ` Mark Brown
2012-07-05 13:54 ` Lee Jones
2012-07-05 13:57 ` Mark Brown
2012-07-05 14:06 ` Samuel Ortiz
2012-07-05 13:57 ` Arnd Bergmann
2012-07-05 14:04 ` Mark Brown
2012-07-05 14:06 ` Lee Jones
2012-07-05 14:13 ` Mark Brown
2012-07-05 14:35 ` Lee Jones
2012-07-05 15:41 ` Arnd Bergmann
2012-07-05 15:51 ` Lee Jones
2012-07-03 14:01 ` Arnd Bergmann
2012-07-03 14:43 ` Mark Brown
2012-07-05 7:33 ` Lee Jones
2012-07-05 13:08 ` Fabio Estevam
2012-07-05 13:13 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF54406.3000307@linaro.org \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).