* [PATCH 1/1] ARM: add PROC_DEVICETREE support in Kconfig
@ 2012-07-06 10:38 jgq516 at gmail.com
2012-07-06 11:28 ` Jean-Christophe PLAGNIOL-VILLARD
2012-07-06 12:40 ` Rob Herring
0 siblings, 2 replies; 6+ messages in thread
From: jgq516 at gmail.com @ 2012-07-06 10:38 UTC (permalink / raw)
To: linux-arm-kernel
From: Xiao Jiang <jgq516@gmail.com>
Since more and more arm chips support device tree, it'd be better add PROC_DEVICETREE
in arch/arm/Kconfig to avoid duplicate code.
Signed-off-by: Xiao Jiang <jgq516@gmail.com>
---
arch/arm/Kconfig | 1 +
arch/arm/configs/at91_dt_defconfig | 1 -
arch/arm/configs/tegra_defconfig | 1 -
arch/arm/plat-omap/Kconfig | 1 -
4 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index a91009c..f68896e 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1864,6 +1864,7 @@ config USE_OF
select OF
select OF_EARLY_FLATTREE
select IRQ_DOMAIN
+ select PROC_DEVICETREE if PROC_FS
help
Include support for flattened device tree machine descriptions.
diff --git a/arch/arm/configs/at91_dt_defconfig b/arch/arm/configs/at91_dt_defconfig
index 67bc571..b856cb6 100644
--- a/arch/arm/configs/at91_dt_defconfig
+++ b/arch/arm/configs/at91_dt_defconfig
@@ -64,7 +64,6 @@ CONFIG_MTD_NAND=y
CONFIG_MTD_NAND_ATMEL=y
CONFIG_MTD_UBI=y
CONFIG_MTD_UBI_GLUEBI=y
-CONFIG_PROC_DEVICETREE=y
CONFIG_BLK_DEV_LOOP=y
CONFIG_BLK_DEV_RAM=y
CONFIG_BLK_DEV_RAM_COUNT=4
diff --git a/arch/arm/configs/tegra_defconfig b/arch/arm/configs/tegra_defconfig
index 1198dd6..43e7b65 100644
--- a/arch/arm/configs/tegra_defconfig
+++ b/arch/arm/configs/tegra_defconfig
@@ -72,7 +72,6 @@ CONFIG_IPV6_TUNNEL=y
CONFIG_IPV6_MULTIPLE_TABLES=y
# CONFIG_WIRELESS is not set
# CONFIG_FIRMWARE_IN_KERNEL is not set
-CONFIG_PROC_DEVICETREE=y
CONFIG_BLK_DEV_LOOP=y
CONFIG_AD525X_DPOT=y
CONFIG_AD525X_DPOT_I2C=y
diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
index ad95c7a..4e2cb17 100644
--- a/arch/arm/plat-omap/Kconfig
+++ b/arch/arm/plat-omap/Kconfig
@@ -27,7 +27,6 @@ config ARCH_OMAP2PLUS
select GENERIC_IRQ_CHIP
select OMAP_DM_TIMER
select USE_OF
- select PROC_DEVICETREE if PROC_FS
help
"Systems based on OMAP2, OMAP3 or OMAP4"
--
1.7.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 1/1] ARM: add PROC_DEVICETREE support in Kconfig
2012-07-06 10:38 [PATCH 1/1] ARM: add PROC_DEVICETREE support in Kconfig jgq516 at gmail.com
@ 2012-07-06 11:28 ` Jean-Christophe PLAGNIOL-VILLARD
2012-07-06 12:40 ` Rob Herring
1 sibling, 0 replies; 6+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2012-07-06 11:28 UTC (permalink / raw)
To: linux-arm-kernel
On 18:38 Fri 06 Jul , jgq516 at gmail.com wrote:
> From: Xiao Jiang <jgq516@gmail.com>
>
> Since more and more arm chips support device tree, it'd be better add PROC_DEVICETREE
> in arch/arm/Kconfig to avoid duplicate code.
>
Acked-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Best Regards,
J.
> Signed-off-by: Xiao Jiang <jgq516@gmail.com>
> ---
> arch/arm/Kconfig | 1 +
> arch/arm/configs/at91_dt_defconfig | 1 -
> arch/arm/configs/tegra_defconfig | 1 -
> arch/arm/plat-omap/Kconfig | 1 -
> 4 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index a91009c..f68896e 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1864,6 +1864,7 @@ config USE_OF
> select OF
> select OF_EARLY_FLATTREE
> select IRQ_DOMAIN
> + select PROC_DEVICETREE if PROC_FS
> help
> Include support for flattened device tree machine descriptions.
>
> diff --git a/arch/arm/configs/at91_dt_defconfig b/arch/arm/configs/at91_dt_defconfig
> index 67bc571..b856cb6 100644
> --- a/arch/arm/configs/at91_dt_defconfig
> +++ b/arch/arm/configs/at91_dt_defconfig
> @@ -64,7 +64,6 @@ CONFIG_MTD_NAND=y
> CONFIG_MTD_NAND_ATMEL=y
> CONFIG_MTD_UBI=y
> CONFIG_MTD_UBI_GLUEBI=y
> -CONFIG_PROC_DEVICETREE=y
> CONFIG_BLK_DEV_LOOP=y
> CONFIG_BLK_DEV_RAM=y
> CONFIG_BLK_DEV_RAM_COUNT=4
> diff --git a/arch/arm/configs/tegra_defconfig b/arch/arm/configs/tegra_defconfig
> index 1198dd6..43e7b65 100644
> --- a/arch/arm/configs/tegra_defconfig
> +++ b/arch/arm/configs/tegra_defconfig
> @@ -72,7 +72,6 @@ CONFIG_IPV6_TUNNEL=y
> CONFIG_IPV6_MULTIPLE_TABLES=y
> # CONFIG_WIRELESS is not set
> # CONFIG_FIRMWARE_IN_KERNEL is not set
> -CONFIG_PROC_DEVICETREE=y
> CONFIG_BLK_DEV_LOOP=y
> CONFIG_AD525X_DPOT=y
> CONFIG_AD525X_DPOT_I2C=y
> diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
> index ad95c7a..4e2cb17 100644
> --- a/arch/arm/plat-omap/Kconfig
> +++ b/arch/arm/plat-omap/Kconfig
> @@ -27,7 +27,6 @@ config ARCH_OMAP2PLUS
> select GENERIC_IRQ_CHIP
> select OMAP_DM_TIMER
> select USE_OF
> - select PROC_DEVICETREE if PROC_FS
> help
> "Systems based on OMAP2, OMAP3 or OMAP4"
>
> --
> 1.7.3
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] ARM: add PROC_DEVICETREE support in Kconfig
2012-07-06 10:38 [PATCH 1/1] ARM: add PROC_DEVICETREE support in Kconfig jgq516 at gmail.com
2012-07-06 11:28 ` Jean-Christophe PLAGNIOL-VILLARD
@ 2012-07-06 12:40 ` Rob Herring
2012-07-06 23:15 ` Xiao Jiang
1 sibling, 1 reply; 6+ messages in thread
From: Rob Herring @ 2012-07-06 12:40 UTC (permalink / raw)
To: linux-arm-kernel
On 07/06/2012 05:38 AM, jgq516 at gmail.com wrote:
> From: Xiao Jiang <jgq516@gmail.com>
>
> Since more and more arm chips support device tree, it'd be better add PROC_DEVICETREE
> in arch/arm/Kconfig to avoid duplicate code.
I think this should remain user choice. If its going to be selected,
then you might as well just remove the option altogether. Perhaps just
make the option default to yes.
Rob
> Signed-off-by: Xiao Jiang <jgq516@gmail.com>
> ---
> arch/arm/Kconfig | 1 +
> arch/arm/configs/at91_dt_defconfig | 1 -
> arch/arm/configs/tegra_defconfig | 1 -
> arch/arm/plat-omap/Kconfig | 1 -
> 4 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index a91009c..f68896e 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1864,6 +1864,7 @@ config USE_OF
> select OF
> select OF_EARLY_FLATTREE
> select IRQ_DOMAIN
> + select PROC_DEVICETREE if PROC_FS
> help
> Include support for flattened device tree machine descriptions.
>
> diff --git a/arch/arm/configs/at91_dt_defconfig b/arch/arm/configs/at91_dt_defconfig
> index 67bc571..b856cb6 100644
> --- a/arch/arm/configs/at91_dt_defconfig
> +++ b/arch/arm/configs/at91_dt_defconfig
> @@ -64,7 +64,6 @@ CONFIG_MTD_NAND=y
> CONFIG_MTD_NAND_ATMEL=y
> CONFIG_MTD_UBI=y
> CONFIG_MTD_UBI_GLUEBI=y
> -CONFIG_PROC_DEVICETREE=y
> CONFIG_BLK_DEV_LOOP=y
> CONFIG_BLK_DEV_RAM=y
> CONFIG_BLK_DEV_RAM_COUNT=4
> diff --git a/arch/arm/configs/tegra_defconfig b/arch/arm/configs/tegra_defconfig
> index 1198dd6..43e7b65 100644
> --- a/arch/arm/configs/tegra_defconfig
> +++ b/arch/arm/configs/tegra_defconfig
> @@ -72,7 +72,6 @@ CONFIG_IPV6_TUNNEL=y
> CONFIG_IPV6_MULTIPLE_TABLES=y
> # CONFIG_WIRELESS is not set
> # CONFIG_FIRMWARE_IN_KERNEL is not set
> -CONFIG_PROC_DEVICETREE=y
> CONFIG_BLK_DEV_LOOP=y
> CONFIG_AD525X_DPOT=y
> CONFIG_AD525X_DPOT_I2C=y
> diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
> index ad95c7a..4e2cb17 100644
> --- a/arch/arm/plat-omap/Kconfig
> +++ b/arch/arm/plat-omap/Kconfig
> @@ -27,7 +27,6 @@ config ARCH_OMAP2PLUS
> select GENERIC_IRQ_CHIP
> select OMAP_DM_TIMER
> select USE_OF
> - select PROC_DEVICETREE if PROC_FS
> help
> "Systems based on OMAP2, OMAP3 or OMAP4"
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] ARM: add PROC_DEVICETREE support in Kconfig
2012-07-06 12:40 ` Rob Herring
@ 2012-07-06 23:15 ` Xiao Jiang
2012-07-06 23:24 ` Olof Johansson
0 siblings, 1 reply; 6+ messages in thread
From: Xiao Jiang @ 2012-07-06 23:15 UTC (permalink / raw)
To: linux-arm-kernel
2012/7/6 Rob Herring <robherring2@gmail.com>
> On 07/06/2012 05:38 AM, jgq516 at gmail.com wrote:
> > From: Xiao Jiang <jgq516@gmail.com>
> >
> > Since more and more arm chips support device tree, it'd be better add
> PROC_DEVICETREE
> > in arch/arm/Kconfig to avoid duplicate code.
>
> I think this should remain user choice. If its going to be selected,
> then you might as well just remove the option altogether. Perhaps just
> make the option default to yes.
>
> Hmm, sounds reasonable from your point. So the better choice is to set the
option default to Y if the board has dt support just like tegra_defconfig
and at91_dt_defconfig, right? thanks.
Regards,
Xiao
Rob
>
> > Signed-off-by: Xiao Jiang <jgq516@gmail.com>
> > ---
> > arch/arm/Kconfig | 1 +
> > arch/arm/configs/at91_dt_defconfig | 1 -
> > arch/arm/configs/tegra_defconfig | 1 -
> > arch/arm/plat-omap/Kconfig | 1 -
> > 4 files changed, 1 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> > index a91009c..f68896e 100644
> > --- a/arch/arm/Kconfig
> > +++ b/arch/arm/Kconfig
> > @@ -1864,6 +1864,7 @@ config USE_OF
> > select OF
> > select OF_EARLY_FLATTREE
> > select IRQ_DOMAIN
> > + select PROC_DEVICETREE if PROC_FS
> > help
> > Include support for flattened device tree machine descriptions.
> >
> > diff --git a/arch/arm/configs/at91_dt_defconfig
> b/arch/arm/configs/at91_dt_defconfig
> > index 67bc571..b856cb6 100644
> > --- a/arch/arm/configs/at91_dt_defconfig
> > +++ b/arch/arm/configs/at91_dt_defconfig
> > @@ -64,7 +64,6 @@ CONFIG_MTD_NAND=y
> > CONFIG_MTD_NAND_ATMEL=y
> > CONFIG_MTD_UBI=y
> > CONFIG_MTD_UBI_GLUEBI=y
> > -CONFIG_PROC_DEVICETREE=y
> > CONFIG_BLK_DEV_LOOP=y
> > CONFIG_BLK_DEV_RAM=y
> > CONFIG_BLK_DEV_RAM_COUNT=4
> > diff --git a/arch/arm/configs/tegra_defconfig
> b/arch/arm/configs/tegra_defconfig
> > index 1198dd6..43e7b65 100644
> > --- a/arch/arm/configs/tegra_defconfig
> > +++ b/arch/arm/configs/tegra_defconfig
> > @@ -72,7 +72,6 @@ CONFIG_IPV6_TUNNEL=y
> > CONFIG_IPV6_MULTIPLE_TABLES=y
> > # CONFIG_WIRELESS is not set
> > # CONFIG_FIRMWARE_IN_KERNEL is not set
> > -CONFIG_PROC_DEVICETREE=y
> > CONFIG_BLK_DEV_LOOP=y
> > CONFIG_AD525X_DPOT=y
> > CONFIG_AD525X_DPOT_I2C=y
> > diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
> > index ad95c7a..4e2cb17 100644
> > --- a/arch/arm/plat-omap/Kconfig
> > +++ b/arch/arm/plat-omap/Kconfig
> > @@ -27,7 +27,6 @@ config ARCH_OMAP2PLUS
> > select GENERIC_IRQ_CHIP
> > select OMAP_DM_TIMER
> > select USE_OF
> > - select PROC_DEVICETREE if PROC_FS
> > help
> > "Systems based on OMAP2, OMAP3 or OMAP4"
> >
> >
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120707/d56f2dbc/attachment-0001.html>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] ARM: add PROC_DEVICETREE support in Kconfig
2012-07-06 23:15 ` Xiao Jiang
@ 2012-07-06 23:24 ` Olof Johansson
2012-07-07 0:10 ` Xiao Jiang
0 siblings, 1 reply; 6+ messages in thread
From: Olof Johansson @ 2012-07-06 23:24 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jul 6, 2012 at 4:15 PM, Xiao Jiang <jgq516@gmail.com> wrote:
> 2012/7/6 Rob Herring <robherring2@gmail.com>
>>
>> On 07/06/2012 05:38 AM, jgq516 at gmail.com wrote:
>> > From: Xiao Jiang <jgq516@gmail.com>
>> >
>> > Since more and more arm chips support device tree, it'd be better add
>> > PROC_DEVICETREE
>> > in arch/arm/Kconfig to avoid duplicate code.
>>
>> I think this should remain user choice. If its going to be selected,
>> then you might as well just remove the option altogether. Perhaps just
>> make the option default to yes.
>>
> Hmm, sounds reasonable from your point. So the better choice is to set the
> option default to Y if the board has dt support just like tegra_defconfig
> and at91_dt_defconfig, right? thanks.
Why bother? If the defconfigs select it then most users basing their
config from that will be just fine.
PROC_DEVICETREE is 100% optional, it's useful to get runtime access to
the contents of the device tree but it's not required for the kernel
to boot.
-Olof
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] ARM: add PROC_DEVICETREE support in Kconfig
2012-07-06 23:24 ` Olof Johansson
@ 2012-07-07 0:10 ` Xiao Jiang
0 siblings, 0 replies; 6+ messages in thread
From: Xiao Jiang @ 2012-07-07 0:10 UTC (permalink / raw)
To: linux-arm-kernel
2012/7/7 Olof Johansson <olof@lixom.net>
> On Fri, Jul 6, 2012 at 4:15 PM, Xiao Jiang <jgq516@gmail.com> wrote:
> > 2012/7/6 Rob Herring <robherring2@gmail.com>
> >>
> >> On 07/06/2012 05:38 AM, jgq516 at gmail.com wrote:
> >> > From: Xiao Jiang <jgq516@gmail.com>
> >> >
> >> > Since more and more arm chips support device tree, it'd be better add
> >> > PROC_DEVICETREE
> >> > in arch/arm/Kconfig to avoid duplicate code.
> >>
> >> I think this should remain user choice. If its going to be selected,
> >> then you might as well just remove the option altogether. Perhaps just
> >> make the option default to yes.
> >>
> > Hmm, sounds reasonable from your point. So the better choice is to set
> the
> > option default to Y if the board has dt support just like tegra_defconfig
> > and at91_dt_defconfig, right? thanks.
>
> Why bother? If the defconfigs select it then most users basing their
> config from that will be just fine.
>
> PROC_DEVICETREE is 100% optional, it's useful to get runtime access to
> the contents of the device tree but it's not required for the kernel
> to boot.
>
> Got it, thanks.
Regards,
Xiao
>
> -Olof
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120707/e1b4c8b6/attachment-0001.html>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-07-07 0:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-06 10:38 [PATCH 1/1] ARM: add PROC_DEVICETREE support in Kconfig jgq516 at gmail.com
2012-07-06 11:28 ` Jean-Christophe PLAGNIOL-VILLARD
2012-07-06 12:40 ` Rob Herring
2012-07-06 23:15 ` Xiao Jiang
2012-07-06 23:24 ` Olof Johansson
2012-07-07 0:10 ` Xiao Jiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).