linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: shinya.kuribayashi.px@renesas.com (Shinya Kuribayashi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/3] hwspinlock: a bug fix, trivial changes
Date: Mon, 09 Jul 2012 09:41:27 +0900	[thread overview]
Message-ID: <4FFA28B7.9090705@renesas.com> (raw)
In-Reply-To: <CAK=WgbYgVoB+B3P6NLpd2t=F9PVA_m7Nbou4k1aq8BGvjJhvNg@mail.gmail.com>

Hi,

On 7/7/2012 7:59 PM, Ohad Ben-Cohen wrote:
>> Recently I wrote a hwspinlock driver for our devices
> 
> Great! looking forward to see it :)

Unfortunately I'm not planning to submit that driver at the moment,
as I'm 120% sure that it won't be utilized by any module in our BSPs
in the mainline kernel.

>> and during
>> the review and debug process, we found a bug in the core code.
>> Could you take a look please?
> 
> I looked and it's great. Will send to Linus soon.

Thanks for fixing up the error path I msised.

>> The first patch is a bug fix.  The latter two patches are what I
>> think nice-to-have.  If you find useful, just take it, thanks!
> 
> I commented on the latter two (generally both look ok sans a small
> outstanding comment).

Thanks, but I don't mind you dropping the latter two, either.  If I
have a chance to revisit hwspinlock drivers, I'll go through patches
again with your comments in mind.

-- 
Shinya Kuribayashi
Renesas Electronics

      reply	other threads:[~2012-07-09  0:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-06  4:55 [PATCH 0/3] hwspinlock: a bug fix, trivial changes Shinya Kuribayashi
2012-07-06  4:56 ` [PATCH 1/3] hwspinlock/core: use global ID to register hwspinlocks on multiple devices Shinya Kuribayashi
2012-07-07 10:49   ` Ohad Ben-Cohen
2012-07-06  4:56 ` [PATCH 2/3] hwspinlock/core: add notes on lock element in 'struct hwspinlock' Shinya Kuribayashi
2012-07-07 10:53   ` Ohad Ben-Cohen
2012-07-06  4:56 ` [PATCH 3/3] hwspinlock/core: allow hwspinlock_device to have bank-specific private data Shinya Kuribayashi
2012-07-07 10:55   ` Ohad Ben-Cohen
2012-07-07 10:59 ` [PATCH 0/3] hwspinlock: a bug fix, trivial changes Ohad Ben-Cohen
2012-07-09  0:41   ` Shinya Kuribayashi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FFA28B7.9090705@renesas.com \
    --to=shinya.kuribayashi.px@renesas.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).