From mboxrd@z Thu Jan 1 00:00:00 1970 From: vipulkumar.samar@st.com (vipul kumar samar) Date: Fri, 13 Jul 2012 13:48:53 +0530 Subject: [PATCH 1/4] clk:spear1340:Fix: Rename clk ids within predefined limit In-Reply-To: References: Message-ID: <4FFFD9ED.30606@st.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 7/13/2012 1:36 PM, viresh kumar wrote: > On Fri, Jul 13, 2012 at 7:23 AM, Vipul Kumar Samar > wrote: >> The max limit of con_id is 16 and dev_id is 20. As of now for spear1340, many >> clk ids are exceeding this predefined limit. >> >> diff --git a/drivers/clk/spear/spear1340_clock.c b/drivers/clk/spear/spear1340_clock.c > >> @@ -509,23 +507,23 @@ void __init spear1340_clk_init(void) > >> - clk_register_clkdev(clk1, "uart0_synth_gate_clk", NULL); > >> - clk_register_clkdev(clk1, "sdhci_synth_gate_clk", NULL); > >> - clk_register_clkdev(clk, "gmac_phy_input_mux_clk", NULL); >> - clk_register_clkdev(clk1, "gmac_phy_synth_gate_clk", NULL); > > These are the only places in this entire patch, where i found con_id > crossing the limit. > Then why so many changes? Aligning all to similar naming? Not only for gmac some other ips also like sdhi_synth_gate_clk, uart1_synth_gate_clk, clcd_synth_mux_clk etc. yes, to align all other gate, synth and mux clocks with similar naming. > > >> clk_register_clkdev(clk, NULL, "e0000000.serial"); > > @Russell& Mike: Above line uses maximum length of dev_id, i.e. 16. > And because with DT we have so long device names now, out of which > 8 - address > 1 - '.' > 1 - '\0' > > 10 are already gone and so only 6 are left for device name. Should we > consider updating > dev_id array size?? dev_id is 20 and con_id is 16 Regards Vipul Samar