From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Amjad Ouled-Ameur <aouledameur@baylibre.com>,
neil.armstrong@linaro.org, Mark Brown <broonie@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Kevin Hilman <khilman@baylibre.com>,
Rob Herring <robh+dt@kernel.org>
Cc: Da Xue <da@libre.computer>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-amlogic@lists.infradead.org, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] spi: dt-bindings: amlogic, meson-gx-spicc: Add pinctrl names for SPI signal states
Date: Fri, 21 Oct 2022 08:59:46 -0400 [thread overview]
Message-ID: <4a0b2e54-e13c-d6e8-261a-a282f35c1a30@linaro.org> (raw)
In-Reply-To: <df1895c8-aec6-cada-e208-ccda8042860d@baylibre.com>
On 21/10/2022 08:54, Amjad Ouled-Ameur wrote:
> Hi
>
> On 10/20/22 14:49, Krzysztof Kozlowski wrote:
>>>>> + properties:
>>>>> + pinctrl-names:
>>>>> + minItems: 1
>>>>> + items:
>>>>> + - const: default
>>>>> + - const: idle-high
>>>>> + - const: idle-low
>>>> You should also define in such case pinctrl-0 and others.
>>> Ok I thought it would be covered by the pinctrl-consumer.yaml
>>> but yeah we should allow pinctrl-1 and pinctrl-2 here aswell by adding:
>>>
>>> pinctrl-1: true
>>> pinctrl-2: true
>>>
>>>
> In such case, should I define pinctrl- as part of the if statement, as shown below,
>
> or before allOf ?
The same as pinctrl-names, so part of allOf.
>
> [...]
>
> - if:
> properties:
> compatible:
> contains:
> enum:
> - amlogic,meson-gx-spicc
>
> then:
> properties:
> pinctrl-0: true
> pinctrl-1: true
> pinctrl-2: true
>
> pinctrl-names:
> minItems: 1
> items:
> - const: default
> - const: idle-high
> - const: idle-low
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-21 13:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 14:01 [PATCH v3 0/2] spi: amlogic: meson-spicc: Use pinctrl to drive CLK line when idle Amjad Ouled-Ameur
2022-10-19 14:01 ` [PATCH v3 1/2] spi: dt-bindings: amlogic, meson-gx-spicc: Add pinctrl names for SPI signal states Amjad Ouled-Ameur
2022-10-19 14:29 ` Krzysztof Kozlowski
2022-10-19 16:53 ` Neil Armstrong
2022-10-20 12:49 ` Krzysztof Kozlowski
2022-10-21 12:54 ` Amjad Ouled-Ameur
2022-10-21 12:59 ` Krzysztof Kozlowski [this message]
2022-10-19 23:31 ` Rob Herring
2022-10-19 14:01 ` [PATCH v3 2/2] spi: meson-spicc: Use pinctrl to drive CLK line when idle Amjad Ouled-Ameur
2022-10-19 20:50 ` Martin Blumenstingl
2022-10-20 8:18 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a0b2e54-e13c-d6e8-261a-a282f35c1a30@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=aouledameur@baylibre.com \
--cc=broonie@kernel.org \
--cc=da@libre.computer \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).