From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EE5AC433C1 for ; Thu, 25 Mar 2021 15:17:40 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85C9961A16 for ; Thu, 25 Mar 2021 15:17:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85C9961A16 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5GjVt7w/oIqL+z2/ymFdXJLxc4u+wC204sZgiqUOvX8=; b=qNMNZQQt/H8niq2YgrPQvefb4 PhqJPwUW984M9mg1s9YmZdMmjauF9VFHpZhTmhHm1QhlzoHklAGTNiDGBnXRV9fsCfELvHuIXVeDR 7CoFhc/u3yP7lZH6rdZDoitapZLUQFhv/a05O1nuHvseUUy983YmgWTvP9vAB2d58+KXr1Rq3Eq/5 vpFMpOD1wIJv9kB7wmo4M2IuaSDhUIxbrdinNfA3U4ON0tpa8YRbrEjzxpT6NXWZaVhp8ZAW+oSqR 2oHPPEfJQ+/ggFd9//Yfa3U6LBYqtH2x6i+JVcC2rwT/bau6zTClHJYxr1TZ0+MKgbfYc/UNsTFlT 4WQuyHTGA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lPRiH-001hRi-IA; Thu, 25 Mar 2021 15:15:57 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lPRhy-001hNv-TH for linux-arm-kernel@lists.infradead.org; Thu, 25 Mar 2021 15:15:43 +0000 Received: from fraeml736-chm.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4F5pQz6Bwvz6826l; Thu, 25 Mar 2021 23:08:59 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml736-chm.china.huawei.com (10.206.15.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 25 Mar 2021 16:15:31 +0100 Received: from [10.47.5.170] (10.47.5.170) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 25 Mar 2021 15:15:30 +0000 Subject: Re: [RFC PATCH 1/2] {topost} drivers/perf: hisi: Add description for HNS3 PMU driver To: Guangbin Huang , , CC: , , , , , , , References: <1616377787-1550-1-git-send-email-huangguangbin2@huawei.com> <1616377787-1550-2-git-send-email-huangguangbin2@huawei.com> From: John Garry Message-ID: <4a184ed1-4b07-bca5-bf12-10aef723f53f@huawei.com> Date: Thu, 25 Mar 2021 15:13:14 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <1616377787-1550-2-git-send-email-huangguangbin2@huawei.com> Content-Language: en-US X-Originating-IP: [10.47.5.170] X-ClientProxiedBy: lhreml753-chm.china.huawei.com (10.201.108.203) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210325_151540_207732_41B0B4CA X-CRM114-Status: GOOD ( 28.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 22/03/2021 01:49, Guangbin Huang wrote: please remove {topost} next time > HNS3 PMU End Point device is supported on HiSilicon HIP09 platform, so > add document hns3-pmu.rst to provide guidance on how to use it. > sorry, I didn't do much review of this before sending out... > Signed-off-by: Guangbin Huang > --- > Documentation/admin-guide/perf/hns3-pmu.rst | 125 ++++++++++++++++++++++++++++ > 1 file changed, 125 insertions(+) > create mode 100644 Documentation/admin-guide/perf/hns3-pmu.rst > > diff --git a/Documentation/admin-guide/perf/hns3-pmu.rst b/Documentation/admin-guide/perf/hns3-pmu.rst > new file mode 100644 > index 0000000..3597a8e > --- /dev/null > +++ b/Documentation/admin-guide/perf/hns3-pmu.rst > @@ -0,0 +1,125 @@ > +====================================== > +HNS3 Performance Monitoring Unit (PMU) > +====================================== > + > +HNS3(HiSilicon network system 3) Performance Monitoring Unit (PMU) is an > +End Point device to collect performance statistics of HiSilicon SoC NIC. > +On Hip09, each SICL has one PMU device. Even though the hisi-pmu doc now mentions what is SICL, it is also better mention here what it is. > + > +HNS3 PMU is supported to collect performance statistics of bandwidth, > +latency, packet rate and interrupt rate. > + > +Each HNS3 PMU supports up to 8 hardware events. > + > +HNS3 PMU driver > +=============== > + > +The HNS3 PMU driver registers a perf PMU with the name of its device id.:: > + > + /sys/devices/hns3_pmu_ any reason for which sicl is not used in the same? How is a anyone supposed to know which device hns3_pmu_0 - for example - is ? > + > +PMU driver provides description of available events, filter modes, format, > +identifier and cpumask in sysfs. > + > +The "events" directory describes the event code and subevent code of all > +supported events shown in perf list. > + > +The "filtermode" directory describes the supported filter modes of each > +event. > + > +The "format" directory describes all formats of the config (events) and > +config1 (filter options) fields of the perf_event_attr structure. > + > +The "identifier" file shows version of PMU hardware device. > + > +The "cpumask" file shows which CPU is PMU driver running on. isn't that really the CPUs associated with that PMU? > + > +Example usage of checking event code and subevent code:: > + > + $# cat /sys/devices/hns3_pmu_0/events/bw_igu_ssu > + event=0x0, subevent=0x0 as below > + > +Example usage of checking supported filter mode:: > + > + $# cat /sys/devices/hns3_pmu_0/filtermode/bw_igu_ssu > + filter mode supported: global/port/port-tc/ A sysfs file should just hold a single value is a basic rule > + > +Example usage of perf:: > + > + $# perf list > + hns3_pmu_0/bw_igu_ssu/ [kernel PMU event] > + ------------------------------------------ > + > + $# perf stat -a -e hns3_pmu_0/bw_igu_ssu,global=1/ -I 1000 > + or > + $# perf stat -a -e hns3_pmu_0/event=0,subevent=0,global=1/ -I 1000 > + > +The current driver does not support sampling. So "perf record" is unsupported. > +Also attach to a task is unsupported for HNS3 PMU. > + > +Filter modes > +-------------- > + > +1. global mode > +PMU collect performance statistic of all functions of IO DIE. Set the > +"global" filter option to 1 will enable this mode. > +Example usage of perf:: > + > + $# perf stat -a -e hns3_pmu_0/event=0,subevent=0,global=1/ -I 1000 > + > +2. port mode > +PMU collect performance statistic of one whole physical port. The port id > +is same as mac id. The "tc" filter option must be set to 0xF in this mode. > +Example usage of perf:: > + > + $# perf stat -a -e hns3_pmu_0/event=0,subevent=0,port=0,tc=0xF/ -I 1000 > + > +3. port-tc mode > +PMU collect performance statistic of one tc of physical port. The port id > +is same as mac id. The "tc" filter option must be set to 0 ~ 7 in this > +mode. > +Example usage of perf:: > + > + $# perf stat -a -e hns3_pmu_0/event=0,subevent=0,port=0,tc=0/ -I 1000 > + > +4. func mode > +PMU collect performance statistic of one PF/VF. The function id is BDF of > +PF/VF, its conversion formula:: > + > + func = (bus << 8) + (device << 3) + (function) > + > +for example: > + BDF func > + 35:00.0 0x3500 > + 35:00.1 0x3501 > + 35:01.0 0x3508 any reason why we can't have each nibble holding a digit of BDF? 0x3508 look strange > + > +In this mode, the "queue" filter option must be set to 0xFFFF. > +Example usage of perf:: > + > + $# perf stat -a -e hns3_pmu_0/event=0,subevent=0,func=0x3500,queue=0xFFFF/ -I 1000 > + > +5. func-queue mode > +PMU collect performance statistic of one queue of PF/VF. The function id > +is BDF of PF/VF, its conversion formula:: > + > + func = (bus << 8) + (device << 3) + (function) > + > +In this mode, the "queue" filter option must be set to the exact queue id > +of function. > +Example usage of perf:: > + > + $# perf stat -a -e hns3_pmu_0/event=0,subevent=0,func=0x3500,queue=0/ -I 1000 > + To me it's odd that the difference between func mode and func-queue mode is just setting the queue=0xffff or queue=0 - seems to be just the same mode with a different queue option > + > +6. func-intr mode > +PMU collect performance statistic of one interrupt of PF/VF. The function > +id is BDF of PF/VF, its conversion formula:: > + > + func = (bus << 8) + (device << 3) + (function) > + > +In this mode, the "intr" filter option must be set to the exact interrupt > +id of function. > +Example usage of perf:: > + > + $# perf stat -a -e hns3_pmu_0/event=0,subevent=0,func=0x3500,intr=0/ -I 1000 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel