Re: [PATCH v5 04/11] media: dt-bindings: media: add bindings for rockchip mipi csi host

Krzysztof Kozlowski
2025-03-07T07:55:30Z

On Thu, Mar 06, 2025 at 05:56:05PM +0100, Michael Riesch wrote:
> Add documentation for the Rockchip RK3568 MIPI CSI-2 Host unit.
>
> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
> ---
> .../bindings/media/rockchip,rk3568-mipi-csi.yaml | 114 +++++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 115 insertions(+)
>

Same comments about subject.

> diff --git a/Documentation/devicetree/bindings/media/rockchip,rk3568-mipi-csi.yaml b/Documentation/devicetree/bindings/media/rockchip,rk3568-mipi-csi.yaml
> new file mode 100644
> index 000000000000..900f5a32dab9
> --- /dev/null

...

> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/rk3568-cru.h>
> + #include <dt-bindings/power/rk3568-power.h>
> +
> + parent {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + csi: csi@fdfb0000 {
> + compatible = "rockchip,rk3568-mipi-csi";
> + reg = <0x0 0xfdfb0000 0x0 0x10000>;
> + clocks = <&cru PCLK_CSI2HOST1>;
> + phys = <&csi_dphy>;
> + power-domains = <&power RK3568_PD_VI>;
> + resets = <&cru SRST_P_CSI2HOST1>;
> + status = "disabled";

Drop

> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;

Best regards,
Krzysztof