From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA76BC4332F for ; Mon, 21 Nov 2022 15:27:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DwyvTU2e5m5+LAmc+MSeV2TIrfMA0BI2IaZMILKo4Ys=; b=Kalgt/71R1aMz4 tSI/OO6DTOu1Dtc7MrahP7lnbvQSQVW/lLiMo79W/19sCAO2PbhEFl1+BfMQs7QbQ/xnnB8F+jpVf M/tBZsF2YK0PciB2v/WVLbxdywVjND57WR77EkRyZUza75MdSZ5bTUNqyzYsZBUypMaitJCJZ7GYr ps8+VYJbsenUkS39MeD1WkEBEfEvPRzlvcEsfak1p3Estlp+UGHnUFWt2Qw+CsT/YlDcMxU60sn+l 1Hr/3M27VZd+1VdChXqCQVLACXjLPyLLU2KymixaBpoZFl+oBYMEOnAlPp0rKHgwhl3x9LN+qzkIc exSDCbmdaxnkPaOZDNKQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ox8gR-00FABS-SE; Mon, 21 Nov 2022 15:26:08 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ox8Uc-00F3Ey-P7 for linux-arm-kernel@lists.infradead.org; Mon, 21 Nov 2022 15:13:58 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 34DF91FB; Mon, 21 Nov 2022 07:13:54 -0800 (PST) Received: from [10.57.71.118] (unknown [10.57.71.118]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DF31F3F73B; Mon, 21 Nov 2022 07:13:43 -0800 (PST) Message-ID: <4a2836d6-3088-c513-7541-be7c8a0464a5@arm.com> Date: Mon, 21 Nov 2022 15:13:38 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [patch V2 02/40] ACPI/IORT: Make prototype of iort_pmsi_get_dev_id() always available Content-Language: en-GB To: Thomas Gleixner , LKML Cc: Will Deacon , linux-pci@vger.kernel.org, Bjorn Helgaas , Marc Zyngier , Greg Kroah-Hartman , Jason Gunthorpe , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Ammar Faizi , Lorenzo Pieralisi , Nishanth Menon , Tero Kristo , Santosh Shilimkar , linux-arm-kernel@lists.infradead.org, Vinod Koul , Sinan Kaya , Andy Gross , Bjorn Andersson , Mark Rutland , Shameerali Kolothum Thodi , Zenghui Yu , Shawn Guo , Sascha Hauer , Fabio Estevam , Lorenzo Pieralisi References: <20221121135653.208611233@linutronix.de> <20221121140048.408064684@linutronix.de> From: Robin Murphy In-Reply-To: <20221121140048.408064684@linutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221121_071354_958054_E35A897D X-CRM114-Status: GOOD ( 12.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022-11-21 14:39, Thomas Gleixner wrote: > W=1 build complains: > > drivers/irqchip/irq-gic-v3-its-msi-parent.c:110:12: warning: no previous prototype for function 'iort_pmsi_get_dev_id' [-Wmissing-prototypes] > int __weak iort_pmsi_get_dev_id(struct device *dev, u32 *dev_id) > > Reported-by: Ammar Faizi > Signed-off-by: Thomas Gleixner > Cc: Robin Murphy > Cc: Lorenzo Pieralisi > --- > include/linux/acpi_iort.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > --- a/include/linux/acpi_iort.h > +++ b/include/linux/acpi_iort.h > @@ -26,13 +26,15 @@ int iort_register_domain_token(int trans > struct fwnode_handle *fw_node); > void iort_deregister_domain_token(int trans_id); > struct fwnode_handle *iort_find_domain_token(int trans_id); > + > +int iort_pmsi_get_dev_id(struct device *dev, u32 *dev_id); > + > #ifdef CONFIG_ACPI_IORT > void acpi_iort_init(void); > u32 iort_msi_map_id(struct device *dev, u32 id); > struct irq_domain *iort_get_device_domain(struct device *dev, u32 id, > enum irq_domain_bus_token bus_token); > void acpi_configure_pmsi_domain(struct device *dev); > -int iort_pmsi_get_dev_id(struct device *dev, u32 *dev_id); FWIW I'd prefer to add a "return -ENODEV" stub in the #else section to match the others. Oh hey, then we could also finally make good on that 6-year-old promise that "The weak function will be removed when the ACPI counterpart is merged." :) Thanks, Robin. > void iort_get_rmr_sids(struct fwnode_handle *iommu_fwnode, > struct list_head *head); > void iort_put_rmr_sids(struct fwnode_handle *iommu_fwnode, > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel