From: Mark Brown <broonie@kernel.org>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Willy Tarreau <w@1wt.eu>, Christian Brauner <brauner@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Shuah Khan <shuah@kernel.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 1/2] tools/nolibc: Provide vfork()
Date: Mon, 9 Jun 2025 16:43:55 +0100 [thread overview]
Message-ID: <4a4ef323-25e9-4bb5-bde4-9ad740693246@sirena.org.uk> (raw)
In-Reply-To: <df6f5620-5986-4080-bb00-c7bee856bf66@t-8ch.de>
[-- Attachment #1: Type: text/plain, Size: 642 bytes --]
On Mon, Jun 09, 2025 at 05:34:33PM +0200, Thomas Weißschuh wrote:
> On 2025-06-09 16:08:56+0100, Mark Brown wrote:
> > +#ifndef sys_vfork
> This ifndef is not necessary here.
> No architecture has a special version.
Ah, I was adding it defensively in case it was needed in future.
> > +static __attribute__((unused))
> > +pid_t sys_vfork(void)
> > +{
> > +#ifdef __NR_vfork
> For consistency:
> #if defined(__NR_vfork)
Are you sure? I'm seeing an awful lot of #ifdef __NR_foo instances in
sys.h - it looks like the idiom is to use that unless it either needs an
additional condition (with || or &&) or is an elif.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-06-09 16:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-09 15:08 [PATCH 0/2] kselftest/arm64: Add coverage for the interaction of vfork() and GCS Mark Brown
2025-06-09 15:08 ` [PATCH 1/2] tools/nolibc: Provide vfork() Mark Brown
2025-06-09 15:25 ` Thomas Weißschuh
2025-06-09 15:34 ` Thomas Weißschuh
2025-06-09 15:43 ` Mark Brown [this message]
2025-06-09 15:51 ` Thomas Weißschuh
2025-06-09 15:08 ` [PATCH 2/2] kselftest/arm64: Add a test for vfork() with GCS Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a4ef323-25e9-4bb5-bde4-9ad740693246@sirena.org.uk \
--to=broonie@kernel.org \
--cc=brauner@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=shuah@kernel.org \
--cc=w@1wt.eu \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox