From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6483ECAAD3 for ; Mon, 5 Sep 2022 17:37:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=knFo+5wbbez6QIlGDqiKv0+Ga9nKLKRc5K+YTnKbQOM=; b=QdwAdSl/jIX3rH mPN076AIH5mfN1jS6n2w5m56bbyOZ9HJRfcbjnUetGEPT/uw0YEfya+Npa7m1kMI+ddM8QolXtCye Dc5SsJ0XJ9mywtouw79nX2QK8oGyiHGK4HLQ63l20Vlwd6phJFQnHTT0HItmOU0SpYXCNdvbqimHL f8h4ryh1RRVOL0z8pZYBoTHY7u7eY5UZmQAX+QXpn6P8J1qQz+uDv2XGbOAwcPAVxSihLrD7DO5La FH+EU5W0qnEDAWTI3HF1bDrO0hPWPhb7ucpTCMXuxQprRweIBIZ7oJ2zA1371Pyr8PiH5EnZotys3 CS65RpRbUH239LjzKKfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVG1o-007fZS-EH; Mon, 05 Sep 2022 17:36:57 +0000 Received: from mail-lf1-f42.google.com ([209.85.167.42]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oV8pI-00H2fu-FZ; Mon, 05 Sep 2022 09:55:37 +0000 Received: by mail-lf1-f42.google.com with SMTP id z6so12336249lfu.9; Mon, 05 Sep 2022 02:55:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=m6bwvWKIYsYkkQiw6WkHW3VenkfYyqcqiN7fetf2fKA=; b=IHLIbQ5vHZQVIyqqjxII8xfEjM3Q6fZoeMqDFdIiU0vsFp6oi7h0IwMdNfx1vPlnFp ZPEemHQtgtDg6DfHplUdQ9jQ9sLqz7D7QN4FLqbsDi3rJNDxpjjlWDcgUMOkA9w2Tjs9 x9VWcOV0/2DW1Hg36LsG6DteksM93YpJyP0rfadAndCJKb/yY4pF55KE51FqNTxioDRe KBJzVpsAFs2k6LKzsnJmjaNF0PAQrTJoMhIKZekTRu34MSjNFM9c+GyRzLjBHe1ybOQZ eLbeL6kyIXJDXmENmbtGhQKPn5KPfZrIYSXNEMQPhMhg5ikHY+XI6LCK0LoPM/K1/Mnt uzTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=m6bwvWKIYsYkkQiw6WkHW3VenkfYyqcqiN7fetf2fKA=; b=LPjRzBg191omE7ZQMgpxbPT7pdYx4LoVz7CP6esFrGhutdtlxrwVuxATZzOURpbwIa VJpeCX+G1pBWQH3l5YTNPovL3pU1585XhIWblsa2SYwkSiHuD6v5LCoyR8foFii7wxnX RlO2MRHfwPSAgJldW0Jf0ngLf6xB31SqI86aLU3h9XgYK6wii0dGKxP8+KRKdYo9/k6b Mm8lJ3B2JgiR8UgsH0ktOu/AG+l09vP2vv9YfHEfuq4gRqnPp7CInb6XWJSKo/xXjKd6 CqsqTDWenzJ1G5qVaWOxtI28nfVEv1OKpCzekT/kWTVYKmQt2SllNQF/6u9n7JWeYeTV UB/g== X-Gm-Message-State: ACgBeo3bPJInQ+kuMkG5gtWDu0tWCsR/O+2HQiCak6UgE0/2dCrsfW3u 4krzcvR+QnTO17wgIafr4jc= X-Google-Smtp-Source: AA6agR4gwPt5aivllJzzHsjCuIDbWlzFIp6/PHCkmSvNiw6IUsaZdTaionvGINkVRjZdKCtkzi3jFA== X-Received: by 2002:a19:6b16:0:b0:48c:e218:7c51 with SMTP id d22-20020a196b16000000b0048ce2187c51mr15164353lfa.681.1662371728951; Mon, 05 Sep 2022 02:55:28 -0700 (PDT) Received: from [172.16.194.135] ([213.255.186.46]) by smtp.gmail.com with ESMTPSA id v27-20020ac258fb000000b0048b13d0b896sm1141980lfo.141.2022.09.05.02.55.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Sep 2022 02:55:28 -0700 (PDT) Message-ID: <4a536310-3f79-d248-dc48-5cdbd640e04a@gmail.com> Date: Mon, 5 Sep 2022 12:55:26 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v1 08/11] regulator: bd71815: switch to using devm_fwnode_gpiod_get() Content-Language: en-US To: Dmitry Torokhov , Thierry Reding , Mark Brown , Lorenzo Pieralisi , Claudiu Beznea , Liam Girdwood , Wim Van Sebroeck , Greg Kroah-Hartman , Guenter Roeck , Miquel Raynal , Linus Walleij , Felipe Balbi , Alexandre Belloni , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Vignesh Raghavendra , Daniel Vetter , Thomas Petazzoni , Alexandre Torgue , Marc Zyngier , Richard Weinberger , David Airlie , Nicolas Ferre , Alyssa Rosenzweig , Bartosz Golaszewski , Jonathan Hunter , Rob Herring , Maxime Coquelin , Bjorn Helgaas , =?UTF-8?Q?Pali_Roh=c3=a1r?= Cc: linux-watchdog@vger.kernel.org, linux-usb@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pci@vger.kernel.org, linux-tegra@vger.kernel.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org References: <20220903-gpiod_get_from_of_node-remove-v1-0-b29adfb27a6c@gmail.com> <20220903-gpiod_get_from_of_node-remove-v1-8-b29adfb27a6c@gmail.com> From: Matti Vaittinen In-Reply-To: <20220903-gpiod_get_from_of_node-remove-v1-8-b29adfb27a6c@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220905_025532_630751_6D9A9D02 X-CRM114-Status: GOOD ( 17.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/5/22 09:31, Dmitry Torokhov wrote: > I would like to stop exporting OF-specific devm_gpiod_get_from_of_node() > so that gpiolib can be cleaned a bit, so let's switch to the generic > fwnode property API. > > Signed-off-by: Dmitry Torokhov Reviewed-by: Matti Vaittinen > > diff --git a/drivers/regulator/bd71815-regulator.c b/drivers/regulator/bd71815-regulator.c > index acaa6607898e..c2b8b8be7824 100644 > --- a/drivers/regulator/bd71815-regulator.c > +++ b/drivers/regulator/bd71815-regulator.c > @@ -571,11 +571,10 @@ static int bd7181x_probe(struct platform_device *pdev) > dev_err(&pdev->dev, "No parent regmap\n"); > return -ENODEV; > } > - ldo4_en = devm_gpiod_get_from_of_node(&pdev->dev, > - pdev->dev.parent->of_node, > - "rohm,vsel-gpios", 0, > - GPIOD_ASIS, "ldo4-en"); > > + ldo4_en = devm_fwnode_gpiod_get(&pdev->dev, > + dev_fwnode(pdev->dev.parent), > + "rohm,vsel", GPIOD_ASIS, "ldo4-en"); > if (IS_ERR(ldo4_en)) { > ret = PTR_ERR(ldo4_en); > if (ret != -ENOENT) > -- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel