From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD794C47258 for ; Thu, 25 Jan 2024 09:40:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tMWYVH2ou5fGID6ajzxqhd02cmROxt6dyWa/j+mwPMo=; b=UOvFy7vzRoZdBa 4wa+oEKzt20dEEmDvWPJTZTgrFli9okPTrZOuv1R4OUruX/GFmSt/eg3eLL88sgUWeTb+joy6Z/mw gEYj8JSOnmOQ+nz2umVa3o600h3Tr1Y+K01IZNrjC/qZOZJt7W5M6H8QcdjgmNI5766YLMRMcrd2m N7eZXgfaIVS6fpVEwbe0SufXBmYgrmtzi70/S8ycc36fhhTIR7/1N+bI4C98TYJ1xKZm8gS0QMh2i dZboHvf5JkK/k+4nv6bocuXDBETGwal2M++5KmPN//q9UyYdyvXaNfGjX623MRf5VDgl/xQKTPP4Z zvGGipThlA6uy4Funj9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rSwDP-007axc-1t; Thu, 25 Jan 2024 09:40:07 +0000 Received: from madrid.collaboradmins.com ([46.235.227.194]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rSwDJ-007av1-2T; Thu, 25 Jan 2024 09:40:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1706175594; bh=LHVp2Aq1cKc1dUF9nEIRvfSxerS4jkPtOKuHQWo2Y4U=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=HNmTjZM+cfx0ARK433VvR4AuJnBRyXEw1t7MXW/7qvt8fNu48UCHv4cGpps2Qfcbk NGgtbIaDvr/RhskarosTfvZSg14zgPUZMG7XDzzbLas/ExbbsCvwvImusFlzByYYzN aVqYqvgloem1PAXShyRctp6AR5WHU81qFV2b62goE7KJX115atg9Z0jmiDGNIwQme9 sNNf+Hh0/LwbOSI8lHzCHV9urNkt8yCSyIQBblPKFyDOfqpdZUeeGCFuhfu60QRhCn uR85MzEx4+KRNHeOJ2tV3S25GhjmP/vrJ2nmfkE29b/fBzAnO0AzTePS8J4CJvcAHS q8KxPCEnHllqA== Received: from [100.115.223.179] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 9F4D937820BC; Thu, 25 Jan 2024 09:39:53 +0000 (UTC) Message-ID: <4a68ff4b-fafc-4d51-91c3-304b01562945@collabora.com> Date: Thu, 25 Jan 2024 11:39:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] dt-bindings: phy: Add Rockchip HDMI/DP Combo PHY schema Content-Language: en-US To: Krzysztof Kozlowski , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Philipp Zabel , Johan Jonker , Sebastian Reichel , Sascha Hauer , Andy Yan , Algea Cao Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com References: <20240119193806.1030214-1-cristian.ciocaltea@collabora.com> <20240119193806.1030214-3-cristian.ciocaltea@collabora.com> <18f66108-98e7-49b3-b362-880121438fc6@linaro.org> From: Cristian Ciocaltea In-Reply-To: <18f66108-98e7-49b3-b362-880121438fc6@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240125_014003_182634_9311B9A4 X-CRM114-Status: UNSURE ( 9.17 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/25/24 11:11, Krzysztof Kozlowski wrote: > On 19/01/2024 20:38, Cristian Ciocaltea wrote: >> + soc { >> + #address-cells = <2>; >> + #size-cells = <2>; >> + >> + hdptxphy_grf: syscon@fd5e0000 { >> + compatible = "rockchip,rk3588-hdptxphy-grf", "syscon"; >> + reg = <0x0 0xfd5e0000 0x0 0x100>; >> + }; > > Drop node, not part of this binding. > >> + >> + hdptxphy: phy@fed60000 { > > Drop label. > >> + compatible = "rockchip,rk3588-hdptx-phy"; >> + reg = <0x0 0xfed60000 0x0 0x2000>; >> + clocks = <&cru CLK_USB2PHY_HDPTXRXPHY_REF>, <&cru PCLK_HDPTX0>; >> + clock-names = "ref", "apb"; > > With these two changes: > > Reviewed-by: Krzysztof Kozlowski Will do, thanks for the review! Regards, Cristian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel