From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B32D5C433F5 for ; Mon, 23 May 2022 15:26:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:From: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HS+GTezPAhIgWcNgcZaV97aGjSk4sm4RmKkH7RzXxH4=; b=JF7Oom7ccfdy+m 1SP2gRDI4dSr/wBzj2u395AjrgITuW2gOEOxiZG2U/q8DVo18adkB5+EKoluuxzw7LOrTxdxozWXu WN9bqJNNcP2mlfFJ44XwuN37pYyui93XEv4ODqK3G2QNn8kKgFiEB/Yi/mTaTMAmettylsvIpINYz Nd6IvAC8XC6cQmKFKcpJnaeJ6keGIBTWQDvJmkUhtzoAZ3h1594VfMyH28EXZvea4919gTlosFmAL US55o2CHLKt4SROrPybx3+hQV+Q5H1ZTAVH88anMx3Vjo6UPSfjldl1pbQju4jvM2riNRbCaMGXx4 DeNq+BesyFKJtsF2f3eg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nt9vg-004v5a-VZ; Mon, 23 May 2022 15:25:09 +0000 Received: from mail-lj1-x230.google.com ([2a00:1450:4864:20::230]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nt9vd-004v35-0T for linux-arm-kernel@lists.infradead.org; Mon, 23 May 2022 15:25:07 +0000 Received: by mail-lj1-x230.google.com with SMTP id m6so17662058ljb.2 for ; Mon, 23 May 2022 08:25:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language :from:to:cc:references:in-reply-to:content-transfer-encoding; bh=2w+Ay74cy7OoOg37g3PaLjsP1sHLBt98ivncMEHUTZE=; b=orFcSTvpnjF2Ul0w/eFhjws6UEFRdIdVSVYukzC2tF+nVYSnHFaaxmflPfpw8qz8qF ik6PDz0cc8Oj7SbKnxObem78aoMCd+xjnQdgKZpY6s9du2FQPRFqXEjMx84zUfHaUSK5 +5aDtV1uK8iokGkuUohuvW0L7k1LR2OiZl2HdjndCXqss8DzPENH45G9Pn+m8EbPTZWj s+yQdMDgWjXD29XD7VpFK84XPEWt40wdVzAc/6a6ogfXkT3SjLENjQgnwyFLEMwVUB+D l6dZ/senYVrTWPdoKxCU+dfRc+i8YOVwhR0C5kGIt9sZB5w8tkbzjEogHF6UqQKtnniS cVUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=2w+Ay74cy7OoOg37g3PaLjsP1sHLBt98ivncMEHUTZE=; b=KR1dw+H12VHpzD+Zvp8b24IDjdUrmwal0rjrm3xSwhqbe6tHsRpiG2gijbIIjTk/WC Qbk6QM/peq6D/QQ/T1Z4rDcMeSLdniSmiHJDcP2bpt8aZP8CwOAzBdsf2tRlXjHwFpme cL8bFGTzb7VXNmhxPQSYkdiAtMZqtxB9/yNMA2+rSgH+T5xMKnGJO3Xkpbu3XzBbO7Ry 1AapohIUeKqu9s+ANpCtGms943DoP2/ByBCYC+7RhmI6tXDtAeqX1GClHuGR50d7q7Qr jXbnaecChU/E3/2Q90EIRSm0mOKA1AYxjlonudTKTBeJLC6ylxLW/m8IWbo/8sO4al8F aP+g== X-Gm-Message-State: AOAM533dSSKwvxl2VBZkYoqmfQ8g2OzSy+sLaw/SkZ8wekb+1tR68V0V s6j2UagjGHcbCZjMraVIowRFEA== X-Google-Smtp-Source: ABdhPJwQ7LooGvEvT4dpWheOhDWqxQVg6IroKOSOYNqnIDRYboL3316+ca6IHfgol4Aq3EeOYOdhag== X-Received: by 2002:a2e:9c43:0:b0:250:a467:414 with SMTP id t3-20020a2e9c43000000b00250a4670414mr13242328ljj.358.1653319498852; Mon, 23 May 2022 08:24:58 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id v4-20020a056512096400b0047255d2119bsm2026580lft.202.2022.05.23.08.24.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 May 2022 08:24:58 -0700 (PDT) Message-ID: <4a69902f-a545-23a1-1430-e5ece16997e9@linaro.org> Date: Mon, 23 May 2022 17:24:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v1 11/19] dt-bindings: reset: npcm: Add support for NPCM8XX Content-Language: en-US From: Krzysztof Kozlowski To: Geert Uytterhoeven Cc: Tomer Maimon , Avi Fishman , Tali Perry , Joel Stanley , Patrick Venture , Nancy Yuen , Benjamin Fair , Rob Herring , Krzysztof Kozlowski , Michael Turquette , Stephen Boyd , Philipp Zabel , Greg KH , Daniel Lezcano , Thomas Gleixner , Wim Van Sebroeck , Guenter Roeck , Catalin Marinas , Will Deacon , Arnd Bergmann , Olof Johansson , Jiri Slaby , Shawn Guo , =?UTF-8?Q?Bj=c3=b6rn_Andersson?= , Marcel Ziswiler , Vinod Koul , Biju Das , Nobuhiro Iwamatsu , Robert Hancock , =?UTF-8?Q?Jonathan_Neusch=c3=a4fer?= , Lubomir Rintel , arm-soc , devicetree , Linux Kernel Mailing List , linux-clk , "open list:SERIAL DRIVERS" , Linux Watchdog Mailing List , Linux ARM References: <20220522155046.260146-1-tmaimon77@gmail.com> <20220522155046.260146-12-tmaimon77@gmail.com> <86cd6a37-70ad-3a90-bc8a-dcd8b41f1175@linaro.org> <62562cdf-93e3-f642-5bbd-48329eff33ea@linaro.org> In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220523_082505_113658_45031F35 X-CRM114-Status: GOOD ( 18.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23/05/2022 17:22, Krzysztof Kozlowski wrote: >> I think you are taking a too-extremist standpoint. >> The two extremes are: >> 1. Numbers correspond to hardware numbers, and are easy to look up >> in the hardware documentation (e.g. GIC SPI interrupt numbers). >> => Use the hardcoded numbers in DTS. > > And such numbers (like GIC_SPI interrupt numbers) do not go to bindings. > They go to DTS only. > >> 2. Numbers do not correspond to hardware numbers, so we had to >> invent our own definitions and numbers, usually loosely >> based on some table in the hardware documentation. >> The driver will have to look up the numbers in a data >> structure, to know how to program the hardware. >> The numbers become part of the DT ABI, and cannot be changed >> (header file is append-only). >> => Use the binding definitions in DTS. > > Correct. > > However this patch is some mixture of both approaches. > > The same pointed by Arnd: > https://lore.kernel.org/linux-devicetree/CAK8P3a0fDJQvGLEtG0fxLkG08Fh9V7LEMPsx4AaS+2Ldo_xWxw@mail.gmail.com/ ...and one more from Arnd: https://lore.kernel.org/linux-devicetree/CAK8P3a1APzs74YTcZ=m43G3zrmwJZKcYSTvV5eDDQX-37UY7Tw@mail.gmail.com/ Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel