From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2252BC4167B for ; Wed, 29 Nov 2023 00:19:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QPvIGDuLLcO8KbGCpTZ1gYE6onYH1DpQpRtL4Pf0b+0=; b=A9RRP7APbmooQA VtftPzIt3S04BMgyHR9s9z7rGNO2nuhEHshY59DFyZRR8TOQgnvPWAtGEDLGd9/B4dmIN2shikxFO dDo9eruLGasU250VenWPTW9Rag9bxJFioQgO5n8LJFmXfwmYHZoJwTiEXILHRpX8/jnye8A8eYHZ0 rQwZvJKQBCWki3i7mJ9f3n4G6zuCZOfFAx/cy9t6xJuB8ik5S3c9UGOdNX9VRLHaIctBezMU//OuJ 1jLA0AQniWLwlbGSjMYTP0I8Vsb4DoLskVJeqT0k3VDFxwDHOdxgEOxM1WTYZm7NbgLxMKWH9Ks2p V111amuYA1uieFdc9llg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r88Ia-006ew1-0O; Wed, 29 Nov 2023 00:19:28 +0000 Received: from pi.codeconstruct.com.au ([203.29.241.158] helo=codeconstruct.com.au) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r88IW-006evE-20 for linux-arm-kernel@lists.infradead.org; Wed, 29 Nov 2023 00:19:26 +0000 Received: from [192.168.68.112] (ppp118-210-131-38.adl-adc-lon-bras33.tpg.internode.on.net [118.210.131.38]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id C8EB620173; Wed, 29 Nov 2023 08:19:09 +0800 (AWST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1701217154; bh=dk/ur1RQW3iSmbO2wQE4io8VUkp6+K+uoymueMamZHg=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=GIAkYfOyibSsdEqnXCDSdp7D18aGaGAUgQIZUt1T7ELSgV6ttYVwpLxqwnWClUCvb V39xOaFy/s73LGvRAH3gSpAMiN2NVy5ivuP8FZEk3nRunQZUVagLBhTINw/2oW9Upr p1DhJ8skCfCFIJmAY+yeUFxDZwog8b+gvtu+DBOwsbuObxSFPy/6vng10+31GZGrV/ LP5KlDGcC88/0tBcYb7Xd2EoNW6VNSZc8xV4F0gs/UMbSiNriwAmX9pBDrCMSCa0id 3NAQPHgVxH8EQ+RqLsoqIJuYKpCNzXdZ0QijrjDRNABl6Hfy3TkqIOZ+12He4YsvD+ bqgDHgnoJZOgw== Message-ID: <4a9fe86f0349106adaa4e0c04c5839bab631f26c.camel@codeconstruct.com.au> Subject: Re: [PATCH v2 RESEND 1/2] i2c: aspeed: Fix unhandled Tx done with NAK From: Andrew Jeffery To: Quan Nguyen , Brendan Higgins , Benjamin Herrenschmidt , Joel Stanley , Andi Shyti , Wolfram Sang , Jae Hyun Yoo , Guenter Roeck , linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Cc: Cosmo Chou , Open Source Submission , Phong Vo , "Thang Q . Nguyen" Date: Wed, 29 Nov 2023 10:49:08 +1030 In-Reply-To: <20231128075236.2724038-2-quan@os.amperecomputing.com> References: <20231128075236.2724038-1-quan@os.amperecomputing.com> <20231128075236.2724038-2-quan@os.amperecomputing.com> User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231128_161925_090486_EADA4846 X-CRM114-Status: GOOD ( 25.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAyMDIzLTExLTI4IGF0IDE0OjUyICswNzAwLCBRdWFuIE5ndXllbiB3cm90ZToKPiBV bmRlciBub3JtYWwgY29uZGl0aW9ucywgYWZ0ZXIgdGhlIGxhc3QgYnl0ZSBpcyBzZW50IGJ5IHRo ZSBTbGF2ZSwgdGhlCj4gVFhfTkFLIGludGVycnVwdCBpcyByYWlzZWQuICBIb3dldmVyLCBpdCBp cyBhbHNvIG9ic2VydmVkIHRoYXQKPiBzb21ldGltZXMgdGhlIE1hc3RlciBpc3N1ZXMgdGhlIG5l eHQgdHJhbnNhY3Rpb24gdG9vIHF1aWNrbHkgd2hpbGUgdGhlCj4gU2xhdmUgSVJRIGhhbmRsZXIg aXMgbm90IHlldCBpbnZva2VkIGFuZCB0aGUgVFhfTkFLIGludGVycnVwdCBmb3IgdGhlCj4gbGFz dCBieXRlIG9mIHRoZSBwcmV2aW91cyBSRUFEX1BST0NFU1NFRCBzdGF0ZSBoYXMgbm90IGJlZW4g YWNr4oCZZWQuCj4gVGhpcyBUWF9OQUsgaW50ZXJydXB0IGlzIHRoZW4gcmFpc2VkIHRvZ2V0aGVy IHdpdGggU0xBVkVfTUFUQ0ggaW50ZXJydXB0Cj4gYW5kIFJYX0RPTkUgaW50ZXJydXB0IG9mIHRo ZSBuZXh0IGNvbWluZyB0cmFuc2FjdGlvbiBmcm9tIE1hc3Rlci4gVGhlCj4gU2xhdmUgSVJRIGhh bmRsZXIgY3VycmVudGx5IGhhbmRsZXMgdGhlIFNMQVZFX01BVENIIGFuZCBSWF9ET05FLCBidXQK PiBpZ25vcmVzIHRoZSBUWF9OQUssIGNhdXNpbmcgY29tcGxhaW50cyBzdWNoIGFzCj4gImFzcGVl ZC1pMmMtYnVzIDFlNzhhMDQwLmkyYy1idXM6IGlycSBoYW5kbGVkICE9IGlycS4gRXhwZWN0ZWQK PiAweDAwMDAwMDg2LCBidXQgd2FzIDB4MDAwMDAwODQiCj4gCj4gVGhpcyBjb21taXQgYWRkcyBj b2RlIHRvIGhhbmRsZSB0aGlzIGNhc2UgYnkgZW1pdHRpbmcgYSBTTEFWRV9TVE9QIGV2ZW50Cj4g Zm9yIHRoZSBUWF9OQUsgYmVmb3JlIHByb2Nlc3NpbmcgdGhlIFJYX0RPTkUgZm9yIHRoZSBjb21p bmcgdHJhbnNhY3Rpb24KPiBmcm9tIHRoZSBNYXN0ZXIuCj4gCj4gRml4ZXM6IGY5ZWI5MTM1MGJi MiAoImkyYzogYXNwZWVkOiBhZGRlZCBzbGF2ZSBzdXBwb3J0IGZvciBBc3BlZWQgSTJDIGRyaXZl ciIpCj4gU2lnbmVkLW9mZi1ieTogUXVhbiBOZ3V5ZW4gPHF1YW5Ab3MuYW1wZXJlY29tcHV0aW5n LmNvbT4KPiAtLS0KPiB2MjoKPiAgICsgU3BsaXQgdG8gc2VwYXJhdGUgc2VyaWVzIFtKb2VsXQo+ ICAgKyBBZGRlZCB0aGUgRml4ZXMgbGluZSBbSm9lbF0KPiAgICsgUmV2aXNlZCBjb21taXQgbWVz c2FnZSBbUXVhbl0KPiAKPiB2MToKPiAgICsgRmlyc3QgaW50cm9kdWNlZCBpbgo+IGh0dHBzOi8v bG9yZS5rZXJuZWwub3JnL2FsbC8yMDIxMDUxOTA3NDkzNC4yMDcxMi0xLXF1YW5Ab3MuYW1wZXJl Y29tcHV0aW5nLmNvbS8KPiAtLS0KPiAgZHJpdmVycy9pMmMvYnVzc2VzL2kyYy1hc3BlZWQuYyB8 IDUgKysrKysKPiAgMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2kyYy9idXNzZXMvaTJjLWFzcGVlZC5jIGIvZHJpdmVycy9pMmMvYnVzc2Vz L2kyYy1hc3BlZWQuYwo+IGluZGV4IDI4ZTJhNWZjNDUyOC4uNzk0NzZiNDYyODViIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvaTJjL2J1c3Nlcy9pMmMtYXNwZWVkLmMKPiArKysgYi9kcml2ZXJzL2ky Yy9idXNzZXMvaTJjLWFzcGVlZC5jCj4gQEAgLTI1Myw2ICsyNTMsMTEgQEAgc3RhdGljIHUzMiBh c3BlZWRfaTJjX3NsYXZlX2lycShzdHJ1Y3QgYXNwZWVkX2kyY19idXMgKmJ1cywgdTMyIGlycV9z dGF0dXMpCj4gIAo+ICAJLyogU2xhdmUgd2FzIHJlcXVlc3RlZCwgcmVzdGFydCBzdGF0ZSBtYWNo aW5lLiAqLwo+ICAJaWYgKGlycV9zdGF0dXMgJiBBU1BFRURfSTJDRF9JTlRSX1NMQVZFX01BVENI KSB7Cj4gKwkJaWYgKGlycV9zdGF0dXMgJiBBU1BFRURfSTJDRF9JTlRSX1RYX05BSyAmJgo+ICsJ CSAgICBidXMtPnNsYXZlX3N0YXRlID09IEFTUEVFRF9JMkNfU0xBVkVfUkVBRF9QUk9DRVNTRUQp IHsKPiArCQkJaXJxX2hhbmRsZWQgfD0gQVNQRUVEX0kyQ0RfSU5UUl9UWF9OQUs7Cj4gKwkJCWky Y19zbGF2ZV9ldmVudChzbGF2ZSwgSTJDX1NMQVZFX1NUT1AsICZ2YWx1ZSk7Cj4gKwkJfQoKU28g d2UncmUgYWxyZWFkeSAocGFydGlhbGx5KSBwcm9jZXNzaW5nIHRoaXMgYSBiaXQgbGF0ZXIgb24g bGluZSAyODc6CgpodHRwczovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dp dC90b3J2YWxkcy9saW51eC5naXQvdHJlZS9kcml2ZXJzL2kyYy9idXNzZXMvaTJjLWFzcGVlZC5j P2g9djYuNy1yYzMjbjI4NwoKRnJvbSB0aGUgZGVzY3JpcHRpb24gb2YgdGhlIHByb2JsZW0gaW4g dGhlIGNvbW1pdCBtZXNzYWdlIGl0IHNvdW5kcwpsaWtlIHRoZSBvcmRlcmluZyBvZiB0aGUgaW50 ZXJydXB0IHByb2Nlc3NpbmcgaXMgaW5jb3JyZWN0LiBQcmlvciB0bwp0aGlzIHBhdGNoIHdlIGhh dmUgdGhlIGZvbGxvd2luZyBhYnN0cmFjdCBvcmRlcmluZyBvZiBpbnRlcnJ1cHQKcHJvY2Vzc2lu ZzoKCjEuIFByb2Nlc3MgQVNQRUVEX0kyQ0RfSU5UUl9TTEFWRV9NQVRDSAoyLiBQcm9jZXNzIEFT UEVFRF9JMkNEX0lOVFJfVFhfTkFLIHdoZW4gaW4gQVNQRUVEX0kyQ19TTEFWRV9SRUFEX1BST0NF U1NFRAoKV2l0aCB0aGlzIHBhdGNoIHdlIGhhdmU6CgoxLiBJZiBBU1BFRURfSTJDRF9JTlRSX1NM QVZFX01BVENIIHRoZW4gcHJvY2VzcyBBU1BFRURfSTJDRF9JTlRSX1RYX05BSyB3aGVuIGluIEFT UEVFRF9JMkNfU0xBVkVfUkVBRF9QUk9DRVNTRUQKMi4gUHJvY2VzcyBBU1BFRURfSTJDRF9JTlRS X1NMQVZFX01BVENICjMuIFByb2Nlc3MgQVNQRUVEX0kyQ0RfSU5UUl9UWF9OQUsgd2hlbiBpbiBB U1BFRURfSTJDX1NMQVZFX1JFQURfUFJPQ0VTU0VECgpUaGF0IGZlZWxzIGEgYml0IGNvbXBsZXgg YW5kIHJlZHVuZGFudC4gV2hhdCBJIHRoaW5rIHdlIGNhbiBoYXZlIGlzOgoKMS4gUHJvY2VzcyBB U1BFRURfSTJDRF9JTlRSX1RYX05BSyB3aGVuIGluIEFTUEVFRF9JMkNfU0xBVkVfUkVBRF9QUk9D RVNTRUQKMS4gUHJvY2VzcyBBU1BFRURfSTJDRF9JTlRSX1NMQVZFX01BVENICgpNb3ZpbmcgYmFj ayBmcm9tIHRoZSBhYnN0cmFjdCB0byB0aGUgY29uY3JldGUsIGltcGxlbWVudGluZyB3aGF0IEkK YmVsaWV2ZSB3ZSBuZWVkIHdvdWxkIGxvb2sgc29tZXRoaW5nIGxpa2UgdGhpcyBwYXRjaDoKCmRp ZmYgLS1naXQgYS9kcml2ZXJzL2kyYy9idXNzZXMvaTJjLWFzcGVlZC5jIGIvZHJpdmVycy9pMmMv YnVzc2VzL2kyYy1hc3BlZWQuYwppbmRleCAyOGUyYTVmYzQ1MjguLjk4ZGQwZjM1YzlkMyAxMDA2 NDQKLS0tIGEvZHJpdmVycy9pMmMvYnVzc2VzL2kyYy1hc3BlZWQuYworKysgYi9kcml2ZXJzL2ky Yy9idXNzZXMvaTJjLWFzcGVlZC5jCkBAIC0yNTEsNiArMjUxLDE0IEBAIHN0YXRpYyB1MzIgYXNw ZWVkX2kyY19zbGF2ZV9pcnEoc3RydWN0IGFzcGVlZF9pMmNfYnVzICpidXMsIHUzMiBpcnFfc3Rh dHVzKQogCiAgICAgICAgY29tbWFuZCA9IHJlYWRsKGJ1cy0+YmFzZSArIEFTUEVFRF9JMkNfQ01E X1JFRyk7CiAKKyAgICAgICAvKiBDb21wbGV0ZSBhbnkgYWN0aXZlIHJlYWQgKi8KKyAgICAgICBp ZiAoaXJxX3N0YXR1cyAmIEFTUEVFRF9JMkNEX0lOVFJfVFhfTkFLICYmCisgICAgICAgICAgIGJ1 cy0+c2xhdmVfc3RhdGUgPT0gQVNQRUVEX0kyQ19TTEFWRV9SRUFEX1BST0NFU1NFRCkgeworICAg ICAgICAgICAgICAgaXJxX2hhbmRsZWQgfD0gQVNQRUVEX0kyQ0RfSU5UUl9UWF9OQUs7CisgICAg ICAgICAgICAgICBpMmNfc2xhdmVfZXZlbnQoc2xhdmUsIEkyQ19TTEFWRV9TVE9QLCAmdmFsdWUp OworICAgICAgICAgICAgICAgYnVzLT5zbGF2ZV9zdGF0ZSA9IEFTUEVFRF9JMkNfU0xBVkVfU1RP UDsKKyAgICAgICB9CisKICAgICAgICAvKiBTbGF2ZSB3YXMgcmVxdWVzdGVkLCByZXN0YXJ0IHN0 YXRlIG1hY2hpbmUuICovCiAgICAgICAgaWYgKGlycV9zdGF0dXMgJiBBU1BFRURfSTJDRF9JTlRS X1NMQVZFX01BVENIKSB7CiAgICAgICAgICAgICAgICBpcnFfaGFuZGxlZCB8PSBBU1BFRURfSTJD RF9JTlRSX1NMQVZFX01BVENIOwpAQCAtMjg0LDExICsyOTIsNiBAQCBzdGF0aWMgdTMyIGFzcGVl ZF9pMmNfc2xhdmVfaXJxKHN0cnVjdCBhc3BlZWRfaTJjX2J1cyAqYnVzLCB1MzIgaXJxX3N0YXR1 cykKICAgICAgICAgICAgICAgIGlycV9oYW5kbGVkIHw9IEFTUEVFRF9JMkNEX0lOVFJfTk9STUFM X1NUT1A7CiAgICAgICAgICAgICAgICBidXMtPnNsYXZlX3N0YXRlID0gQVNQRUVEX0kyQ19TTEFW RV9TVE9QOwogICAgICAgIH0KLSAgICAgICBpZiAoaXJxX3N0YXR1cyAmIEFTUEVFRF9JMkNEX0lO VFJfVFhfTkFLICYmCi0gICAgICAgICAgIGJ1cy0+c2xhdmVfc3RhdGUgPT0gQVNQRUVEX0kyQ19T TEFWRV9SRUFEX1BST0NFU1NFRCkgewotICAgICAgICAgICAgICAgaXJxX2hhbmRsZWQgfD0gQVNQ RUVEX0kyQ0RfSU5UUl9UWF9OQUs7Ci0gICAgICAgICAgICAgICBidXMtPnNsYXZlX3N0YXRlID0g QVNQRUVEX0kyQ19TTEFWRV9TVE9QOwotICAgICAgIH0KIAogICAgICAgIHN3aXRjaCAoYnVzLT5z bGF2ZV9zdGF0ZSkgewogICAgICAgIGNhc2UgQVNQRUVEX0kyQ19TTEFWRV9SRUFEX1JFUVVFU1RF RDoKClRob3VnaHRzPyBJIGhhdmVuJ3QgdGVzdGVkIGl0LCBpdCdzIGp1c3Qgc29tZXRoaW5nIHRv IHRocm93IGRhcnRzIGF0LgoKQW5kcmV3CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJt LWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=