From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83EABCAC587 for ; Thu, 11 Sep 2025 18:14:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fO/wiS6u6wjvvJi4t2wKktGS6aYq1CiRm5gJANXSAXc=; b=G+kBOghWj/+8oUyNkBkOvXvCGq 6Ai7LjRdEbUt+K0UCJP267gOoCahAgQHgSftnVCczpEFSd3Yl+4Y0HHfdYR+whG9UuRPwiDWp5P/f S02ms1hPGiZOFLLhMlXJgckbMrzm+HvrnFWIwt1HHZwDBVemzXnRLsb5WUQ37+UOfUaTahb63Dbtd vqc8NeW8f5xtaH4ehWGWGOtHoTjvVAr9Eps9H1qQ88pVTKWq1hOGiR5G+lzz0Q0aIn4vgqTnJ5q0Z gJ/gByVVq4NKACNruUn+OG2j1IQNufJ2VeBDxGhbrpac5UYnDUtwaVUi02bz5deBdmyHunnDty6OW S87DQPew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uwloJ-00000004fEa-0ucd; Thu, 11 Sep 2025 18:14:19 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uwloE-00000004fC6-1EIT for linux-arm-kernel@lists.infradead.org; Thu, 11 Sep 2025 18:14:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757614452; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=fO/wiS6u6wjvvJi4t2wKktGS6aYq1CiRm5gJANXSAXc=; b=ROmY7FUr4RFL/ZaJdrsNgxHvb34/pAbXIlb5WxbBwVKDvroNMtrDVkA7rzCQcYhEqSXRQA 0VFaqRk3jkv/sWR13uf/Zx5Uy6ZZXnT/pLJX/OgNKiWbPBcIoPslsk8bRSG1mp0j3ZqF+8 6b5EBJooQIW0NgT5Tk70lsJr6Axak8M= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-28-0lm2iDF8McGeeLVn7ynJ2g-1; Thu, 11 Sep 2025 14:14:10 -0400 X-MC-Unique: 0lm2iDF8McGeeLVn7ynJ2g-1 X-Mimecast-MFC-AGG-ID: 0lm2iDF8McGeeLVn7ynJ2g_1757614449 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-45b920e0c25so6846265e9.3 for ; Thu, 11 Sep 2025 11:14:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757614449; x=1758219249; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fO/wiS6u6wjvvJi4t2wKktGS6aYq1CiRm5gJANXSAXc=; b=Y0WvMHnIZBeSPOvQ3+egjjVKNN1NFc1JrqZ7Cs91oNeB4gxA63w50TXsoWp44AGrIH sVsS0qAt22Ye7BQEUprLlpl6C1S0UUbDz6saezx2pnjXoJ4yd/eE7dEoVU0idJv07y+0 CU/RXl4pIgb2UmtAsBOqsebBRBcbupaVn2euzkKesnWFwILEqWwi+TL4Rc5PDZT+GtOY A2TiQi6TK+X2Npve6yZym6CSnddLuXpazKUzr7qsMQEilJisXmQOzyKjUS3ZFnqgZ60K 1ArKvEZowuct3+chzBKE3zP0VgxsER/rsDQICzXAiTx2/IVKdZRoKHi6gbpvCfRoiUmP dhVg== X-Forwarded-Encrypted: i=1; AJvYcCU8kvkFlmWPFPEqE/xvofghYb6LxEhWVBD8d4M8oO8qPPMgklywjerNSCtrFUtEnvX1BH3DBUVsoH2sGaO4Gfzr@lists.infradead.org X-Gm-Message-State: AOJu0Yzhg5S8nyLqyxLaQT2BaZbyxEEBF7l0kiKyux/MN1bbh7f3LF1z vAPFYgei6eNUFFkXgQTOUOLtCLQ989nFdK8B4dIEeLdxubwlfOjclMoCA1Qbc+kV9eHlhGs3Ap4 lQ6hO3Fm7ifnNyarNifq1j29Z1dlBm0WLiUeFCosXHHhtVy+NSFyq1uJAMz2lkImVEGanEhxWqJ U8 X-Gm-Gg: ASbGnctkVp5MHiYrCt+er/9mkFRR7niBUvouDO+vpC01kIXDHQrZHtqGgSHBU7noony Tx4YSiMU9KfEcb6IkTDavp2k8ebO4cmYCuTbNw04CnH9QBUnRvKdQNdvvCUFZfbtTn+yMgdBNRV o8GAaL55Zze0KC1whsX4g+JSev28GsCLQYhLEaS9h+Ca2owz/myjP/APgGpBXfoRFoS4TpZoP70 KPwNeV6Kt0vx4QxqVRkIpMGrWLS/AKMB23ns3huze94fJk/Iro3KFNC4L4LxtwGAPkEfJtdha+y 0+t0U3SvaX6cGFbtWB1fhs8rNWT3iSuHgc1S5dPpzrLyoh7DR+GphVIInw4zTbLROzeAwYUvCqu kGRuMuOTsI064q4h8hBcVopSH/u3WSkVckUdQa5nGtHaYHvE6g9wkNEunXUlIjbALCsY= X-Received: by 2002:a05:600c:1387:b0:45b:88d6:8ddb with SMTP id 5b1f17b1804b1-45f211fc2dbmr3761115e9.37.1757614449368; Thu, 11 Sep 2025 11:14:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHYPRnitXgQzHDt7U0vwEWEhdUB9NK1hJir7NlpKTdRzaPw5ybQNZDXnkL32l5S2EQ4JRmc7Q== X-Received: by 2002:a05:600c:1387:b0:45b:88d6:8ddb with SMTP id 5b1f17b1804b1-45f211fc2dbmr3760825e9.37.1757614448886; Thu, 11 Sep 2025 11:14:08 -0700 (PDT) Received: from ?IPV6:2003:d8:2f42:b000:db8b:7655:f60f:812b? (p200300d82f42b000db8b7655f60f812b.dip0.t-ipconnect.de. [2003:d8:2f42:b000:db8b:7655:f60f:812b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45e016b5cbcsm35354055e9.11.2025.09.11.11.14.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Sep 2025 11:14:08 -0700 (PDT) Message-ID: <4aa28016-5678-4c66-8104-8dcc3fa2f5ce@redhat.com> Date: Thu, 11 Sep 2025 20:14:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/7] mm: introduce local state for lazy_mmu sections To: Kevin Brodsky , Alexander Gordeev Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andreas Larsson , Andrew Morton , Boris Ostrovsky , Borislav Petkov , Catalin Marinas , Christophe Leroy , Dave Hansen , "David S. Miller" , "H. Peter Anvin" , Ingo Molnar , Jann Horn , Juergen Gross , "Liam R. Howlett" , Lorenzo Stoakes , Madhavan Srinivasan , Michael Ellerman , Michal Hocko , Mike Rapoport , Nicholas Piggin , Peter Zijlstra , Ryan Roberts , Suren Baghdasaryan , Thomas Gleixner , Vlastimil Babka , Will Deacon , Yeoreum Yun , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, Mark Rutland References: <20250908073931.4159362-1-kevin.brodsky@arm.com> <20250908073931.4159362-3-kevin.brodsky@arm.com> <2fecfae7-1140-4a23-a352-9fd339fcbae5-agordeev@linux.ibm.com> <47ee1df7-1602-4200-af94-475f84ca8d80@arm.com> <29383ee2-d6d6-4435-9052-d75a263a5c45@redhat.com> <9de08024-adfc-421b-8799-62653468cf63@arm.com> <4b4971fd-0445-4d86-8f3a-6ba3d68d15b7@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <4b4971fd-0445-4d86-8f3a-6ba3d68d15b7@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: DBJBNZyDoqjs9HsI0mxVfJmFdNbebLL41vTNO8KR3_k_1757614449 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250911_111414_405937_FBCA1BD9 X-CRM114-Status: GOOD ( 23.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org >>> On the other hand, with a pagefault_disabled-like approach, there is no >>> way to instruct call {3} to fully exit lazy_mmu regardless of the >>> nesting level. >> >> Sure there is, with a better API. See below. :) > > I meant while keeping the existing shape of the API but yes fair enough! Time to do it properly I guess :) [...] >> Assume we store in the task_struct >> >> uint8_t lazy_mmu_enabled_count; >> bool lazy_mmu_paused; > > I didn't think of that approach! I can't immediately see any problem > with it, assuming we're fine with storing arch-specific context in > thread_struct (which seems to be the case as things stand). Right, just to complete the picture: a) We will have some CONFIG_ARCH_LAZY_MMU b) Without that config, all lazy_mmu_*() functions are a nop and no lazy_mmu_state is stored in task_struct struct lazy_mmu_state { uint8_t enabled_count; bool paused; } c) With that config, common-code lazy_mmu_*() functions implement the updating of the lazy_mmu_state in task_struct and call into arch code on the transition from 0->1, 1->0 etc. Maybe that can be done through exiting arch_enter_lazy_mmu_mode()/arch_leave_lazy_mmu_mode() callbacks, maybe we need more. I feel like we might be able to implement that through the existing helpers. > >> >> We can do things like >> >> a) Sanity check that while we are paused that we get no more >> enable/disable requests >> b) Sanity check that while we are paused that we get no more pause >> requests. > > These are good points - and this is only possible with such global > state. (Similarly we can check that the counter never underflows.) Exactly. [..] > > Overall what you're proposing seems sensible to me, the additional > fields in task_struct don't take much space and we can keep the API > unchanged in most cases. It is also good to have the option to check > that the API is used correctly. I'll reply to the cover letter to let > anyone who didn't follow this thread chip in, before I go ahead and try > out that new approach. And on top of the proposal above we will have some struct arch_lazy_mmu_state; define by the architecture (could be an empty struct on most). We can store that inside "struct lazy_mmu_state;" or if we ever have to, start returning only that from the enable/disable etc. functions. For now, I'd say just store it in the task struct in the lazy_mmu_state. But we can always adjust later if required. In the first (this) series we probably don't even have to introduce arch_lazy_mmu_state. -- Cheers David / dhildenb